From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753785AbdCPVvM (ORCPT ); Thu, 16 Mar 2017 17:51:12 -0400 Received: from mx1.redhat.com ([209.132.183.28]:43216 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752233AbdCPVvL (ORCPT ); Thu, 16 Mar 2017 17:51:11 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com D932AC03070B Authentication-Results: ext-mx07.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx07.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=eric.auger@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com D932AC03070B Subject: Re: [RFC PATCH 10/33] irqchip/gic-v4-its: Allow use of indirect VCPU tables To: Marc Zyngier , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu References: <1484648454-21216-1-git-send-email-marc.zyngier@arm.com> <1484648454-21216-11-git-send-email-marc.zyngier@arm.com> Cc: Thomas Gleixner , Jason Cooper , Christoffer Dall From: Auger Eric Message-ID: <8839c465-109b-b7b1-974d-b244b69fdb06@redhat.com> Date: Thu, 16 Mar 2017 22:50:35 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <1484648454-21216-11-git-send-email-marc.zyngier@arm.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Thu, 16 Mar 2017 21:50:41 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 17/01/2017 11:20, Marc Zyngier wrote: > The VCPU tables can be quite sparse as well, and it makes sense > to use indirect tables as well if possible. I think patch title should be irqchip/gic-v3-its:.. Eric > > Signed-off-by: Marc Zyngier > --- > drivers/irqchip/irq-gic-v3-its.c | 20 +++++++++++++------- > 1 file changed, 13 insertions(+), 7 deletions(-) > > diff --git a/drivers/irqchip/irq-gic-v3-its.c b/drivers/irqchip/irq-gic-v3-its.c > index c92ff4d..14305db1 100644 > --- a/drivers/irqchip/irq-gic-v3-its.c > +++ b/drivers/irqchip/irq-gic-v3-its.c > @@ -1060,10 +1060,13 @@ static int its_setup_baser(struct its_node *its, struct its_baser *baser, > return 0; > } > > -static bool its_parse_baser_device(struct its_node *its, struct its_baser *baser, > - u32 psz, u32 *order) > +static bool its_parse_indirect_baser(struct its_node *its, > + struct its_baser *baser, > + u32 psz, u32 *order) > { > - u64 esz = GITS_BASER_ENTRY_SIZE(its_read_baser(its, baser)); > + u64 tmp = its_read_baser(its, baser); > + u64 type = GITS_BASER_TYPE(tmp); > + u64 esz = GITS_BASER_ENTRY_SIZE(tmp); > u64 val = GITS_BASER_InnerShareable | GITS_BASER_WaWb; > u32 ids = its->device_ids; > u32 new_order = *order; > @@ -1102,8 +1105,9 @@ static bool its_parse_baser_device(struct its_node *its, struct its_baser *baser > if (new_order >= MAX_ORDER) { > new_order = MAX_ORDER - 1; > ids = ilog2(PAGE_ORDER_TO_SIZE(new_order) / (int)esz); > - pr_warn("ITS@%pa: Device Table too large, reduce ids %u->%u\n", > - &its->phys_base, its->device_ids, ids); > + pr_warn("ITS@%pa: %s Table too large, reduce ids %u->%u\n", > + &its->phys_base, its_base_type_string[type], > + its->device_ids, ids); > } > > *order = new_order; > @@ -1154,8 +1158,10 @@ static int its_alloc_tables(struct its_node *its) > if (type == GITS_BASER_TYPE_NONE) > continue; > > - if (type == GITS_BASER_TYPE_DEVICE) > - indirect = its_parse_baser_device(its, baser, psz, &order); > + if (type == GITS_BASER_TYPE_DEVICE || > + type == GITS_BASER_TYPE_VCPU) > + indirect = its_parse_indirect_baser(its, baser, > + psz, &order); > > err = its_setup_baser(its, baser, cache, shr, psz, order, indirect); > if (err < 0) { >