From: Nadav Amit <namit@vmware.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Josh Poimboeuf <jpoimboe@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: Suboptimal inline heuristics due to non-code sections
Date: Tue, 1 May 2018 16:54:49 +0000 [thread overview]
Message-ID: <883C8C03-3CB2-47A0-888E-4D53C76FB281@vmware.com> (raw)
In-Reply-To: <CA+55aFwowsU8wVN9AY4qWdY+LBf7iW1BNBZfwpfxuOE36iiNbQ@mail.gmail.com>
Linus Torvalds <torvalds@linux-foundation.org> wrote:
> On Tue, May 1, 2018 at 9:46 AM Nadav Amit <namit@vmware.com> wrote:
>
>> My bad. It’s not the new-line. Let me do some more digging.
>
> From the gcc docs:
>
> Some targets require that GCC track the size of each instruction used
> in order to generate correct code. Because the final length of the
> code produced by an @code{asm} statement is only known by the
> assembler, GCC must make an estimate as to how big it will be. It
> does this by counting the number of instructions in the pattern of the
> @code{asm} and multiplying that by the length of the longest
> instruction supported by that processor. (When working out the number
> of instructions, it assumes that any occurrence of a newline or of
> whatever statement separator character is supported by the assembler --
> typically @samp{;} --- indicates the end of an instruction.)
>
> so it probably counts newlines and semicolons to estimate the size.
Thanks. I probably did not have enough coffee.
I’ll work on it.
Regards,
Nadav
next prev parent reply other threads:[~2018-05-01 16:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-01 6:50 Nadav Amit
2018-05-01 13:40 ` Josh Poimboeuf
2018-05-01 15:37 ` Linus Torvalds
2018-05-01 16:39 ` Nadav Amit
2018-05-01 16:46 ` Nadav Amit
2018-05-01 16:51 ` Linus Torvalds
2018-05-01 16:54 ` Nadav Amit [this message]
2018-05-01 16:48 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=883C8C03-3CB2-47A0-888E-4D53C76FB281@vmware.com \
--to=namit@vmware.com \
--cc=jpoimboe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®