From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 73170346AC0 for ; Thu, 22 Jan 2026 15:09:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769094588; cv=none; b=uYGv0PTfrDFQ93wH6gnqYwbrlPB5ti9k767BYmvWMC46MgFQqlIB65xtyfaNqkZCHLOnDHxHqyGdjAdClZYyvnHzmgbIOlWtW4GMectYfA1lIwJVD4wZLRxGeY4G3Bjn3oNoVV4ss4Icbh38xXQvUth/yW/KszQb6kTKgE/ElzY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769094588; c=relaxed/simple; bh=sbE5PufeqT0RKnJMK69xNDsIF1LFlMLkOQuKUzGXezw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=kO6mVZMIt3ODuybmFJa/phV3vVYjSR/iBgwKYMXbI2zKfRIwSX2YBFVQBZNPU3BBRsceJM22bbjnosXCu5r/EgMQl63ZqG/0ZwrdxtIy9h6DlhD+P0VCvUhAZW9F0ek8Lgvqf8y4oBdKjIWuz7JyAgahL+5pf6fb36dZwdkC3l4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Wwi0fW2Q; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=U2fIL4Of; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Wwi0fW2Q"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="U2fIL4Of" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60M8buTW645944 for ; Thu, 22 Jan 2026 15:09:45 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= ZXAmimutHpoBcMO8lKrYN+CbkqYF9tLexxbBKbeEfH4=; b=Wwi0fW2QMu1zsVHF iCkej8GUvuF1gpj2Q+sCXrz13x9cDXuaKmXjeTp0ecm6QAUZXN78x1ke5ErN9C0e 58/HnaauB4ZbrrfEMWXE8/GpXdrOsDdjKd366vjcJGV+SjJr2RKCzCwbbKndG59I ZzKIr+V7PxxmiyRq5j4IXg+bXdEPRdTaG1TYPUFOq7bOH2qJ/+9Sxei8YIXDzHUi t1n3Y1b38btaxLlVDENrX42EISyCCYovc649/6g6b4xl6wf3wpyLIV+PjapL9y1b d7qZoy+nsrZ1OhKWdjrtW+/0rtuOymJnPbANllpuabUImYVznVWKaERpP34oZWE+ 4g2g9g== Received: from mail-ua1-f69.google.com (mail-ua1-f69.google.com [209.85.222.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4bu8j9tjec-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 22 Jan 2026 15:09:45 +0000 (GMT) Received: by mail-ua1-f69.google.com with SMTP id a1e0cc1a2514c-9414fc8eb29so183582241.3 for ; Thu, 22 Jan 2026 07:09:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1769094585; x=1769699385; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ZXAmimutHpoBcMO8lKrYN+CbkqYF9tLexxbBKbeEfH4=; b=U2fIL4OfJFnNv8HOp/DDX/XwZgUbYTud2gPL2mR10OlLEag+7w1BrBRTWHSmZtvJAG /QX6wAPT7N0esYOZgmEqY+Db3thAeI8X3mvqxsvw/HGpEJzKQXuWCvmYEvtr3pCp95im hBuysXfjfonb8Cy7GvXg2rUYxUPTz60CHcrYsHdPnb5DD6x20vWp3rfnkVK3Hj2LSScw de0y6loVNLRYqoawUsf1WeOQ3A9+MXyUAubEZXacb6Zkb5gN+7EOlRXKvOZbWtaDX556 ekT7uDkNwus/HGZoCzafte3c4e/mc+OSdm65kkE3WnVKTBbnosl6nTWnIsqeS2Bow4NI RmLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769094585; x=1769699385; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ZXAmimutHpoBcMO8lKrYN+CbkqYF9tLexxbBKbeEfH4=; b=gL88ZWE/HZQJoeyLoEaiH/TPfEWVntBVTp27jfGlgmT0qm5KXkgNNC8C14wuAAGPbF 40AMUVs/fuWonEFCgS+6n0rXqNhQBaTLqFf3h5+o7IN5DJg6RQVofau0cWKvU5e44tEY KAXP09kszc80HLQGb8vc+vHe6dQFWx+BmVdxGTuHQ47ByL7Hxt6UPgHRuKegBFKgieU+ hFmUgSt0rPswZGeLW7gxiJ038cUh+QYnXsA3E3/2QSRCf8T0ONm1eyU3xM8Z1vjuc23N CBWp65KvVH7mCVARSO8RQF9AIiL3iAbmMbKga4FAiyBDepvomozpkNsya0XO5u/Q6zvk Mm6A== X-Forwarded-Encrypted: i=1; AJvYcCVwkIaEiLoDLyikeyCgEqdQVSk5H7tij5OZUvEtWRXFcKqOGCC9/X/eis3VKGwbY+qLLwTZapGo0TRzKOo=@vger.kernel.org X-Gm-Message-State: AOJu0Yz/Qf6jhg8ih9D3CaVKnFvsZH1nsWtAKzX9pfnIdgpc0WX2xLIl PsLyEedzlI2gFMr5KvBjjfzTXq1Rx/kQSqZSdGQOhOnA2ccSdzGYdXirPfD11cqVJ71wEqA2AeP tQSuV97e7Jj1FQv5MT/NkXZO4Uk79OmdFLGWEPzxBhvF9cZlbOQfC3F/wD9kfpTnnokU= X-Gm-Gg: AZuq6aLlYLV1cn1FvrhyKOzSIq4fuI/yGUDAzJ9tzI1GduvEBUeM3U6u4ShXl72IA8G whUYwX10S/ik5dxEfQohqmNH8OtvDkJzStNd8bXtvXSsRF7I2F84j1+uAAN2pxETO48+703C7fJ UBPtMqUV+HbCtEmfX/E5VyV2w65kspQaiabt21OcdvZFMaZx8o5euC2w9fCsmh7zloWbTSgHdDU 2+SPUBaGoDrGXXFcY1YzjBlWssj0nup3Kgcku4dKITOsX8CboZRG/8vOEA+Qp2OXF6saRdj0tV7 2n1Lku5jqkFka3mI+/xaLmeow/C5lPz6YCUwvArrcnQO6+GIhzeSMnb9dbGZsk2W079ZDFCzYvD R/zF3o45Y4iBcjWBe5a6BVKFHxWDXkpp3v3agLsrjVtzq52e3EcKEFcVkNCdZyRIJSlI= X-Received: by 2002:a05:6122:129b:b0:566:2275:c2 with SMTP id 71dfb90a1353d-5662f51f3cemr334943e0c.1.1769094584562; Thu, 22 Jan 2026 07:09:44 -0800 (PST) X-Received: by 2002:a05:6122:129b:b0:566:2275:c2 with SMTP id 71dfb90a1353d-5662f51f3cemr334927e0c.1.1769094583999; Thu, 22 Jan 2026 07:09:43 -0800 (PST) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b8795a192b6sm1700239966b.59.2026.01.22.07.09.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 22 Jan 2026 07:09:42 -0800 (PST) Message-ID: <883a2f40-a945-47f0-8022-20ad4146acf3@oss.qualcomm.com> Date: Thu, 22 Jan 2026 16:09:40 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH V1 2/3] ufs: ufs-qcom: Align programming sequence for UFS controller v6.2 To: Nitin Rawat , mani@kernel.org, James.Bottomley@HansenPartnership.com, martin.petersen@oracle.com Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org References: <20260122141331.239354-1-nitin.rawat@oss.qualcomm.com> <20260122141331.239354-3-nitin.rawat@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260122141331.239354-3-nitin.rawat@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: 3PnfwlLgxTZaCkzC5nlT1rjPq7wiViCr X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTIyMDExNSBTYWx0ZWRfX6pRt50lOqiTN JuamSInu6r3TFpZ07wK0LefD0BIkK+3ExMg/42AELxbrUREN+OUq3Zq01rRH1VqSl4HdDUrf4P0 wxiB7prMTIZzC39YffjAYKgpHrd6mi66/zPvB3dJne1fwaDl3hR+46ulywyDXlDQfiKSd8ntOya aMng2LHAyL9rGnycdt/3AwniF88ptWEpzR8z+SBq7vcyhZyvhBkEjtLajKV4btC2BnoblcS6ZAt LYiidSlHnrQxD1/yfnL0A1bK0L0q1/VnWe0iJxA5dJyJuqBf2SgZkU2fFNKkTmlKGFuZEHgFd+F kJUW+woY2LsYJ6xjEfZ8szxCwtTTxeAkBiGXLEYKNzwygnQNYPowfyGdJQJzV1xnrnCmHHdOc4I 2gc5HS86EWY8eV8jW/Ntkx7rsD8QwAXbtoGnK4/HpVxqsm1fq36DUC/XZ7uLsdi2Ie/qP0B7xid 88w4Z9JO4E52g4t6T4w== X-Authority-Analysis: v=2.4 cv=U4CfzOru c=1 sm=1 tr=0 ts=69723db9 cx=c_pps a=UbhLPJ621ZpgOD2l3yZY1w==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=9Ji7Tjym3mbZabC91LcA:9 a=QEXdDO2ut3YA:10 a=TOPH6uDL9cOC6tEoww4z:22 X-Proofpoint-GUID: 3PnfwlLgxTZaCkzC5nlT1rjPq7wiViCr X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.20,FMLib:17.12.100.49 definitions=2026-01-22_02,2026-01-22_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 lowpriorityscore=0 malwarescore=0 spamscore=0 adultscore=0 suspectscore=0 bulkscore=0 clxscore=1015 impostorscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2601220115 On 1/22/26 3:13 PM, Nitin Rawat wrote: > UFS controller v6.2 requires bit 31 in the spare configuration register > to be set for high-speed link startup mode, as per the Hardware > Programming Guide (HPG). Please stick a "Qualcomm" before mentioning UFS controller v6.2, I don't think that is immediately obvious without looking at the code.. > The spare register value is read during host driver initialization but > gets cleared after UFS reset. To align with the UFS v6.2 programming > sequence, preserve the spare register value during initialization and > restore it during link startup to ensure proper high-speed mode I believe you're supposed to write the value yourself, depending on the state of the controller, it's 0 at reset. > Signed-off-by: Nitin Rawat > --- > drivers/ufs/host/ufs-qcom.c | 11 ++++++++--- > drivers/ufs/host/ufs-qcom.h | 1 + > 2 files changed, 9 insertions(+), 3 deletions(-) > > diff --git a/drivers/ufs/host/ufs-qcom.c b/drivers/ufs/host/ufs-qcom.c > index c43bb75d208c..ab5aed241913 100644 > --- a/drivers/ufs/host/ufs-qcom.c > +++ b/drivers/ufs/host/ufs-qcom.c > @@ -686,6 +686,7 @@ static int ufs_qcom_cfg_timers(struct ufs_hba *hba, bool is_pre_scale_up, unsign > static int ufs_qcom_link_startup_notify(struct ufs_hba *hba, > enum ufs_notify_change_status status) > { > + struct ufs_qcom_host *host = ufshcd_get_variant(hba); > int err = 0; > > switch (status) { > @@ -708,6 +709,10 @@ static int ufs_qcom_link_startup_notify(struct ufs_hba *hba, > */ > err = ufshcd_disable_host_tx_lcc(hba); > > + /* Update REG_UFS_DEBUG_SPARE_CFG to set HS-LSS mode in link startup */ "HS/LS"? > + if (host->hw_ver.major == 0x6 && host->hw_ver.minor == 0x2) > + ufshcd_writel(hba, host->spare_cfg, > + REG_UFS_DEBUG_SPARE_CFG); Is that a "only on v6.2", or "starting with v6.2"? Also, I see that this register has more than just this one field, with the previous question in mind, I think a rmw would be desired here Konrad