From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qt1-f182.google.com (mail-qt1-f182.google.com [209.85.160.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 606184657CD for ; Tue, 28 Jul 2026 19:53:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785268430; cv=none; b=kP6TdkqrKCgaIyPN17ife4qSnq4mgegvx7IZbF6MGeR60b1+rnWsY8tKeran/xuVg3Gl8R7cvcmt29+kp8UmYeMFmISgbRwvvOtalIJ3Xh6nYS+Bx8L9f5qHyK+oHg+0Z2r3gH3s5hNNeel4CfjlcATmyZy1vWYj6Oqgj6USrCg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785268430; c=relaxed/simple; bh=Zo7yHfsmbbnTOgBbDPPT7iJ1LJDbKs5DhVu3bUUQDF8=; h=Date:Message-ID:MIME-Version:Content-Type:From:To:Cc:Subject: References:In-Reply-To; b=MFwxrFenCYe1jRgpb082q8+a+/PQYq53MDrqv0PcTSJHqc3I2H4vdM0F0ERCv4VoeMpNipLZF7/NXJTSbrEMwEZldZ3mlLbBlH9hunxReKRSZLPLrIjMYVWuqdp/xvR4+aXp2yxPw8VQFhlvL4kFIAjS0rILQ6QvGjHKBIDy+To= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=paul-moore.com; spf=pass smtp.mailfrom=paul-moore.com; dkim=pass (2048-bit key) header.d=paul-moore.com header.i=@paul-moore.com header.b=VFhYA3t7; arc=none smtp.client-ip=209.85.160.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=paul-moore.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=paul-moore.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=paul-moore.com header.i=@paul-moore.com header.b="VFhYA3t7" Received: by mail-qt1-f182.google.com with SMTP id d75a77b69052e-51c2a449c57so1605881cf.1 for ; Tue, 28 Jul 2026 12:53:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paul-moore.com; s=google; t=1785268428; x=1785873228; darn=vger.kernel.org; h=in-reply-to:references:subject:cc:to:from:content-transfer-encoding :content-type:mime-version:message-id:date:from:to:cc:subject:date :message-id:reply-to:content-type; bh=wHrIhaQi9DJt3hZXGupitmaEmqcs9r2Pk6D5IXCY+/g=; b=VFhYA3t7ng23cclYE0ymAASjD2zZ9+jI5W8poQbp5cQwoI0Y/fKhlgiz0/XqgTpftr 4uk4L1cJq+T9ZrGR2dor9rGx2R+IOTAOOjnVwe5Ktp7+9Sw5XmhjMNwXwI7Cysx7OH9X c6/PyDNcAjmWsXP1Oe9gmZWDWo4P92Gqjc6Xi2cVzKIPO6Jabz95GXpUVUAOg1tyGjbJ uRgh2TScyNOmfXHhBHrP68OOby6TUMmOC6zn4PUZGRkfIs81icb4GDrPEeNmyocWCr0j IZ7Drq12y+3DYpI+2yhwD1enxy/7u/Q107PUCYz18ceQitvHc1qwD3ixwDiTNstew8DZ 8mZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785268428; x=1785873228; h=in-reply-to:references:subject:cc:to:from:content-transfer-encoding :content-type:mime-version:message-id:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=wHrIhaQi9DJt3hZXGupitmaEmqcs9r2Pk6D5IXCY+/g=; b=mAGP+Ul4L9RML8xg+qii+ZLz85UNn2rrLNQGTMhfQM5YjPgzalQMA4gTNsfnJbmkZa pzvtatgX4g8LRjwEHHjaqe4YCCw+Om2piLkCw5gmfddJFske2AFHVcQndPFzk5bmnXZn aI3mLds+pxoEmHHVBK7NlGmDRa8rVNi9roq4o7HcKZUzTGrjPqXFyW9+f+HTYC6zTWrb LfYcDswdgeci4cEKLHiM+z+SSWwzWuB3gqYYnLlWYW+VCMMYGvA6jSe3JX6HyieckG1m Xl1KJemv3TPyAdMODw7PgdaXB43Tnb5BwyHEq05W8BEpIi00whr4s3HLO0qsJ3ZD0GR2 KirQ== X-Forwarded-Encrypted: i=1; AHgh+Rp3BQh3aNigycU1n+okYHAzzF87W3BVHxGQjy18Gev4jIAeo8X5XvRkB4SbgatI9VLZDHHzoXhPvJMKZEo=@vger.kernel.org X-Gm-Message-State: AOJu0YwmDgsnkw/A33Tipk5o8BGzMeVdfHYKxOL23M6cRvT4pTaCAPWE 7ZdmGAlYhksPc0wM1FC2x41ZgCmzpkCLIAf+3yl/bnXgF2iT8hv1zTt8iMZ25ODFUg== X-Gm-Gg: AR+sD13xv+dOUWbRkOpw2iqbAruPm4zHEHfyYtQTIGBQFF3kHvJwGdT0K8p53F16ZZ8 5Qht4FGh9rSMhGi5eHvvaAU0j/tN37zpSGXCfFSRbnx4NrPK6ompDmMMB0BhnfQQtzICKmb+WI1 qLRyKHY1GzG6nCu1KxSLDRNkmSNJGqQymEeyGB/qTpWw320wrD20Jc9/lIbuj0BeO4ef/2jm+VJ uadA0481U2wLy3bQFW3jWL4nWWdeOYLvQ7FE6UhU/FxUWtS9QgHIoHZixWIonSQE4woywIXWqTO NEaXFiCP6EPg6Hnrg+4FPpNoX90FMlMAAyvsKcSB7Fl4dro7B5X/VX7enN40782HTGa8OXiaIoZ 7J+U14nHlGbdBJCIVuRT84h4FjFiXvk4owqc+/rxMs9UsUb1YQKmtYgu0AYCQKyNG2lgLSGPM4k OCnKbnSehYDVYZv+qldf+vgMsNWH5iWHsqe97JLPJTlpBdN2ZGMr3PGL4W8eWn2PqFqkfectUdZ SHQeYrscnwJaMs8OQT4s90tlQ70wiZHDA== X-Received: by 2002:a05:622a:145:b0:527:43a:2f30 with SMTP id d75a77b69052e-529d6faf67cmr36749651cf.1.1785268428368; Tue, 28 Jul 2026 12:53:48 -0700 (PDT) Received: from localhost (pool-71-126-255-178.bstnma.fios.verizon.net. [71.126.255.178]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-529e2dd3d59sm4752421cf.21.2026.07.28.12.53.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Jul 2026 12:53:47 -0700 (PDT) Date: Tue, 28 Jul 2026 15:53:46 -0400 Message-ID: <883ee05917e857f5176178f2f14f3cee@paul-moore.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Mailer: pstg-pwork:20260727_1648/pstg-lib:20260728_1147/pstg-pwork:20260727_1648 From: Paul Moore To: Ricardo Robaina , audit@vger.kernel.org, linux-kernel@vger.kernel.org Cc: eparis@redhat.com, Ricardo Robaina Subject: Re: [PATCH 2/2] audit: drop BUG_ON() from audit_signal_info_syscall() References: <32c8fbc6f680e8309f64fd04f580b6a51bec0176.1785246707.git.rrobaina@redhat.com> In-Reply-To: <32c8fbc6f680e8309f64fd04f580b6a51bec0176.1785246707.git.rrobaina@redhat.com> On Jul 28, 2026 Ricardo Robaina wrote: > > The BUG_ON(axp->pid_count >= AUDIT_AUX_PIDS) check in > audit_signal_info_syscall() will panic the kernel if the signal target > pid array overflows, which is too severe for this situation. > > Replace it with a WARN_ON_ONCE() and return of -EINVAL, instead. > > Signed-off-by: Ricardo Robaina > --- > kernel/auditsc.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/kernel/auditsc.c b/kernel/auditsc.c > index 6610e667c728..2b9ce0b52511 100644 > --- a/kernel/auditsc.c > +++ b/kernel/auditsc.c > @@ -2712,7 +2712,8 @@ int audit_signal_info_syscall(struct task_struct *t) > axp->d.next = ctx->aux_pids; > ctx->aux_pids = (void *)axp; > } > - BUG_ON(axp->pid_count >= AUDIT_AUX_PIDS); > + if (WARN_ON_ONCE(axp->pid_count >= AUDIT_AUX_PIDS)) > + return -EINVAL; Part of me wonders if the WARN_ON_ONCE() should be a pr_err(), possibly ratelimited, but given that I don't recall ever seeing this BUG_ON() trigger I think this is fine. We can always change the WARN_ON_ONCE() later if needed, getting rid of the BUG_ON() is the big win. Merged into audit/dev, thanks. > axp->target_pid[axp->pid_count] = task_tgid_nr(t); > axp->target_auid[axp->pid_count] = audit_get_loginuid(t); > -- > 2.53.0 -- paul-moore.com