mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: comex <comexk@gmail.com>
To: Ralf Jung <post@ralfj.de>
Cc: "Boqun Feng" <boqun.feng@gmail.com>,
	"Andreas Hindborg" <a.hindborg@kernel.org>,
	"Alice Ryhl" <aliceryhl@google.com>,
	"Daniel Almeida" <daniel.almeida@collabora.com>,
	"Benno Lossin" <benno.lossin@proton.me>,
	"Abdiel Janulgue" <abdiel.janulgue@gmail.com>,
	dakr@kernel.org, robin.murphy@arm.com,
	rust-for-linux@vger.kernel.org, "Miguel Ojeda" <ojeda@kernel.org>,
	"Alex Gaynor" <alex.gaynor@gmail.com>,
	"Gary Guo" <gary@garyguo.net>,
	"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
	"Trevor Gross" <tmgross@umich.edu>,
	"Valentin Obst" <kernel@valentinobst.de>,
	linux-kernel@vger.kernel.org, "Christoph Hellwig" <hch@lst.de>,
	"Marek Szyprowski" <m.szyprowski@samsung.com>,
	airlied@redhat.com, iommu@lists.linux.dev, lkmm@lists.linux.dev
Subject: Re: Allow data races on some read/write operations
Date: Tue, 4 Mar 2025 12:18:28 -0800	[thread overview]
Message-ID: <88456D33-C5CA-4F4F-990E-8C5F2AF7EAF9@gmail.com> (raw)
In-Reply-To: <ae8ac31f-c6ad-46ae-80dd-10ec081a16d1@ralfj.de>


> On Mar 4, 2025, at 11:03 AM, Ralf Jung <post@ralfj.de> wrote:
> 
> Those already exist in Rust, albeit only unstably: <https://doc.rust-lang.org/nightly/std/intrinsics/fn.volatile_copy_memory.html>. However, I am not sure how you'd even generate such a call in C? The standard memcpy function is not doing volatile accesses, to my knowledge.

The actual memcpy symbol that exists at runtime is written in assembly, and should be valid to treat as performing volatile accesses.

But both GCC and Clang special-case the memcpy function.  For example, if you call memcpy with a small constant as the size, the optimizer will transform the call into one or more regular loads/stores, which can then be optimized mostly like any other loads/stores (except for opting out of alignment and type-based aliasing assumptions).  Even if the call isn’t transformed, the optimizer will still make assumptions.  LLVM will automatically mark memcpy `nosync`, which makes it undefined behavior if the function “communicate[s] (synchronize[s]) with another thread”, including through “volatile accesses”. [1]

However, these optimizations should rarely trigger misbehavior in practice, so I wouldn’t be surprised if Linux had some code that expected memcpy to act volatile…

But I’m not familiar enough with the codebase to know whether such code actually exists, or where.

(Incidentally, there is a compiler flag to turn the memcpy special-casing off, -fno-builtin.  I pretty much expected that Linux used it.  But I just checked, and it doesn’t.)

For Rust, I don’t know why we haven’t exposed volatile_copy_memory yet.  All I can find are some years-old discussions with no obvious blockers.  I guess nobody has cared enough.  There is also a somewhat stagnant RFC for *atomic* memcpy. [2]

[1] https://llvm.org/docs/LangRef.html, search for 'nosync'
[2] https://github.com/rust-lang/rfcs/pull/3301


  reply	other threads:[~2025-03-04 20:18 UTC|newest]

Thread overview: 70+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-24 11:49 [PATCH v12 0/3] rust: add dma coherent allocator abstraction Abdiel Janulgue
2025-02-24 11:49 ` [PATCH v12 1/3] rust: error: Add EOVERFLOW Abdiel Janulgue
2025-02-24 13:11   ` Andreas Hindborg
2025-02-24 11:49 ` [PATCH v12 2/3] rust: add dma coherent allocator abstraction Abdiel Janulgue
2025-02-24 13:21   ` Alice Ryhl
2025-02-24 16:27     ` Abdiel Janulgue
2025-02-24 13:30   ` QUENTIN BOYER
2025-02-24 16:30     ` Abdiel Janulgue
2025-02-24 14:40   ` Andreas Hindborg
2025-02-24 16:27     ` Abdiel Janulgue
2025-02-24 22:35       ` Daniel Almeida
2025-02-28  8:35       ` Alexandre Courbot
2025-02-28 10:01         ` Danilo Krummrich
2025-02-24 20:07   ` Benno Lossin
2025-02-24 21:40     ` Miguel Ojeda
2025-02-24 23:12     ` Daniel Almeida
2025-03-03 13:00       ` Andreas Hindborg
2025-03-03 13:13         ` Alice Ryhl
2025-03-03 15:21           ` Andreas Hindborg
2025-03-03 15:44             ` Alice Ryhl
2025-03-03 18:45               ` Andreas Hindborg
2025-03-03 19:00               ` Allow data races on some read/write operations Andreas Hindborg
2025-03-03 20:08                 ` Boqun Feng
2025-03-04 19:03                   ` Ralf Jung
2025-03-04 20:18                     ` comex [this message]
2025-03-05  3:24                       ` Boqun Feng
2025-03-05 13:10                         ` Ralf Jung
2025-03-05 13:23                           ` Alice Ryhl
2025-03-05 13:27                             ` Ralf Jung
2025-03-05 14:40                               ` Robin Murphy
2025-03-05 18:43                               ` Andreas Hindborg
2025-03-05 19:30                                 ` Alan Stern
2025-03-05 19:42                                 ` Ralf Jung
2025-03-05 21:26                                   ` Andreas Hindborg
2025-03-05 21:53                                     ` Ralf Jung
2025-03-07  8:43                                       ` Andreas Hindborg
2025-03-18 14:44                                         ` Ralf Jung
2025-03-05 18:41                             ` Andreas Hindborg
2025-03-05 14:25                           ` Daniel Almeida
2025-03-05 18:38                           ` Andreas Hindborg
2025-03-05 22:01                             ` Ralf Jung
2025-03-04  8:28           ` [PATCH v12 2/3] rust: add dma coherent allocator abstraction Abdiel Janulgue
2025-02-25  8:15     ` Abdiel Janulgue
2025-02-25  9:09       ` Alice Ryhl
2025-02-24 22:05   ` Miguel Ojeda
2025-02-25  8:15     ` Abdiel Janulgue
2025-03-03 11:30   ` Andreas Hindborg
2025-03-04  8:58     ` Abdiel Janulgue
2025-03-03 13:08   ` Robin Murphy
2025-03-05 17:41   ` Jason Gunthorpe
2025-03-06 13:37     ` Danilo Krummrich
2025-03-06 15:21       ` Simona Vetter
2025-03-06 15:49         ` Danilo Krummrich
2025-03-06 15:54         ` Danilo Krummrich
2025-03-06 16:18           ` Jason Gunthorpe
2025-03-06 16:34             ` Danilo Krummrich
2025-03-07 10:20               ` Simona Vetter
2025-03-06 16:09         ` Jason Gunthorpe
2025-03-07  8:50           ` Danilo Krummrich
2025-03-07 10:18             ` Simona Vetter
2025-03-07 12:48             ` Jason Gunthorpe
2025-03-07 13:16               ` Simona Vetter
2025-03-07 14:38                 ` Jason Gunthorpe
2025-03-07 17:30                   ` Danilo Krummrich
2025-03-07 18:02                     ` Greg Kroah-Hartman
2025-03-07 16:09               ` Danilo Krummrich
2025-03-07 16:57                 ` Jason Gunthorpe
2025-03-07 19:03                   ` Danilo Krummrich
2025-02-24 11:49 ` [PATCH v12 3/3] MAINTAINERS: add entry for Rust dma mapping helpers device driver API Abdiel Janulgue
2025-02-24 13:10   ` Andreas Hindborg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=88456D33-C5CA-4F4F-990E-8C5F2AF7EAF9@gmail.com \
    --to=comexk@gmail.com \
    --cc=a.hindborg@kernel.org \
    --cc=abdiel.janulgue@gmail.com \
    --cc=airlied@redhat.com \
    --cc=alex.gaynor@gmail.com \
    --cc=aliceryhl@google.com \
    --cc=benno.lossin@proton.me \
    --cc=bjorn3_gh@protonmail.com \
    --cc=boqun.feng@gmail.com \
    --cc=dakr@kernel.org \
    --cc=daniel.almeida@collabora.com \
    --cc=gary@garyguo.net \
    --cc=hch@lst.de \
    --cc=iommu@lists.linux.dev \
    --cc=kernel@valentinobst.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkmm@lists.linux.dev \
    --cc=m.szyprowski@samsung.com \
    --cc=ojeda@kernel.org \
    --cc=post@ralfj.de \
    --cc=robin.murphy@arm.com \
    --cc=rust-for-linux@vger.kernel.org \
    --cc=tmgross@umich.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®