From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754603AbcKUNIT (ORCPT ); Mon, 21 Nov 2016 08:08:19 -0500 Received: from lelnx194.ext.ti.com ([198.47.27.80]:9382 "EHLO lelnx194.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754207AbcKUNG2 (ORCPT ); Mon, 21 Nov 2016 08:06:28 -0500 Subject: Re: [PATCH v2 1/3] usb: xhci: add quirk flag for broken PED bits To: Felipe Balbi , References: <1479394881-13863-1-git-send-email-rogerq@ti.com> <1479394881-13863-2-git-send-email-rogerq@ti.com> <87wpfxqc6n.fsf@linux.intel.com> CC: , , Sergei Shtylyov From: Roger Quadros Message-ID: <884946ba-5f07-e187-1145-56431f5e4617@ti.com> Date: Mon, 21 Nov 2016 15:05:37 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <87wpfxqc6n.fsf@linux.intel.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="CQXIVLbIMcdwHkcIxSvueK27g1bBSodIF" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --CQXIVLbIMcdwHkcIxSvueK27g1bBSodIF Content-Type: multipart/mixed; boundary="cJj6TSxQ741X6L6EARMQuPcRx88cHMq2i"; protected-headers="v1" From: Roger Quadros To: Felipe Balbi , mathias.nyman@intel.com Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Sergei Shtylyov Message-ID: <884946ba-5f07-e187-1145-56431f5e4617@ti.com> Subject: Re: [PATCH v2 1/3] usb: xhci: add quirk flag for broken PED bits References: <1479394881-13863-1-git-send-email-rogerq@ti.com> <1479394881-13863-2-git-send-email-rogerq@ti.com> <87wpfxqc6n.fsf@linux.intel.com> In-Reply-To: <87wpfxqc6n.fsf@linux.intel.com> --cJj6TSxQ741X6L6EARMQuPcRx88cHMq2i Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 21/11/16 13:56, Felipe Balbi wrote: >=20 > Hi, >=20 > Roger Quadros writes: >> diff --git a/drivers/usb/host/xhci.h b/drivers/usb/host/xhci.h >> index f945380..6553903 100644 >> --- a/drivers/usb/host/xhci.h >> +++ b/drivers/usb/host/xhci.h >> @@ -1656,6 +1656,9 @@ struct xhci_hcd { >> #define XHCI_SSIC_PORT_UNUSED (1 << 22) >> #define XHCI_NO_64BIT_SUPPORT (1 << 23) >> #define XHCI_MISSING_CAS (1 << 24) >> +/* For controller with a broken Port Disable implementation */ >> +#define XHCI_BROKEN_PORT_PED (1 << 21) >=20 > since back when I first wrote this, bit 21 has been taken. You should b= e > using bit 25 here. >=20 My bad. I'll fix this up. cheers, -roger --cJj6TSxQ741X6L6EARMQuPcRx88cHMq2i-- --CQXIVLbIMcdwHkcIxSvueK27g1bBSodIF Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJYMvElAAoJENJaa9O+djCTSlAP/0sgiM7vnTJhDoAK6abzQlSw 4j2xp2rR9jSGaxuJA1S9N7X6itH8BZfRlyWOmAuthlB97+4s4k27HRfX0mvjdZoY zuT+WNYc6o6fpZsm5ZNvruzdMSeGDZ1kfns+aXiUtXPG/Kpjw8wqLftqQr8TPByc og89dTj0/uGffJ4BM5c+GJWIJqdaPQ5zIy0cJPN4zrMXqEtkWj7qL3FPyWk15XQR sTPZROyzuAxRWJgBs3O3Z49ZaYyN6ZdTXpRIronE1ZJu0K0gvnzYnFDyadcX1Yx5 qi6ZdcZ8UPcM55IxLpAByk0CfPwjQM7z+roTUTY+wmCsgvo+i1r6dscEii3JjRSK XR/PMoliR5TY1ToWUr8BVCHEWTSa2dw2yHPdxD6wMkg3el7D+JUv++CwiW2tTYhl 0meKV3ZO1JKvwUyZHUw68VfNbvnFxwJiJruQKSQaej2hUMgc5QDYBGN30D2nFspA ++UtfjgzpEujXyoY91Bysaw1ZeLMd6ng1GSCVtuNfD0yaFyTuUuw/ezM3yW02qrc 4p4BefW0IW+9B42imyuX+IoodEr3QXot+/2GhZFYwbt74Neg72gwBTrjilSCiqOE isBwK07dUgU1Pr3d4dkTGQ4hRqPdecZOJtxazg/yEl3jea9ll3OEzOrwV1Q4wi7b J8OENjW35TW5HHgA6btT =1aOc -----END PGP SIGNATURE----- --CQXIVLbIMcdwHkcIxSvueK27g1bBSodIF--