From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753862AbdEIOx7 (ORCPT ); Tue, 9 May 2017 10:53:59 -0400 Received: from mail-pf0-f173.google.com ([209.85.192.173]:35738 "EHLO mail-pf0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753684AbdEIOx5 (ORCPT ); Tue, 9 May 2017 10:53:57 -0400 Subject: Re: [PATCH BUGFIX] block, bfq: use pointer entity->sched_data only if set To: Paolo Valente References: <20170509093727.2595-1-paolo.valente@linaro.org> Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, ulf.hansson@linaro.org, linus.walleij@linaro.org, broonie@kernel.org From: Jens Axboe Message-ID: <884a6d3c-40aa-c2a6-9981-82d48148429b@kernel.dk> Date: Tue, 9 May 2017 08:53:52 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20170509093727.2595-1-paolo.valente@linaro.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/09/2017 03:37 AM, Paolo Valente wrote: > In the function __bfq_deactivate_entity, the pointer > entity->sched_data could happen to be used before being properly > initialized. This led to a NULL pointer dereference. This commit fixes > this bug by just using this pointer only where it is safe to do so. Added, thanks. -- Jens Axboe