From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92799C4332F for ; Sat, 19 Nov 2022 12:58:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232054AbiKSM6O (ORCPT ); Sat, 19 Nov 2022 07:58:14 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48328 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231803AbiKSM6L (ORCPT ); Sat, 19 Nov 2022 07:58:11 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 849E79E942 for ; Sat, 19 Nov 2022 04:57:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1668862635; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3ZLrYgChEilRNXcz3x7R3l8Y3PsKaP5ZzhNykAinpEw=; b=D8yQOnqe0yRMJC55VrDHl1byFK5UWMcouqDx9cgATH5Z9Nni0C0hf+vcUCC0lqIBKtqvqz oZS8OD+uMyi8KSxCjh372EPaRkIY5/YNnkkvhWU3z4hsNUoYcqWPYVQ4WJz4N3GkyNn6rp THGNlkxEJ1xTEOm8eriC8SCzp5dITZQ= Received: from mail-ej1-f72.google.com (mail-ej1-f72.google.com [209.85.218.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-354-VoypbKL5NRy3lUVqaelRhw-1; Sat, 19 Nov 2022 07:57:14 -0500 X-MC-Unique: VoypbKL5NRy3lUVqaelRhw-1 Received: by mail-ej1-f72.google.com with SMTP id nb1-20020a1709071c8100b007ae4083d6f5so4656890ejc.15 for ; Sat, 19 Nov 2022 04:57:14 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=3ZLrYgChEilRNXcz3x7R3l8Y3PsKaP5ZzhNykAinpEw=; b=0UHycSJFA7Ykb1xLK9nXO2Nudc2pLLAiTqOEYnD5ETwESPiW/Ph7QlJ1FCjlEe1AL4 q4i45KmeaKaJ8P7sFBxJNB9UVsPyB03/C3yzfHIpTpqX8jDFRZUrpSb9WCfmwP1ecXR5 AaxNoK3C8d12zYGDFH9QivL6nrQs23+1Kq2E9+P9SAkEEGoqvvzv3nYFw1zj0BFvCO+t icIMH5Vq9kfmw4yI5LITzPDAlI1m/6C7+fiVUc31gOLu352va3F4ZCF+cXHQdkPKA7NR M7HWEiPFUdqyqskOSglLsY3Tu/2BBVEUjEfKIIJuDFPnZ42PGZqYw+Oxe1ogmXrtsVgo mTiw== X-Gm-Message-State: ANoB5pmo15756p5Xp3Rq3nOUn2KcGJ/S5rFBR4nyF5E/u0O69F7pSCAZ 0MB8eBaHpOsB8SfbZOYl3DqAru3i7DXza0rGwrVKMMYZmAZk5zF7JV19yiHwAaVEaGgheNtkweZ OZzwB20sVq39G/RW/WhH4lqqm X-Received: by 2002:a17:906:5fd5:b0:7ac:2e16:a8d3 with SMTP id k21-20020a1709065fd500b007ac2e16a8d3mr9732523ejv.667.1668862633183; Sat, 19 Nov 2022 04:57:13 -0800 (PST) X-Google-Smtp-Source: AA0mqf6HDkDtWh48gl/FrRJ3EIAftfWdoS4Smgp3VaG7iQJdTKGPoTQRnsYwFEM94VzW3+nHMG1JQg== X-Received: by 2002:a17:906:5fd5:b0:7ac:2e16:a8d3 with SMTP id k21-20020a1709065fd500b007ac2e16a8d3mr9732519ejv.667.1668862633025; Sat, 19 Nov 2022 04:57:13 -0800 (PST) Received: from ?IPV6:2001:1c00:c1e:bf00:d69d:5353:dba5:ee81? (2001-1c00-0c1e-bf00-d69d-5353-dba5-ee81.cable.dynamic.v6.ziggo.nl. [2001:1c00:c1e:bf00:d69d:5353:dba5:ee81]) by smtp.gmail.com with ESMTPSA id v19-20020aa7dbd3000000b0045b910b0542sm2896451edt.15.2022.11.19.04.57.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 19 Nov 2022 04:57:12 -0800 (PST) Message-ID: <884b308e-2775-4817-372b-a622cf382b72@redhat.com> Date: Sat, 19 Nov 2022 13:57:11 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH 221/606] Input: elan_i2c_core - Convert to i2c's .probe_new() Content-Language: en-US, nl To: =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= , Angel Iglesias , Lee Jones , Grant Likely , Wolfram Sang , Dmitry Torokhov , Greg Kroah-Hartman Cc: linux-i2c@vger.kernel.org, kernel@pengutronix.de, =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org References: <20221118224540.619276-1-uwe@kleine-koenig.org> <20221118224540.619276-222-uwe@kleine-koenig.org> From: Hans de Goede In-Reply-To: <20221118224540.619276-222-uwe@kleine-koenig.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 11/18/22 23:39, Uwe Kleine-König wrote: > From: Uwe Kleine-König > > The probe function doesn't make use of the i2c_device_id * parameter so it > can be trivially converted. > > Signed-off-by: Uwe Kleine-König Thanks, patch looks good to me: Reviewed-by: Hans de Goede Regards, Hans > --- > drivers/input/mouse/elan_i2c_core.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/input/mouse/elan_i2c_core.c b/drivers/input/mouse/elan_i2c_core.c > index d4eb59b55bf1..a25d5b055553 100644 > --- a/drivers/input/mouse/elan_i2c_core.c > +++ b/drivers/input/mouse/elan_i2c_core.c > @@ -1188,8 +1188,7 @@ static void elan_disable_regulator(void *_data) > regulator_disable(data->vcc); > } > > -static int elan_probe(struct i2c_client *client, > - const struct i2c_device_id *dev_id) > +static int elan_probe(struct i2c_client *client) > { > const struct elan_transport_ops *transport_ops; > struct device *dev = &client->dev; > @@ -1438,7 +1437,7 @@ static struct i2c_driver elan_driver = { > .probe_type = PROBE_PREFER_ASYNCHRONOUS, > .dev_groups = elan_sysfs_groups, > }, > - .probe = elan_probe, > + .probe_new = elan_probe, > .id_table = elan_id, > }; >