From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E8CDEB64DD for ; Mon, 31 Jul 2023 02:31:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229785AbjGaCbG (ORCPT ); Sun, 30 Jul 2023 22:31:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36134 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229735AbjGaCbE (ORCPT ); Sun, 30 Jul 2023 22:31:04 -0400 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C3AE910D7; Sun, 30 Jul 2023 19:31:01 -0700 (PDT) Received: from canpemm100004.china.huawei.com (unknown [172.30.72.57]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4RDhzC6NRnzrS1F; Mon, 31 Jul 2023 10:29:59 +0800 (CST) Received: from [10.174.179.14] (10.174.179.14) by canpemm100004.china.huawei.com (7.192.105.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Mon, 31 Jul 2023 10:30:59 +0800 Subject: Re: [PATCH] scsi:libsas: Simplify sas_queue_reset and remove unused code To: Damien Le Moal , Wenchao Hao , John Garry , "James E . J . Bottomley" , "Martin K . Petersen" , , CC: References: <20230729102451.2452826-1-haowenchao2@huawei.com> <27bb586c-af75-c2da-1b07-02bfb08e5891@huawei.com> <7fe583de-966e-1e86-3233-556886c943d1@kernel.org> From: Jason Yan Message-ID: <88541988-0e57-3789-b560-32f349bf2c0f@huawei.com> Date: Mon, 31 Jul 2023 10:30:58 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <7fe583de-966e-1e86-3233-556886c943d1@kernel.org> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.179.14] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To canpemm100004.china.huawei.com (7.192.105.92) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2023/7/31 10:05, Damien Le Moal wrote: > On 7/31/23 10:44, Jason Yan wrote: >> Hi Wenchao, >> >> On 2023/7/29 18:24, Wenchao Hao wrote: >>> sas_queue_reset is always called with param "wait" set to 0, so >>> remove it from this function's param list. And remove unused >>> function sas_wait_eh. >> >> I did not find any users passing '1' to sas_queue_reset() in the git >> history. It seems it is never used. So It's ok to remove it, I guess. >> >> Just one nit, there should be a blank between "scsi:" and "libsas" in >> the subject: >> >> scsi: libsas: Simplify sas_queue_reset and remove unused code >> >> Otherwise looks good to me: >> Reviewed-by: Jason Yan > > Yeah, code wise, it looks good. > However, I am seeing issues with completions for commands that use command > duration limits. There are some unusual completions that needs special handling > with CDL (e.g. some aborted commands can be notified with a success and > sense-data-available-bit set. For these, we kick libata-EH but it seems that > this is not well working with libsas. So I wonder if this code may need to be > used for CDL... So let's please hold on before applying this. Let me check the > CDL issues I am seeing first. > Sure. It's just a cleanup. Let's hold on until it is confirmed. Thanks, Jason