From: Guenter Roeck <linux@roeck-us.net>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: ChiYuan Huang <u0084500@gmail.com>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
cy_huang <cy_huang@richtek.com>
Subject: Re: [PATCH] usb: typec: tcpm: Fix if vbus before cc, hard_reset_count not reset issue
Date: Mon, 5 Oct 2020 08:30:23 -0700 [thread overview]
Message-ID: <88586992-650f-a4a1-2fa0-8cef313380fb@roeck-us.net> (raw)
In-Reply-To: <20201005110808.GA298743@kroah.com>
On 10/5/20 4:08 AM, Greg KH wrote:
[ ... ]
>>> What ever happened with this patch, is there still disagreement?
>>>
>>
>> Yes, there is. I wouldn't have added the conditional without reason,
>> and I am concerned that removing it entirely will open another problem.
>> Feel free to apply, though - I can't prove that my concern is valid,
>> and after all we'll get reports from the field later if it is.
>
> Ok, can I get an ack so I know who to come back to in the future if
> there are issues? :)
>
Not from me, for the reasons I stated. I would be ok with something like:
- if (tcpm_port_is_disconnected(port))
+ if (tcpm_port_is_disconnected(port) ||
+ (tcpm_cc_is_open(port->cc1) && tcpm_cc_is_open(port->cc2)))
to narrow down the condition.
Guenter
next prev parent reply other threads:[~2020-10-05 15:30 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-02 15:35 cy_huang
2020-09-02 16:57 ` Guenter Roeck
2020-09-03 16:21 ` ChiYuan Huang
2020-09-04 19:41 ` Guenter Roeck
2020-09-05 1:24 ` ChiYuan Huang
2020-09-05 15:51 ` Guenter Roeck
2020-09-06 15:22 ` ChiYuan Huang
2020-09-15 3:07 ` ChiYuan Huang
2020-10-02 13:31 ` Greg KH
2020-10-02 14:26 ` Guenter Roeck
2020-10-05 11:08 ` Greg KH
2020-10-05 15:30 ` Guenter Roeck [this message]
2020-10-06 4:37 ` ChiYuan Huang
2020-10-06 16:52 ` Jun Li
2020-10-06 17:39 ` ChiYuan Huang
2020-10-07 10:13 ` ChiYuan Huang
2020-10-09 6:12 ` Jun Li
2020-10-09 16:06 ` ChiYuan Huang
2020-10-10 11:21 ` Jun Li
2020-10-10 19:31 ` Guenter Roeck
2020-10-12 6:22 ` ChiYuan Huang
2020-10-12 9:25 ` Jun Li
2020-10-12 8:58 ` Jun Li
2020-10-10 15:46 ` Guenter Roeck
2020-10-09 2:58 ` Jun Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=88586992-650f-a4a1-2fa0-8cef313380fb@roeck-us.net \
--to=linux@roeck-us.net \
--cc=cy_huang@richtek.com \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=u0084500@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®