From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 16F2A37883A for ; Mon, 2 Mar 2026 07:31:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772436687; cv=none; b=YGzrsDs9EJiJJDJY0I9j8l7AGZUpKCzVjSrWTXB+DzCAVA+LzXhpRX2ABupM0hJGLn35JkfRLN7ZsSef++O9Po7Z3QtDN0E29sS1vwAlAHO1S7zNSqKqFrliKoNW4odrbLnE24rrNs3P7lDy70WOLrGP8LzT2q9oKe5f9zAhfbg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772436687; c=relaxed/simple; bh=O2VTGVdvg3lhFxxaKosfdcYYaZPGYCa8FpdgjEoOdeo=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=r7aQ8ILSDtL69tLSyVx0IRTOxOesjLkFh9nDe6jlONGv4QX6ic6EhJPP24yPdAU6/yIOsjBKRInkG+Vf+LF3NQMnvKOZpGpKi4eW0CMmlEk63DPvAaatf9fpbq/7jfGDB5sJZRe95PeCYxK2A6njipQ5hqR7KK4jpzriwvX32LE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Vt7nhzNJ; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=CsyLSl2P; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Vt7nhzNJ"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="CsyLSl2P" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 621MUDQb2392738 for ; Mon, 2 Mar 2026 07:31:25 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= A3nSpYdfjHnrXojouJgG/12wwvJoPG3PAC/dtHuCsgo=; b=Vt7nhzNJpJQQKVQ6 ZGum+4xp8jEdoPcpTk7WkMuO40crJ/yFITKmiWOu/8b6BLVLfUJD/TRaxa03q3sF 5+fNS/8e1jOtEkkQlMm5NVFf1w7Uc8K6sev+1rL5GJpMkivHbxLqlYKT8Ls++D0P gSagKPvww+aPkeCk/tkqShD3HUiO4Hy7O+PSeXH4TswHhNS5pX+p5Jj1dgwk9Bu8 xIv64o14cBqsHUAl8R/1mu+7MAXQrc7GD64akcwQWd8LwPhhhuIsSN+ll/j9bVdG e87pbRd4MekDUBQ1Qqbl7yGP3AS1RVseTvMdHbpznorpFx6RI2xT0Rcb59ID6BCh /WZP8A== Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cksgq4k07-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 02 Mar 2026 07:31:25 +0000 (GMT) Received: by mail-pl1-f197.google.com with SMTP id d9443c01a7336-2adef9d486bso38447435ad.2 for ; Sun, 01 Mar 2026 23:31:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1772436685; x=1773041485; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=A3nSpYdfjHnrXojouJgG/12wwvJoPG3PAC/dtHuCsgo=; b=CsyLSl2PoTYCY59QTrfTqxlYLGEBdTzs5zhUqkZUmp5Q0ZoahnbVRNT3u6vNNOaMx3 QVRq2a4eROq7IVqEAuUDT2VBIAfNTytR9pt2w9YYqSrIwH6GJh8LrOcuUW03CTRvdrZN p/BmEqp4rXRZ9gKXL69KztkjmtdJrvtgN171rcL5DUa6G8Ec53hxUQiaFlPQWcka7oIm CbSid1Lm0hTKesAgiCpvNp4dLnSkmtgJSskGDXLqwb4gjpRa7/HTyfmoDFXj2mGfLXSk +xrgdtbewit4D8qHjyx0IObdma9pxY4d4b8QySnUAiUGQANpC431pjUh+MlE13f3Nq2W otDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772436685; x=1773041485; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=A3nSpYdfjHnrXojouJgG/12wwvJoPG3PAC/dtHuCsgo=; b=J2i7zR3SOFd9twVcvlmHud0TeOdZsA0Zl3qaXOYK7tEol7ISDuCYORUhYB13BFiVZL HTP8H9o7rQsNxz9NXjhdfro/Clpg1PtwG131iwCUXEWOl49zU9w/Xm3a5jfacBAIDXuL yO8IBYUohhzqhbA6ZEZXjBVBMLrvorTy74swsCJI/9sB7nF2SnTasxwuBa0OGKH2lXG1 AoMh0+UJxscggkskscwH0q3ogT54cvG13jPKS3QPEwoW2+NXVEeZEcxKc0y+a+qaOBH0 lZx6z/zphY+8PnWISoagwAfwz77BRnrNyTWETRZL59Z5FSpHFtaoyQu8lWRdPaokiAC0 Hxhg== X-Forwarded-Encrypted: i=1; AJvYcCWsl3flLHOHbG/VcNseCbucsKFdWVbMQ+j1KaDXIuNspC1foAT15CN8Smee2L3jNKg8avWwSzFzXogoZhE=@vger.kernel.org X-Gm-Message-State: AOJu0YxTxz3QYGfFxTJ9p1NCgL7qq6r7EybsDKICTYR1iGplYISQ3urI 414NtL8WfE2Gd4zLYYsQaRWBAGpt5Styg/4INODWJXoH+30Yevv7wCQNAAMLWV46cPDarmRTqGv axlsECdustWs8NZq4AlPXEE4WU9SGNhC0T3kt3AZ1a4trSqG81gy16HZaPJA5InTfrFQ= X-Gm-Gg: ATEYQzwzGkJjL7p2pcH7cxii27vEZlS3BVMdDafgEqz+XDEobHUU8VCnz63DNBv3hOQ RfMmOKc7ABf66clSodQg5kb8lsm9FGqVEOwYYsqNsZviOdLIdHJmrsr0EQYqcsmkJU6TcYmQPBF EsQkbdDR55xCtEv3QY96UUS6JRAEJOEnBir7jgDD4Q/EphDYOP1nF9Aroy0JWkfH4xs5BDKDeex 83vs4JFcyGcG5VfeMJEcrBCysCckBGDDSuz/uvMg83oEiFgSfXQiRplnfquQ1GjXHpJT2Gp6IfE zEoDyZG9RGl127XJP0k0zzsL1UQLxiacHe6ljCXYuZnPRCFaXn4HMzkZIK6f0jB+n4f0VaH5AuR tj2rrGeSE+Iv3ftVATS76U0Nt+sEeyD720wXbK9laBFhP3fstGLm42A== X-Received: by 2002:a17:902:f68d:b0:2a7:757b:35a1 with SMTP id d9443c01a7336-2ae2e4b2457mr136702615ad.38.1772436684598; Sun, 01 Mar 2026 23:31:24 -0800 (PST) X-Received: by 2002:a17:902:f68d:b0:2a7:757b:35a1 with SMTP id d9443c01a7336-2ae2e4b2457mr136702165ad.38.1772436683906; Sun, 01 Mar 2026 23:31:23 -0800 (PST) Received: from [192.168.0.172] ([49.205.253.6]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2ae399acba4sm66235775ad.67.2026.03.01.23.31.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 01 Mar 2026 23:31:23 -0800 (PST) Message-ID: <885a74d4-c61e-414e-92a1-863faad931ce@oss.qualcomm.com> Date: Mon, 2 Mar 2026 13:01:18 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] media: venus: allow interlaced video streams To: Dmitry Baryshkov , Piotr Oniszczuk Cc: Dikshita Agarwal , Bryan O'Donoghue , Mauro Carvalho Chehab , Stanimir Varbanov , Mauro Carvalho Chehab , linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260228-venus-mpeg2-v1-1-c13aa7cb6e93@oss.qualcomm.com> <4CA1838F-504D-4EEA-99F4-B3CC5EB10EDA@gmail.com> Content-Language: en-US From: Vikash Garodia In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Proofpoint-GUID: yzC9euaKmKDehzZliVP60W9pJDYabCue X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzAyMDA2NSBTYWx0ZWRfX7Z7Jld+SRBui ot2ZMHwzN1RWL3fmy4gUZQx9VSWMFHJflHMHfUoczHVGRXWGPqrx4KoEnh+/IUsEQB/pJFNZYTa r1rmyy/j1TMrfqycuSrJ1cURVFkvY8vAgbqjkY4VJCsp0vDmVUYktIv9h2z1GVarL+3MeE/qTRb +21aVFLFQCXR5wVbZOaSn8XDCP6J12EmFJg7UjUL0hAGoEU+T+ybKJF4fBYtwZmZgZm/nq2rdSm ViykPAngbzr3eNY1Axjku013Uy6iardH6rkim+aYnHJRFCQo4ea/p1ENPnU28FrTiI+9T/eyQUL lXfz+tXKwI3dh9ROqNHx541q+1VXRU71+aw77DNHPqeztOkLG5WBYHllqvlMG4UuTs7BjBXfJUr 7Fw2QV0zffv7h0wC8yJV9aHAjuY8vsTkrtAP7k5fXQBtR2t0nMfEZ9Y5La+8VjOKR3n8YSJVcis Ukh3pS1FbEPwyBAbqgA== X-Authority-Analysis: v=2.4 cv=bdRmkePB c=1 sm=1 tr=0 ts=69a53ccd cx=c_pps a=cmESyDAEBpBGqyK7t0alAg==:117 a=WNU4mP0iZEZjDg176sUGxg==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=NEAV23lmAAAA:8 a=EUspDBNiAAAA:8 a=pgx13x3EImjs4AM0mqgA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=1OuFwYUASf3TG4hYMiVC:22 X-Proofpoint-ORIG-GUID: yzC9euaKmKDehzZliVP60W9pJDYabCue X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-02_02,2026-02-27_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 bulkscore=0 priorityscore=1501 clxscore=1015 malwarescore=0 impostorscore=0 suspectscore=0 adultscore=0 spamscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603020065 On 3/1/2026 4:05 AM, Dmitry Baryshkov wrote: > On Sat, Feb 28, 2026 at 09:54:20PM +0100, Piotr Oniszczuk wrote: >> >> >>> Wiadomość napisana przez Dmitry Baryshkov w dniu 28 lut 2026, o godz. 10:49: >>> >>> Venus driver errors out on the interlaced streams with the 'field isn't >>> supported' error message, which e.g. prevents decoding of the MPEG2 >>> video streams. Don't error out if the buffer is set to contain >>> interlaced data. >>> >>> Tested with the fluster enabled to handle MPEG2 through Gstreamer: >>> >>> ./fluster.py r -d GStreamer-MPEG2_VIDEO-V4L2-Gst1.0 -s -so venus-mpeg2.md -j 1 >>> >>> GLOBAL SUMMARY >>> |TOTALS|GStreamer-MPEG2_VIDEO-V4L2-Gst1.0| >>> |-|-| >>> |TOTAL|30/52| >>> |TOTAL TIME|75.526s| >>> |-|-| >>> |Profile|GStreamer-MPEG2_VIDEO-V4L2-Gst1.0| >>> |MAIN|26/32| >>> |PROFILE_4_2_2|0/9| >>> |SIMPLE|4/11| >>> |-|-| >>> >>> Fixes: 059790467bf4 ("media: venus: helpers: handle correctly vbuf field") >>> Signed-off-by: Dmitry Baryshkov >>> --- >>> drivers/media/platform/qcom/venus/helpers.c | 5 ----- >>> 1 file changed, 5 deletions(-) >>> >>> diff --git a/drivers/media/platform/qcom/venus/helpers.c b/drivers/media/platform/qcom/venus/helpers.c >>> index 747c388fe25f..71e79093a4c7 100644 >>> --- a/drivers/media/platform/qcom/venus/helpers.c >>> +++ b/drivers/media/platform/qcom/venus/helpers.c >>> @@ -1466,11 +1466,6 @@ int venus_helper_vb2_buf_prepare(struct vb2_buffer *vb) >>> if (V4L2_TYPE_IS_OUTPUT(vb->vb2_queue->type)) { >>> if (vbuf->field == V4L2_FIELD_ANY) >>> vbuf->field = V4L2_FIELD_NONE; >>> - if (vbuf->field != V4L2_FIELD_NONE) { >>> - dev_err(inst->core->dev, "%s field isn't supported\n", >>> - __func__); >>> - return -EINVAL; >>> - } >>> } >>> >>> if (vb->type == V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE && >>> >>> --- >>> base-commit: 779cae956c8316aebc1946ef86ca001f99658270 >>> change-id: 20260228-venus-mpeg2-495f9187a1ec >>> >>> Best regards, >>> -- >>> With best wishes >>> Dmitry >>> >>> >> >> >> Dmitry, >> I applied this on 6.19.4 mainline and give run with interlaced content (hd tv) on qcs6490 (radxa dragon sbc). >> Playback fails like this: https://gist.github.com/warpme/a368983678af0a76af85314808773076 >> pls see a bootom kernel output showing venus failure. >> my sw stack plays ok on e.g rpi4 stateful v4l2m2m so i think root cause isn't in my userspace.... >> pls let me know if anything extra is required to fix venus decoder issue. >> br > > > Interesting. So, most likely, H.264 decoder can't cope with it and we > need to allow non-NONE fields only for MPEG2. Let's see if Vikash will > have any other ideas. > Venus should already support h264 interlace. Piotr, do you see the same failure without this patch ? Regards, Vikash