From: Kumar Gala <galak@codeaurora.org>
To: Tomasz Figa <tomasz.figa@gmail.com>
Cc: "Sören Brinkmann" <soren.brinkmann@xilinx.com>,
"Rob Herring" <rob.herring@calxeda.com>,
"Pawel Moll" <pawel.moll@arm.com>,
"Mark Rutland" <mark.rutland@arm.com>,
"Stephen Warren" <swarren@wwwdotorg.org>,
"Ian Campbell" <ijc+devicetree@hellion.org.uk>,
"Rob Landley" <rob@landley.net>,
"Russell King" <linux@arm.linux.org.uk>,
"Mike Turquette" <mturquette@linaro.org>,
"Michal Simek" <michal.simek@xilinx.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH v2 1/2] clk/zynq/clkc: Add 'fclk-enable' feature
Date: Tue, 29 Oct 2013 03:26:20 -0500 [thread overview]
Message-ID: <8864256B-F8F9-4474-9B5F-416C3BB96523@codeaurora.org> (raw)
In-Reply-To: <2028580.HhySWWnU2A@flatron>
On Oct 28, 2013, at 5:17 PM, Tomasz Figa wrote:
>>>> diff --git a/Documentation/devicetree/bindings/clock/zynq-7000.txt
>>>> b/Documentation/devicetree/bindings/clock/zynq-7000.txt index
>>>> d99af878f5d7..11fdd146ec83 100644
>>>> --- a/Documentation/devicetree/bindings/clock/zynq-7000.txt
>>>> +++ b/Documentation/devicetree/bindings/clock/zynq-7000.txt
>>>>
>>>> @@ -22,6 +22,10 @@ Required properties:
>>>> Optional properties:
>>>> - clocks : as described in the clock bindings
>>>> - clock-names : as described in the clock bindings
>>>>
>>>> + - fclk-enable : Bit mask to enable FCLKs in cases no proper CCF
>>>
>>> Since it's a vendor specific property, it should include vendor
>>> prefix.
>>
>> The whole driver is vendor specific. Should there really be another
>> prefix for that property?
>
> Yes. If a property is introduced just for use by this particular driver
> then it must be prepended by a vendor prefix. That's a general rule.
Most all nodes are vendor specific by definition ;).
- k
--
Employee of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
next prev parent reply other threads:[~2013-10-29 8:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-10 17:10 Soren Brinkmann
2013-10-10 17:10 ` [PATCH v2 2/2] arm: dt: zynq: Add fclk-enable property to clkc node Soren Brinkmann
2013-10-14 9:04 ` [PATCH v2 1/2] clk/zynq/clkc: Add 'fclk-enable' feature Michal Simek
2013-10-28 20:59 ` Sören Brinkmann
2013-10-28 21:13 ` Tomasz Figa
2013-10-28 21:43 ` Sören Brinkmann
2013-10-28 22:17 ` Tomasz Figa
2013-10-29 8:26 ` Kumar Gala [this message]
2013-10-29 13:04 ` Michal Simek
2013-10-30 18:44 ` Sören Brinkmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8864256B-F8F9-4474-9B5F-416C3BB96523@codeaurora.org \
--to=galak@codeaurora.org \
--cc=devicetree@vger.kernel.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mark.rutland@arm.com \
--cc=michal.simek@xilinx.com \
--cc=mturquette@linaro.org \
--cc=pawel.moll@arm.com \
--cc=rob.herring@calxeda.com \
--cc=rob@landley.net \
--cc=soren.brinkmann@xilinx.com \
--cc=swarren@wwwdotorg.org \
--cc=tomasz.figa@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®