From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=130.133.4.66 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794986415; b=NcEc/1yOuU0UlFh/uVD+CDkEK6VRVCci95bYM76wdNCdbCblpE+ok9Gqim/ahrjEVWWb 8je+/VZHSygLKlMQppNdXXNM3F9SwBnMXLPhSWE25ZpJptbjrDT/zGRhXwzKrkEXTXakj 5mHzZ4+R0T5moDJAwXDLl+WV7Z0we68D4rsK6hRJQYSjKyyItJUGFSDT96IpLN6QASycc F0vbrBahxr9SGRlU5Q+HuHxTsWhLZ5+DMeX45ULaPhQCoC5XqCsMAIrkUMVAn2Q0+WDGd MbJDfoaGp9mKqAuugEBoXrxzDTQxLa2kggN9GVE3vNi8sB0h+aYdfkevM+7hNXz4LjA== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794986415; h=DMARC-Filter:DKIM-Signature:Received:Received:Message-ID:Subject: From:To:Cc:Date:In-Reply-To:References:Content-Type: Content-Transfer-Encoding:User-Agent:MIME-Version:X-Original-Sender: X-Originating-IP:X-ZEDAT-Hint; bh=BP5uJPFEij5TgQlQa0MnVpdjGYnsN3jkV0Ck605J8vA=; b=gtoD6P/x0a/oyyEZhY90THNb6hLED+V8WGAiCVXQPDycbaCjJUbQBcxFSXOAbBy4VDpk 8cVE5UEDF1OFQjmTDjsl4S5CoQFpW6O634xovab9zSYNch3KIY8SWlKU/OM/22ejBz/88 qRL7pD8luB1Oje0Sasew3K5ZA7gnmQ8ls0mpMJZAiafFzjnw746Ms3hdrUHfXFBSuySHr E+zNTQH4xdWOxNm+0w6lRItr9Akqsdzx2MPevKLKkxnxXulWbBkxADTPrU6LVFxJyzmMS vq3zh+2yPfdX3Z3H77OFWTnc/UPlMhboW7itsiLKJI3saRXUOiyeJ6Hwx8euhbOM4jA== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=physik.fu-berlin.de; spf=pass smtp.mailfrom=zedat.fu-berlin.de; dkim=pass header.d=fu-berlin.de header.i=@fu-berlin.de header.a=rsa-sha256 header.s=fub01 header.b=NVIV5AZx; arc=none smtp.remote-ip=130.133.4.66 Received: from outpost1.zedat.fu-berlin.de (outpost1.zedat.fu-berlin.de [130.133.4.66]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 347BF606A31C; Wed, 18 Nov 2026 07:20:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 347BF606A31C Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=physik.fu-berlin.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=zedat.fu-berlin.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=fu-berlin.de header.i=@fu-berlin.de header.a=rsa-sha256 header.s=fub01 header.b=NVIV5AZx DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=fu-berlin.de; s=fub01; h=MIME-Version:Content-Transfer-Encoding: Content-Type:References:In-Reply-To:Date:Cc:To:From:Subject:Message-ID:From: Reply-To:Subject:Date:Message-ID:To:Cc:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:In-Reply-To: References; bh=BP5uJPFEij5TgQlQa0MnVpdjGYnsN3jkV0Ck605J8vA=; t=1794986415; x=1795591215; b=NVIV5AZxUiLiZeysWsuiw4TVDW8kKs6h5+50BSjLWqaE6wJWn+nWIm5HCfv3Q FSCMgg0V623TN0IzaiSFtarP0Wg0bjgMEIhw5s+h0PExnQBReb8stY1uNrqXwBaIQooUaCFyE18TH 0N6DK15zqyqGuv3ApY3IX2xhao4XQBUMjuZZ3tX1OiSqgfGx5y3KNQUFGOtcmjFgGUxCV3ky6KVf3 sJQVqSuld5Tmhwi1i/NV6u8aZZdlkOVDYD1HIs4fGBVqQQzd9+CsRCpar8fLV0xTyw9AGa405uTzm ecmAqL5QrPiXcAcv/OCITy0eppkMKKkHVy3ybnSJLt8ZbShbDg==; Received: from inpost2.zedat.fu-berlin.de ([130.133.4.69]) by outpost.zedat.fu-berlin.de (Exim 4.100) with esmtps (TLS1.3) tls TLS_AES_256_GCM_SHA384 (envelope-from ) id 1xTZxc-00000000Itt-3izf; Wed, 18 Nov 2026 08:20:04 +0100 Received: from p57bd95b5.dip0.t-ipconnect.de ([87.189.149.181] helo=[192.168.178.61]) by inpost2.zedat.fu-berlin.de (Exim 4.100) with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (envelope-from ) id 1xTZxc-00000000GfQ-25vy; Wed, 18 Nov 2026 08:20:04 +0100 Message-ID: <88645597bb3aeae8d36a7b5c499a0a6d74b4acc4.camel@physik.fu-berlin.de> Subject: Re: [PATCH v3 3/9] sh: sq: Add missing kobject release callback to ktype_percpu_entry From: John Paul Adrian Glaubitz To: Ian Rogers , Danilo Krummrich , Greg Kroah-Hartman , Kees Cook , Miguel Ojeda , "Rafael J . Wysocki" Cc: Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Nayna Jain , Srish Srinivasan , Mimi Zohar , Yoshinori Sato , Rich Felker , Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , Nathan Chancellor , Nick Desaulniers , Viresh Kumar , Zhongqiu Han , Alexander Aring , Felix Kuehling , Christian =?ISO-8859-1?Q?K=F6nig?= , Zhihao Cheng , Sumanth Korikkar , Bill Wendling , Justin Stitt , driver-core@lists.linux.dev, llvm@lists.linux.dev, linux-hardening@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-doc@vger.kernel.org, linux-acpi@vger.kernel.org, linux-pm@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-sh@vger.kernel.org, linux-s390@vger.kernel.org, gfs2@lists.linux.dev, xen-devel@lists.xenproject.org, linux-mtd@lists.infradead.org, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Date: Wed, 18 Nov 2026 08:20:02 +0100 In-Reply-To: <20261108223913.3624571-4-irogers@google.com> References: <20261108223913.3624571-1-irogers@google.com> <20261108223913.3624571-4-irogers@google.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.62.1 X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 X-Original-Sender: glaubitz@physik.fu-berlin.de X-ZEDAT-Hint: PO Hi Ian, On Sun, 2026-11-08 at 14:39 -0800, Ian Rogers wrote: > In sq_dev_add(), sq_kobject[cpu] is dynamically allocated with > kzalloc_obj() and initialized with ktype_percpu_entry. When > sq_dev_remove() calls kobject_put(kobj), the kobject is never freed > because ktype_percpu_entry lacks a .release callback. >=20 > Provide a sq_kobj_release() callback that calls kfree(kobj). >=20 > Fixes: d7c30c682a27 ("sh: Store Queue API rework.") > Signed-off-by: Ian Rogers > --- > arch/sh/kernel/cpu/sh4/sq.c | 6 ++++++ > 1 file changed, 6 insertions(+) >=20 > diff --git a/arch/sh/kernel/cpu/sh4/sq.c b/arch/sh/kernel/cpu/sh4/sq.c > index 908a8e09113b..f33864958487 100644 > --- a/arch/sh/kernel/cpu/sh4/sq.c > +++ b/arch/sh/kernel/cpu/sh4/sq.c > @@ -331,7 +331,13 @@ static const struct sysfs_ops sq_sysfs_ops =3D { > =09.store=09=3D sq_sysfs_store, > }; > =20 > +static void sq_kobj_release(struct kobject *kobj) > +{ > +=09kfree(kobj); > +} > + > static struct kobj_type ktype_percpu_entry =3D { > +=09.release=09=3D sq_kobj_release, > =09.sysfs_ops=09=3D &sq_sysfs_ops, > =09.default_groups=09=3D sq_sysfs_groups, > }; Looks good to me, thanks! Acked-by: John Paul Adrian Glaubitz Adrian --=20 .''`. John Paul Adrian Glaubitz : :' : Debian Developer `. `' Physicist `- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913