From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752223AbcFUO1r (ORCPT ); Tue, 21 Jun 2016 10:27:47 -0400 Received: from mail-bn1on0090.outbound.protection.outlook.com ([157.56.110.90]:3200 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751623AbcFUO1o (ORCPT ); Tue, 21 Jun 2016 10:27:44 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Suravee.Suthikulpanit@amd.com; Subject: Re: [PART2 RFC v2 00/10] iommu/AMD: Introduce IOMMU AVIC support To: Joerg Roedel References: <1465855611-10092-1-git-send-email-suravee.suthikulpanit@amd.com> <20160621135043.GJ28248@8bytes.org> CC: , , , , , From: Suravee Suthikulanit Message-ID: <88650292-bb48-a54c-296e-8680bc839e39@amd.com> Date: Tue, 21 Jun 2016 09:27:27 -0500 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.1.0 MIME-Version: 1.0 In-Reply-To: <20160621135043.GJ28248@8bytes.org> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [165.204.77.1] X-ClientProxiedBy: CY1PR14CA0037.namprd14.prod.outlook.com (10.163.13.175) To BLUPR12MB0434.namprd12.prod.outlook.com (10.162.92.14) X-MS-Office365-Filtering-Correlation-Id: bde45c7e-ea19-4839-9a35-08d399e02e5f X-Microsoft-Exchange-Diagnostics: 1;BLUPR12MB0434;2:DYU6Apik43sqCyfVRY8Zyo9LgrIOOamhIucwwfcNjZW4Rc/g2RdV3E8QsWQ122RS+0ehw6nyTYRBb1DfHZEwV1bwe7xYlX9ttRe1BZZduXDm++u0EV1e2LtQ+OBfnwlHyeQFpbmGqa3gCPfSAVWuuFe3j+gLmFbapoJqXhPi08wsKimFnmVk+iLBQXoApij/;3:gFzSaBZc8gaKWsMlh66wcm5m6uHTnR0h/R7FmLZdNc0vwVWq8gJPs+6QuYPGgq1RX5CIZuO2hWijhiexWc19rTh21by+G8z3empuds2SK2vRxewLMTRunlHIndc9+D9s X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BLUPR12MB0434; X-Microsoft-Exchange-Diagnostics: 1;BLUPR12MB0434;25:SQPXcy13r/xKdJP2YHhAKnUgetM2YYMHQ1JFl/GdmZ9IXrqc9lPLgYhqg8Mqdx9KzaJuXoPaiIKCS03RgnpKJFx7LWw+R0opTiPaaHQlhOe0zfUIknJFBn50j7wcdRK08fA2xopv9HidDAUaAdeo+EIjvmZMyS9cuJiZtDkcoL2ayBamORBSKYOXaxoM+xZstWgtu0VNlMU5QpHI1Hnf/vznyqmu/G51HhdUJlf4wKrREYKqxC8LPWt/B92mVNIaPwhfWpmPPlSwcxUOwiBalJuYNGO0VITQCTxu+W9xDkTcfRcHYjZ2pV0xEEXt4JyGYNs4Zqjoq66KfnIHPeGRp2R8pgiYa1Ae1OwGECMugFtcKNDIi69RnUpOlCeYt/SKGKo+cXXIRp3MkgJ63YGgHNS3lVh+O2yxJSZ9dvln230/6rJWgWuQ9DcaKQOOf8dK9ap5GpZO42mSd81okAeYlSxDUwmAik2AyRe19daOwNF0JoX89pBXSSt+1XEW4TDCDLbA1ziWK3meu/C8pOZ20P3zHJtskCuBtc9UCdIsqhFq58fbSXVtdnEHfZa6/5qgyIBaD6Cwc5CxpE6xbDGlGA2xMhrui4K3Od8rA+I4fvF5q0JhKzItr5dFSzkvrG6ktH939wpbi0FrmBbOhUSrxNJIfxMEBRh4jZUhg+kb+tDTdYAWo9DLvegNoFt8Om2ZyatGq6x/ic4uZB6xugWDaQ== X-Microsoft-Exchange-Diagnostics: 1;BLUPR12MB0434;20:+gtecZM2ZCuBWZtGLJPJ+yjkIPcNk4lUFkzeibxFkJ1ZKqqSUyRdb411QbACVDJdD+68JXmPrwTtQWLMQfWx9gkeF/JEHsbyAZAb/IfyBtTjsdgfuKepE/Z4CRNq57YI0Y9o6C6LAI4Ez4now9Vm5BPer+0Q7ZAISSrT38tdXUuJ9pYHXmoORYNzu8Tr8d9jqvy9wYZgxyWNhcsuufFojGS7Q053TArzviFf2tlMxfm+t5wQtg5D7lRUIb/xXiwjHuDxF0lTqPFhL+IKPeeG0oZndaiw5ZeNIoCzKMGovNZUSpoN4kX5LV7mnLsA1EjsddoXXsRVq9oDv+z3suRjXV8sXX1++EtcQ1JsWBUj9nUROpj+0Fs1wKkODkRtj8TRZA4vxewnQMooQKPAJuQzEmYeXq/vp25fakVzbZfQ+vY9LIJzZQDbwGxa0r5zD2OFH8kwhxnfEmETPdwCuP/+DMDv2WX0idn/fp+WaBT/NLZeiIt8rSRxT05tEGOntcGO;4:teqRW5EQBTcD8mUPws4cXtCytjo2jAY0SlD1W3XWvU0ORrEZQK/q24XziYlqnt1IoV65r4jkCjif4kfXm2lXdGAZnNrcbestvIBGnCR7OmNHGtPzMkWlzXxIaFaRVwA2y1Gc4nn5leLnlFqS2uw8O/sPuFjBsQMOUqrDnbYMvx251XlEXfyDaDyw4aKoWiZBh8zRR0ikiQ/W6JesVREJhcdNPFRJ+vnNh3K1Ef+4xw3IiBgL6sHexwTBt5jSYf+DM5aVaYa5l6K4U3YUJY7jXB60CFVIu6B6hmTB+/MiNqWdIysDW/BfEG0n0pQHbEtFEGdynB1/mPh/90Hm0p99gALDk9AFFuaJKFmu/gVrOnnOgd4UfSaSG/nlgOqMucFF1h+i30Xf82bT8RhA6hI2mA== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046)(6055026);SRVR:BLUPR12MB0434;BCL:0;PCL:0;RULEID:;SRVR:BLUPR12MB0434; X-Forefront-PRVS: 098076C36C X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(6049001)(7916002)(189002)(199003)(24454002)(377454003)(47776003)(83506001)(64126003)(65806001)(68736007)(105586002)(106356001)(77096005)(3846002)(92566002)(76176999)(50986999)(66066001)(65956001)(36756003)(23746002)(50466002)(7736002)(7846002)(2906002)(54356999)(31696002)(4326007)(230700001)(86362001)(8676002)(42186005)(81166006)(81156014)(586003)(189998001)(2950100001)(6116002)(33646002)(101416001)(558084003)(110136002)(4001350100001)(31686004)(97736004)(65826006)(217873001);DIR:OUT;SFP:1101;SCL:1;SRVR:BLUPR12MB0434;H:[10.236.18.83];FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;BLUPR12MB0434;23:9mnZ3YZl1ybSwbkXipOb4bRGOsem6uhVWC5p9?= =?Windows-1252?Q?jiyoHoD8CovV8fL65uJ5IRuGreIMYdVgXoQY1kaGcDG1R1nDVYncK0jE?= =?Windows-1252?Q?Q3l4UYu7ONvDXb+AN7qIvp+LLdyhpd8AoIBw6J6J20HREr30scHzHIQp?= =?Windows-1252?Q?D/LZ+eIdBu4BKNeIz+Vjj5AwxK+ad/JGhFTHni7oDhGFGOC+jMeebP/E?= =?Windows-1252?Q?5EBSCcjiNwGhYmlqZ3qhmFYJArCtyq8Pu/5G7Kha1BKoS+SLx/pa2qSg?= =?Windows-1252?Q?hP7SMvfn+I0fqulPaxh/Ed+use4fRpuIMP+uCg99Ugxb/O8BGV3PG7nx?= =?Windows-1252?Q?8pfm+AZ6JxW4mqmVRZjCgAS2nKescCVRdNSFkVnx44dZP2ff9hsRml8+?= =?Windows-1252?Q?QGJVyRz/bqiueScATqA6BTGPjpT2cW/uEQbVpLqkXVg4fnsHXJo9AsAA?= =?Windows-1252?Q?S+quQ5E68/Nr0oSz7ruvqXaYvSlMuxoBIdh0N3fin9fMOd1JDlyc4yrP?= =?Windows-1252?Q?uNvKCMJtoack6GlBHFRTha9DLMa31Jh37qKAFFs8b6hVEs4818HegtSF?= =?Windows-1252?Q?Y9ZYi9oQnHaKVFX6mVl4Ikd9fsqnu49/DbFxb9LPCRUFRD+E3l808uvI?= =?Windows-1252?Q?XxbiOWWNSOKVYTDue7RNBtUGiqbOqCnScehvrc3UuWfgs6OFN2NndCha?= =?Windows-1252?Q?kewzG/5O7G+yghbxXiQ8JheKstRG34hAJeZN4OziDlqvMDOQzvJBwvkR?= =?Windows-1252?Q?jhjK4H6HIvXK7G8i5CYWMn4EC8Mu4S0CUdYYZlgpcDbDTXeEiwSGMWsJ?= =?Windows-1252?Q?zxv3tPQDvzWfepp3q37q5Xn/I9FbU7TdqeFqF9r+g7W8u594HyD5qYh8?= =?Windows-1252?Q?PMOaK+IDqgm51QdojcEkSGc2/wGlM9PP7bjy7IGeQXiLgKmsDXTszWLS?= =?Windows-1252?Q?C4/V+9dIzYZx7FjL9wLx/hJOiLXQzBMmqJlKC5PnB3Ig2BZOufs7EkLT?= =?Windows-1252?Q?rwqsO8YgpB3ZjkgTR4hNJb3QVyRNmroN3t1LW4mrcCOoK7DRclssOMLz?= =?Windows-1252?Q?xoHDoi6ZTFbL+u9SpceV9tVu+12aKtv64iDXUPSLc7Z3ut1gyNRpqEuZ?= =?Windows-1252?Q?bTmr+i9s4ocIqdh7XPjxF7xDDlfuL4nyfyIYMeXySYpXowGJ2mueA4Dl?= =?Windows-1252?Q?LUt0vsATiW+XRG94KyywHlwDLPPKTHJDmQKVxcWxgf5Djyo4lf4y564Q?= =?Windows-1252?Q?Rtsom8Q1dVXRc5j0Mr2KGY8kG9tHyC1f1tOYZq4lksN6JmJ3C2LSRZJV?= =?Windows-1252?Q?8SqasbndThvCtSW5JN3FudoXQ=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;BLUPR12MB0434;6:cUw1TopBaVSikLu+eDEeES7P98A5bheSBOED8zzTat3iVhifrT6+kAR6y5eZkMfZlfhtSQhNvolI3WIh2/scwYRpKDdcwYWYrTt5EDW7w9FDe3LQex81Wraeq2o/MmgafgjxMZlF1Mig03VYICnugtaHYamNpbGSOpiz65LnIrpVW12/FCMCVxKDJhhDcN0HXsABPn0yZYGKbkTey4v2+ynyhGxehjGNMCTtC0YjjwAYfK5Vo3P695r9yUiDwm9cKhfg/YX79zYUnF57NPcO/pXdQ8cSxK0pLvw/HzCiwFWj96Z+kcR5DIBTrOW1bRCp3gOpMqnTYzRBhovy6xlGhw==;5:ydKRQceNhx4dgm+agOuXqxKfaMlUJTYBnDo2feW9tNzjB+czQyv0fTyUbeeMwfCBlNuzghczk3p8VNCYwbQsUi3NWI0n6Y8sPJ7svkb1IJESEApUJrqC+chHTTT03RwPsYjo5vAAXN7mwhqe61lG5w==;24:4RkM28jdAt44PrngXseW36yNh3KuZ5wDkik1ZQf+wwYCeSTCTKqbyJ6hMScyxnjXfLI0b13Wta3unZnRJ2saVXdjCU8MNGMbD7IIQuvW4XM=;7:jxtWHPWr0BxjmiVa8u9+/JMBlYyBsXzJnykGUZm7/vgEUjKKsswpIgN4aI/2UQ+buyPpIj15m+HN5g28B1JhKGFN5RTdl0EXXEAyO461DYAMc+6G+FVReoGdVKN0RTUNB+1RbazTLA++T3K50ptWyXhI6dqjPTHBdzgIXKSj9HZGKr/RmZgbdFwjdhVosePXsce796tTFbnmo8xWqGO/JNCo8DgT3od0Zl0Y4EWYeOLm2gLmqw04ecaNoakc4XjK SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;BLUPR12MB0434;20:x2O3ZQTPkjItIR6qFnRZtcmUISCekY3cxlAMmvMwiq5bSipxxa3GQJqiqkWC9edNm8SlEjaUX0x09xAbktF7vLL4QE2ZCu3F3WGlAI3vDSVoHvi/gICYzS9h4Ax0SzU0o5spCGUSUxTd3RiQx9wjgDDKhizHUFCkIDlGoVw5KLa39KBiTMgDeE5Sl3fABgaCjGhkuaIGEXLyVxgYNkGAPhf4Y+vubMSrThKC2r/VwhLwGaLRpeoJvEvolgRAGJos X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jun 2016 14:27:31.1407 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR12MB0434 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/21/2016 8:50 AM, Joerg Roedel wrote: > The code has a few style issues (thing I'd implemented differently), but > it looks functional. Anything in particular that you think I should improve or/and change? Thanks, Suravee