From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09379C4167B for ; Thu, 8 Dec 2022 23:13:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230010AbiLHXNt (ORCPT ); Thu, 8 Dec 2022 18:13:49 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54308 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229723AbiLHXNq (ORCPT ); Thu, 8 Dec 2022 18:13:46 -0500 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A711172842; Thu, 8 Dec 2022 15:13:45 -0800 (PST) Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 2B8NArix022366; Thu, 8 Dec 2022 23:13:39 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=qcppdkim1; bh=LcAbIsReO04j0QxQyQlQS7QFZ3Lfksurb+fqS6e5oBU=; b=deJ5wb905J3vVZFvJL8HqgAKD4lf17E3AFnx2R/prB5EugMdHuqU+jYfkRl4VpbwKYLC b3N+X5r+T11Qak6iCE5F348RLFWYnqAVFPqeupAp8SzVzuP9HdXEWA25BZ2za/N1VTO8 CIZTsNjCvV3JppEanHA+xMd2JqEl1tyBqQklheeGwpv4fPz36xnlSMbN2QiKaC4BHjGg Fp+DI7IIIddFSoY2JNlVLKnVdIkerNLHuS6mqXcehNvPsjbF9lg3cv6QsUJ6AQj3IAlU ciYw5WJilj8sPtv2Pu2QCQ73WL+zo01r3b8U94ue6RuSYA6UMcnVVSscP9hUvPSnxiSy Ug== Received: from nalasppmta02.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3mbr2v84dq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 08 Dec 2022 23:13:39 +0000 Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA02.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 2B8NDcPe021103 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 8 Dec 2022 23:13:38 GMT Received: from [10.110.56.119] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.36; Thu, 8 Dec 2022 15:13:36 -0800 Message-ID: <8867c2d5-71d7-60a0-f481-e50f35db264e@quicinc.com> Date: Thu, 8 Dec 2022 15:13:36 -0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [PATCH v5 06/12] drm/msm/dp: Add DP and EDP compatibles for SC8280XP Content-Language: en-US To: Bjorn Andersson , Dmitry Baryshkov CC: Rob Clark , Abhinav Kumar , Sean Paul , David Airlie , Daniel Vetter , Rob Herring , Krzysztof Kozlowski , Bjorn Andersson , Konrad Dybcio , Kalyan Thota , Jessica Zhang , "Johan Hovold" , Sankeerth Billakanti , , , , , References: <20221207220012.16529-1-quic_bjorande@quicinc.com> <20221207220012.16529-7-quic_bjorande@quicinc.com> From: Kuogee Hsieh In-Reply-To: <20221207220012.16529-7-quic_bjorande@quicinc.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: A77enz3U5G4IZdcNHI1DcYJwM_V1HAPb X-Proofpoint-GUID: A77enz3U5G4IZdcNHI1DcYJwM_V1HAPb X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.923,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2022-12-08_12,2022-12-08_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 suspectscore=0 adultscore=0 mlxlogscore=999 phishscore=0 malwarescore=0 clxscore=1015 mlxscore=0 spamscore=0 impostorscore=0 priorityscore=1501 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2210170000 definitions=main-2212080191 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/7/2022 2:00 PM, Bjorn Andersson wrote: > From: Bjorn Andersson > > The SC8280XP platform has four DisplayPort controllers, per MDSS > instance, all with widebus support. > > The first two are defined to be DisplayPort only, while the latter pair > (of each instance) can be either DisplayPort or Embedded DisplayPort. > The two sets are tied to the possible compatibels. > > Signed-off-by: Bjorn Andersson > Reviewed-by: Dmitry Baryshkov > Signed-off-by: Bjorn Andersson Reviewed-by: Kuogee Hsieh > --- > > Changes since v4: > - None > > drivers/gpu/drm/msm/dp/dp_display.c | 22 ++++++++++++++++++++++ > 1 file changed, 22 insertions(+) > > diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/dp_display.c > index eeb292f1ad1b..5b7f1f885b2f 100644 > --- a/drivers/gpu/drm/msm/dp/dp_display.c > +++ b/drivers/gpu/drm/msm/dp/dp_display.c > @@ -145,6 +145,26 @@ static const struct msm_dp_desc sc8180x_dp_descs[] = { > {} > }; > > +static const struct msm_dp_desc sc8280xp_dp_descs[] = { > + { .io_start = 0x0ae90000, .id = MSM_DP_CONTROLLER_0, .connector_type = DRM_MODE_CONNECTOR_DisplayPort, .wide_bus_en = true }, > + { .io_start = 0x0ae98000, .id = MSM_DP_CONTROLLER_1, .connector_type = DRM_MODE_CONNECTOR_DisplayPort, .wide_bus_en = true }, > + { .io_start = 0x0ae9a000, .id = MSM_DP_CONTROLLER_2, .connector_type = DRM_MODE_CONNECTOR_DisplayPort, .wide_bus_en = true }, > + { .io_start = 0x0aea0000, .id = MSM_DP_CONTROLLER_3, .connector_type = DRM_MODE_CONNECTOR_DisplayPort, .wide_bus_en = true }, > + { .io_start = 0x22090000, .id = MSM_DP_CONTROLLER_0, .connector_type = DRM_MODE_CONNECTOR_DisplayPort, .wide_bus_en = true }, > + { .io_start = 0x22098000, .id = MSM_DP_CONTROLLER_1, .connector_type = DRM_MODE_CONNECTOR_DisplayPort, .wide_bus_en = true }, > + { .io_start = 0x2209a000, .id = MSM_DP_CONTROLLER_2, .connector_type = DRM_MODE_CONNECTOR_DisplayPort, .wide_bus_en = true }, > + { .io_start = 0x220a0000, .id = MSM_DP_CONTROLLER_3, .connector_type = DRM_MODE_CONNECTOR_DisplayPort, .wide_bus_en = true }, > + {} > +}; > + > +static const struct msm_dp_desc sc8280xp_edp_descs[] = { > + { .io_start = 0x0ae9a000, .id = MSM_DP_CONTROLLER_2, .connector_type = DRM_MODE_CONNECTOR_eDP, .wide_bus_en = true }, > + { .io_start = 0x0aea0000, .id = MSM_DP_CONTROLLER_3, .connector_type = DRM_MODE_CONNECTOR_eDP, .wide_bus_en = true }, > + { .io_start = 0x2209a000, .id = MSM_DP_CONTROLLER_2, .connector_type = DRM_MODE_CONNECTOR_eDP, .wide_bus_en = true }, > + { .io_start = 0x220a0000, .id = MSM_DP_CONTROLLER_3, .connector_type = DRM_MODE_CONNECTOR_eDP, .wide_bus_en = true }, > + {} > +}; > + > static const struct msm_dp_desc sm8350_dp_descs[] = { > { .io_start = 0x0ae90000, .id = MSM_DP_CONTROLLER_0, .connector_type = DRM_MODE_CONNECTOR_DisplayPort }, > {} > @@ -156,6 +176,8 @@ static const struct of_device_id dp_dt_match[] = { > { .compatible = "qcom,sc7280-edp", .data = &sc7280_dp_descs }, > { .compatible = "qcom,sc8180x-dp", .data = &sc8180x_dp_descs }, > { .compatible = "qcom,sc8180x-edp", .data = &sc8180x_dp_descs }, > + { .compatible = "qcom,sc8280xp-dp", .data = &sc8280xp_dp_descs }, > + { .compatible = "qcom,sc8280xp-edp", .data = &sc8280xp_edp_descs }, > { .compatible = "qcom,sm8350-dp", .data = &sm8350_dp_descs }, > {} > };