From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F8A4C5B57D for ; Fri, 5 Jul 2019 04:09:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 08B9121852 for ; Fri, 5 Jul 2019 04:09:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="b1jq75dx" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725823AbfGEEJV (ORCPT ); Fri, 5 Jul 2019 00:09:21 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:60406 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725280AbfGEEJU (ORCPT ); Fri, 5 Jul 2019 00:09:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=Content-Transfer-Encoding: Content-Type:In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To: Subject:Sender:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=EpLpp6d5ev9UdUsgMU6f1l10/dE3Pg2qZg1140QaSWM=; b=b1jq75dxQbtB+7a65u6Rylo1L 01T+/tPNKG4kAsias6gKT+e74KMYqsNVmHNpVUoATOVU43k0Q/oYEhbxb7uASluBzw9t31DXxOL4F VX9z+yb05Q+x9j+UVT6qB5SgP2QBi4gKgLvzIk7PpgKOFDOM75PF44vgjqpqzs1tXlSKHC82n/NJR mcjMdya35Mmn8wRdnCrJX1ijkuZzv7v7xGKF4UDt8ePkXqFbZInlYET+gWKS5rEU+CyZuoTWm3XSc Hk7S9UcSvq651qhTErC6lu0KudmoNoOKgrdnKQPc+r9geI20Fp6U2sgvPOInrz+2PZxT+v0SZsNyA uxb8DneeQ==; Received: from static-50-53-52-16.bvtn.or.frontiernet.net ([50.53.52.16] helo=dragon.dunlab) by bombadil.infradead.org with esmtpsa (Exim 4.92 #3 (Red Hat Linux)) id 1hjFXC-0007w4-C8; Fri, 05 Jul 2019 04:09:18 +0000 Subject: Re: mmotm 2019-07-04-15-01 uploaded (gpu/drm/i915/oa/) To: Masahiro Yamada Cc: Andrew Morton , Mark Brown , linux-fsdevel@vger.kernel.org, Linux Kernel Mailing List , linux-mm@kvack.org, Linux-Next Mailing List , mhocko@suse.cz, mm-commits@vger.kernel.org, Stephen Rothwell , dri-devel References: <20190704220152.1bF4q6uyw%akpm@linux-foundation.org> <80bf2204-558a-6d3f-c493-bf17b891fc8a@infradead.org> <5e5353e2-bfab-5360-26b2-bf8c72ac7e70@infradead.org> From: Randy Dunlap Message-ID: <8868b3fc-ba16-2b01-4ebb-4bdefc2f9e18@infradead.org> Date: Thu, 4 Jul 2019 21:09:15 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7/4/19 8:44 PM, Masahiro Yamada wrote: > On Fri, Jul 5, 2019 at 12:23 PM Randy Dunlap wrote: >> >> On 7/4/19 8:09 PM, Masahiro Yamada wrote: >>> On Fri, Jul 5, 2019 at 12:05 PM Masahiro Yamada >>> wrote: >>>> >>>> On Fri, Jul 5, 2019 at 10:09 AM Randy Dunlap wrote: >>>>> >>>>> On 7/4/19 3:01 PM, akpm@linux-foundation.org wrote: >>>>>> The mm-of-the-moment snapshot 2019-07-04-15-01 has been uploaded to >>>>>> >>>>>> http://www.ozlabs.org/~akpm/mmotm/ >>>>>> >>>>>> mmotm-readme.txt says >>>>>> >>>>>> README for mm-of-the-moment: >>>>>> >>>>>> http://www.ozlabs.org/~akpm/mmotm/ >>>>> >>>>> I get a lot of these but don't see/know what causes them: >>>>> >>>>> ../scripts/Makefile.build:42: ../drivers/gpu/drm/i915/oa/Makefile: No such file or directory >>>>> make[6]: *** No rule to make target '../drivers/gpu/drm/i915/oa/Makefile'. Stop. >>>>> ../scripts/Makefile.build:498: recipe for target 'drivers/gpu/drm/i915/oa' failed >>>>> make[5]: *** [drivers/gpu/drm/i915/oa] Error 2 >>>>> ../scripts/Makefile.build:498: recipe for target 'drivers/gpu/drm/i915' failed >>>>> >>>> >>>> I checked next-20190704 tag. >>>> >>>> I see the empty file >>>> drivers/gpu/drm/i915/oa/Makefile >>>> >>>> Did someone delete it? >>>> >>> >>> >>> I think "obj-y += oa/" >>> in drivers/gpu/drm/i915/Makefile >>> is redundant. >> >> Thanks. It seems to be working after deleting that line. > > > Could you check whether or not > drivers/gpu/drm/i915/oa/Makefile exists in your source tree? It does not. > Your build log says it was missing. > > But, commit 5ed7a0cf3394 ("drm/i915: Move OA files to separate folder") > added it. (It is just an empty file) > > I am just wondering why. I am not using any git tree(s) for this. Just patches. That Makefile is in patch-v5.2-rc7-next-20190704.xz. I don't know how Andrew generates the linux-next.patch file for mmotm, but I don't see that Makefile anywhere in mmotm, although the rest of the i915/oa/ files seems to be there. Maybe diff skips empty files unless told to save them? -- ~Randy