From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A42F3FA372A for ; Wed, 16 Oct 2019 11:46:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7969020854 for ; Wed, 16 Oct 2019 11:46:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732319AbfJPLqP (ORCPT ); Wed, 16 Oct 2019 07:46:15 -0400 Received: from foss.arm.com ([217.140.110.172]:37602 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727187AbfJPLqP (ORCPT ); Wed, 16 Oct 2019 07:46:15 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B591B28; Wed, 16 Oct 2019 04:46:14 -0700 (PDT) Received: from [10.1.31.184] (e121487-lin.cambridge.arm.com [10.1.31.184]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 3E0043F6C4; Wed, 16 Oct 2019 04:46:12 -0700 (PDT) Subject: Re: [PATCH] arm64: defconfig: add JFFS FS support in defconfig To: "Ooi, Joyce" , Catalin Marinas , Will Deacon , Dinh Nguyen Cc: Tan Ley Foon , Anson Huang , Arnd Bergmann , Ong Hean Loong , See Chin Liang , linux-kernel@vger.kernel.org, Maxime Ripard , Bjorn Andersson , Marcin Juszkiewicz , Jagan Teki , Olof Johansson , Leonard Crestez , Shawn Guo , linux-arm-kernel@lists.infradead.org References: <1571218528-12126-1-git-send-email-joyce.ooi@intel.com> From: Vladimir Murzin Message-ID: <8869edbc-e7b4-dfb3-1567-740132820133@arm.com> Date: Wed, 16 Oct 2019 12:46:10 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <1571218528-12126-1-git-send-email-joyce.ooi@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/16/19 10:35 AM, Ooi, Joyce wrote: > This patch adds JFFS2 FS support and remove QSPI Sector 4K size force in > the default defconfig > > Signed-off-by: Ooi, Joyce > --- > arch/arm64/configs/defconfig | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig > index c9adae4..6080c6e 100644 > --- a/arch/arm64/configs/defconfig > +++ b/arch/arm64/configs/defconfig > @@ -860,3 +860,5 @@ CONFIG_DEBUG_KERNEL=y > # CONFIG_DEBUG_PREEMPT is not set > # CONFIG_FTRACE is not set > CONFIG_MEMTEST=y > +CONFIG_JFFS2_FS=y > +CONFIG_MTD_SPI_NOR_USE_4K_SECTORS=n ^^^^ This is incorrect syntax for disabling config option. Correct one is # CONFIG_MTD_SPI_NOR_USE_4K_SECTORS is not set However, it looks to me you want to remove it from defconfig rather than force it to be unset. Cheers Vladimir