From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 004B6C433EF for ; Tue, 8 Mar 2022 11:30:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244382AbiCHLbg (ORCPT ); Tue, 8 Mar 2022 06:31:36 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53858 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231408AbiCHLbd (ORCPT ); Tue, 8 Mar 2022 06:31:33 -0500 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 924EF3FD96 for ; Tue, 8 Mar 2022 03:30:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1646739037; x=1678275037; h=message-id:date:mime-version:subject:to:references:from: in-reply-to:content-transfer-encoding; bh=FfySqN0vQa4ttzZHSXEhhQ3ALTvA9lNDII7nXpWIblk=; b=U8rzKHNYjTsRYwrs7GJcPeXlo4I63PIkKzhiRmKTJt4KNVJ88RyMVh8L +N8gdxbSNmtYDoNwzX5+AnaGVHRJ5H1LfR6WOh4ZKzmvVu8y5R6ogPri6 11ogS0k8GK5wAplADUH6k54ji21iFE7FtPTON1WESNRWzkRFRnZLw2oJh ovwULfLkXMTWu9tUMTo1d5BcW0qFbSfMYPeMgrJY/NxcTINttBAzHUXXz GgA4jNqP5tvSMyzbCyMzAc5ib2gfSRPJmUnffNQDPrgB+Rt8i91HjaHgv unQcA7zzLfFEgTZF/EIICRtg93n84+gbM9ftR3KPWKJUCiX72QczU5BO0 g==; X-IronPort-AV: E=McAfee;i="6200,9189,10279"; a="341093265" X-IronPort-AV: E=Sophos;i="5.90,164,1643702400"; d="scan'208";a="341093265" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Mar 2022 03:30:37 -0800 X-IronPort-AV: E=Sophos;i="5.90,164,1643702400"; d="scan'208";a="687893094" Received: from nsedoc-mobl.ger.corp.intel.com (HELO [10.251.218.162]) ([10.251.218.162]) by fmsmga001-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Mar 2022 03:30:33 -0800 Message-ID: <886a7712-ffdc-4d0c-fde5-5498b84e416c@linux.intel.com> Date: Tue, 8 Mar 2022 13:30:41 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: [PATCH] ASoC: SOF: Add missing of_node_put() in imx8m_probe Content-Language: en-US To: Miaoqian Lin , Pierre-Louis Bossart , Liam Girdwood , Ranjani Sridharan , Kai Vehmanen , Daniel Baluta , Mark Brown , Jaroslav Kysela , Takashi Iwai , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Viorel Suman , sound-open-firmware@alsa-project.org, alsa-devel@alsa-project.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20220308023325.31702-1-linmq006@gmail.com> From: =?UTF-8?Q?P=c3=a9ter_Ujfalusi?= In-Reply-To: <20220308023325.31702-1-linmq006@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/03/2022 04:33, Miaoqian Lin wrote: > The device_node pointer is returned by of_parse_phandle() with refcount > incremented. We should use of_node_put() on it when done. Reviewed-by: Peter Ujfalusi > Fixes: afb93d716533 ("ASoC: SOF: imx: Add i.MX8M HW support") > Signed-off-by: Miaoqian Lin > --- > sound/soc/sof/imx/imx8m.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/sound/soc/sof/imx/imx8m.c b/sound/soc/sof/imx/imx8m.c > index 788e77bcb603..60251486b24b 100644 > --- a/sound/soc/sof/imx/imx8m.c > +++ b/sound/soc/sof/imx/imx8m.c > @@ -224,6 +224,7 @@ static int imx8m_probe(struct snd_sof_dev *sdev) > } > > ret = of_address_to_resource(res_node, 0, &res); > + of_node_put(res_node); > if (ret) { > dev_err(&pdev->dev, "failed to get reserved region address\n"); > goto exit_pdev_unregister; -- Péter