From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
To: Mark Brown <broonie@kernel.org>
Cc: Rohit kumar <rohitkr@codeaurora.org>,
lgirdwood@gmail.com, robh+dt@kernel.org, mark.rutland@arm.com,
plai@codeaurora.org, bgoswami@codeaurora.org, perex@perex.cz,
tiwai@suse.com, alsa-devel@alsa-project.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 3/5] ASoC: qcom: add sdm845 sound card support
Date: Mon, 9 Jul 2018 15:02:11 +0100 [thread overview]
Message-ID: <887331ff-8892-66a7-20bc-0fce447c792f@linaro.org> (raw)
In-Reply-To: <20180709124117.GG16082@sirena.org.uk>
On 09/07/18 13:41, Mark Brown wrote:
>> AFAIU, The issue with that mechanism or EPROBEDEFER is that it works only
>> for first time.. for the second time(restart usecase) there are no hooks
>> like bind/unbind.
> This is not the case, the card will be unbound at the ASoC level when
> any of the components are removed and then probed again when they
> reappear.
>
I did try this and It works only for first time! May be am missing
something!
snd_soc_component_del_unlocked() unregisters the sound card totally. so
for the second time (After DSP stop) there is no registered sound card
in place.. Am not sure how this is supposed to work?
The reason I think it works for the first time is because of EPROBEDEFER
from the machine driver.
Here are the steps I do with DSP:
Step1: Start DSP, can see sound card after all the services are ON.
Step2: Stop DSP, there is no audio card.
Step3: Start DSP, I can see all the components in debugfs but not the
sound card.
This is what I do w.r.t code:
From machine driver in snd_soc_register_card() in probe()
From Audio services driver snd_soc_register_component() in probe() and
snd_soc_unregister_component() in remove()
When DSP is stopped the audio services disappear and
snd_soc_unregister_component() is invoked.
thanks,
srini
next prev parent reply other threads:[~2018-07-09 14:02 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-06 9:43 [PATCH v3 0/5] Add support for audio on SDM845 SoC Rohit kumar
2018-07-06 9:43 ` [PATCH v3 1/5] ASoC: qcom: dt-bindings: Add sdm845 machine bindings Rohit kumar
2018-07-11 15:31 ` Rob Herring
2018-07-06 9:43 ` [PATCH v3 2/5] ASoC: qcom: Add support to parse common audio device nodes Rohit kumar
2018-07-06 17:51 ` Srinivas Kandagatla
2018-07-09 7:43 ` [alsa-devel] " Vinod
2018-07-06 9:43 ` [PATCH v3 3/5] ASoC: qcom: add sdm845 sound card support Rohit kumar
2018-07-09 7:48 ` [alsa-devel] " Vinod
2018-07-09 10:46 ` Rohit Kumar
2018-07-09 14:45 ` Vinod
2018-07-09 9:06 ` Srinivas Kandagatla
2018-07-09 11:14 ` Mark Brown
[not found] ` <2110bdcf-96ad-deb5-a5cb-767d7b2e242d@codeaurora.org>
2018-07-09 12:03 ` [alsa-devel] " Mark Brown
2018-07-09 12:34 ` Srinivas Kandagatla
2018-07-09 12:41 ` Mark Brown
2018-07-09 12:47 ` Srinivas Kandagatla
2018-07-09 14:02 ` Srinivas Kandagatla [this message]
2018-07-09 16:33 ` Mark Brown
2018-07-10 10:59 ` Srinivas Kandagatla
2018-07-06 9:43 ` [PATCH v3 4/5] ASoC: dt-bindings: Update dt binding name for apq8096 Rohit kumar
2018-07-06 17:51 ` Srinivas Kandagatla
2018-07-11 15:31 ` Rob Herring
2018-07-06 9:43 ` [PATCH v3 5/5] ASoC: qcom: apq8096: Use common APIs to parse device nodes Rohit kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=887331ff-8892-66a7-20bc-0fce447c792f@linaro.org \
--to=srinivas.kandagatla@linaro.org \
--cc=alsa-devel@alsa-project.org \
--cc=bgoswami@codeaurora.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=perex@perex.cz \
--cc=plai@codeaurora.org \
--cc=robh+dt@kernel.org \
--cc=rohitkr@codeaurora.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®