From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89AE9C7618F for ; Fri, 19 Jul 2019 19:17:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 610B42085A for ; Fri, 19 Jul 2019 19:17:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=cumulusnetworks.com header.i=@cumulusnetworks.com header.b="G7eiEZPm" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728784AbfGSTRu (ORCPT ); Fri, 19 Jul 2019 15:17:50 -0400 Received: from mail-io1-f66.google.com ([209.85.166.66]:43203 "EHLO mail-io1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728247AbfGSTRr (ORCPT ); Fri, 19 Jul 2019 15:17:47 -0400 Received: by mail-io1-f66.google.com with SMTP id k20so60607574ios.10 for ; Fri, 19 Jul 2019 12:17:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cumulusnetworks.com; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=rYom2UNS2ShD8Awg1j+2vPvOzfMncD5P0dbl6lOVAWg=; b=G7eiEZPm94DMIAj76dY/HN5osv1vTtRiNyFIRoFGh0cz1AZZu/wglBa+bMFNejRw/G d/iP5O6XqvtQyeevF6eobrduN0RbEJ3J4b6YmyB6RsUG1ECX8sCSSf7SBvKcyIQHTf1b 3+rNoBHOK/e7lXJExw/mQqDdF6KuwKfOZ6rOA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=rYom2UNS2ShD8Awg1j+2vPvOzfMncD5P0dbl6lOVAWg=; b=uRIcGy1n84xTH9tLNxuan+nZwB2F+lBoU0dLgKdHMHUzILpbofnlkFqIcTHP4sf3Ob 7lZMhMV9X+AgMK4VwVAxytkgpWXvGJNrg+VPm0GP8Ne5ZSTYrIXC3PUFJCyN5lFM2kS2 zT55xQQ4zglzpxQY46N71qUHbCEG6avQf0oNI7aO7FGGOUV9ZP/B/6aiqhXZ2FFC5DHy HdvJoy5TbNkW5l6NKitVLUJSYTmvX/Fcxp2ynYzq9yUmj9YLx1UVoFueHTB0Fw8iUmZg +gWxs886wdZYt4CiaEnXI5SHjgkQv24FQxIn7HB1MAaLU4X76axAx0NHFe/htpnvLRKQ AMZQ== X-Gm-Message-State: APjAAAVXTx8G1/WaVmJ+FI0vrI9qG+hadfjOBRVt3pCcHTBCJv3UH4fG Z/SWOgUXYhcfJh5QSkQVVQVpK6iAx6U= X-Google-Smtp-Source: APXvYqxPx/csCPoEteEKD5DXzCwYUPKKeK/r+Onk709tFFqkvFUYYCySkJXUAVM52VHyRzRmBFGkeA== X-Received: by 2002:a6b:6a01:: with SMTP id x1mr11902637iog.77.1563563866410; Fri, 19 Jul 2019 12:17:46 -0700 (PDT) Received: from ?IPv6:2601:282:800:fd80:b559:3352:82ff:93d8? ([2601:282:800:fd80:b559:3352:82ff:93d8]) by smtp.googlemail.com with ESMTPSA id n7sm23662470ioo.79.2019.07.19.12.17.45 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 19 Jul 2019 12:17:45 -0700 (PDT) Subject: Re: [PATCH v2] vrf: make sure skb->data contains ip header to make routing To: Peter Kosyh Cc: davem@davemloft.net, Shrijeet Mukherjee , netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <213bada2-fe81-3c14-1506-11abf0f3ca22@cumulusnetworks.com> <20190719081148.11512-1-p.kosyh@gmail.com> From: David Ahern Message-ID: <8874f5a2-b86f-6c85-525f-534381daa8a3@cumulusnetworks.com> Date: Fri, 19 Jul 2019 13:17:44 -0600 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20190719081148.11512-1-p.kosyh@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7/19/19 2:11 AM, Peter Kosyh wrote: > vrf_process_v4_outbound() and vrf_process_v6_outbound() do routing > using ip/ipv6 addresses, but don't make sure the header is available > in skb->data[] (skb_headlen() is less then header size). > > Case: > > 1) igb driver from intel. > 2) Packet size is greater then 255. > 3) MPLS forwards to VRF device. > > So, patch adds pskb_may_pull() calls in vrf_process_v4/v6_outbound() > functions. > > Signed-off-by: Peter Kosyh > --- > drivers/net/vrf.c | 58 +++++++++++++++++++++++++++++++++---------------------- > 1 file changed, 35 insertions(+), 23 deletions(-) > Reviewed-by: David Ahern