From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 05F8A376BE6 for ; Thu, 20 Nov 2025 15:50:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763653853; cv=none; b=NKm+MFLt4Nr4zQY5b40r32JVuRWZ86uXKtFUK5FI1xjW44i3sY3jPJ6BJLQGDEcTkqT2v6GG3UYNXJCjsajveU8+6oK0gQWceyHQgCif0y8vyAth/LW+EmzoAmfbs7Eqa8vOqF8vq15WtrhYRpipgReGcqhksVjhPpTDL2cnEyA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763653853; c=relaxed/simple; bh=3LXjZvhAxhf5oSUUkSRQAsK/IDNbfA5F7E3Mq6aXfQg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=rtNB060leklWL0cmc4yDIqFEhNXVk//6ZDem5b4/6IezbdtXmKVdhHgkx/ORqAjzFERWHH0P6eFu5om4tDzY/mjB2igSHSaRNdXEU3iITP0XEiNHndtDeWx1ozoIcrVEF/qsIUTwm8uvzGJX9fq2LltMbNEevMUic2q6+xEoigw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=MrWlbsmy; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=NkGV3fOZ; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="MrWlbsmy"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="NkGV3fOZ" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5AK9hK4P473369 for ; Thu, 20 Nov 2025 15:50:48 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= fjJkCHucrCZBX5LjnXaIOgVpyAHpaiZEXld9Y5GuCoc=; b=MrWlbsmyA5Myc170 76O8bjw+rdnsu5I+jXBNKffSmeUz+9n+i7t2TnOLewNadcT6LY06NNc7C80IDnL2 W8TkAL+8as0th5hoQEJoPsZjUjTIVVSHGa/Rcp8ULNX2y8ExqopMxV/6rBPARx1M Woz9OdtAXgkhWwpJwK0bYPEEdo/DSUcBQG5kspYPkz9z246nPtuW12e2m2ygkk45 eE6zqt17vPTowi2DJfCXQ1jHd21AP3OdfjeDuyBpbxPv/HACC0AlJ2H2cGT0SDVB jdYTlGB4hKn7hwx9Wrezeh1uUMMyd0fNpbAKalX9KcMeUAr3vtUrktpmCOKVLt1l 3B1C5Q== Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4aj0kw13aq-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 20 Nov 2025 15:50:48 +0000 (GMT) Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-8b184fa3ffbso31058885a.3 for ; Thu, 20 Nov 2025 07:50:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1763653848; x=1764258648; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=fjJkCHucrCZBX5LjnXaIOgVpyAHpaiZEXld9Y5GuCoc=; b=NkGV3fOZy/AuMwIVroEXDysn46e+x8z6AhqrpqXHPt1BbwSU6GU+A7nNVZ06IeMNgn 1/2yUcGVuhEYCI0ml6XciFBPovnPJNevgaKG0jrz+8ezj0HY3tyuk91kbv53XUgRI7+j /hb8BQC0PtbzuVKxgM3hPxNzuHd0xr3DHIFPE8yUV+olxicZvmYK/pVDHY3ic4E1/TDp I6XXziMgN/y+lbxyxwZeVBgsG4A8CbPwN+Pb1nJGyNQ/LlkLCscIOHQVL0jj+TQUy8X9 nfJM9DPkHB4wSS4GKGxNil5kOCbvnPCiprtoFBXSOWF0QA6zFE4gsbBGKQumoNu9Xeb3 8Cew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763653848; x=1764258648; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=fjJkCHucrCZBX5LjnXaIOgVpyAHpaiZEXld9Y5GuCoc=; b=O2OtAoodYM+iHYtSyNcmFJeHyigNf0KAtAdHdy1SX52NUhCk5AOTGlpWvw6k7a6Pmi uiN+H0NnaxnclAAy/DQpWN7LvrFnudSBZZJVYzV6ItiMy8kfleZx3eAvLoM7mfAtDlxi PCYDCGJWSxOSAIQPGGV9tkzXcz/GhQM+i00BiRXA0+cuZlB1WoLcnLEgoIDlJWdc0aKH 0j4Jy5a4vEH8OPusVQjZRLg7QCBDHATuoFe2DeQeP4czbocKy+28wvR/9TOJoXOZD7G3 pcZOMK7U7DDoMxPvkJU2qaqpnJtvXxHrHcQlhbdWbeBUjzs6qBqgITOLZVdhwpYobpPa 5uiQ== X-Forwarded-Encrypted: i=1; AJvYcCWzIFcMgAYyep+GB/+I5UV6FUXUIQMd+nqh/Nffh4X43JRSYvDhSAhEqpdMxmFnbSyFZLepe2mCpvD7G1A=@vger.kernel.org X-Gm-Message-State: AOJu0Yx3dMoAI5DzWzs0McvO+AUqmhnPpeemZoLebWF6i6/Yuae9rJnb QaSCu6oARBwwTgcRcHrhaRzgrJ6JD8Y0JPqxbAqGXMkDDIHk4Np1rnCaxfzNaceo6erFm03VJCB zAoBmYd4fOg7aQEFrkctas+pyPfMxPcYwIoP9skNugsiLsNrpjL3r6YsR9wBY7KwbYrk= X-Gm-Gg: ASbGncumrU9jqYy63K4JtrfensDumUGjMI3ljIBXn88OanAgaPDnXSiJFoZk0yFln1I 2ngBiqkZXZwVqU0SHWXAO+1YnaEsHt1fGqf8NkiS0fVg7NTuOf8Mc69HuxMoa+ohwYmZOQKzUVb 5AqUOYtKtT625lVo69T051lGFrlGTVNQMDKIwy3noIRGOEOSHlTyJfZbYp7UD/i3PqKRBgY619S YONxzTCMzyHt/3QBbven8rx+ocmFxaOajhhJRqL9flTKJF+YGfqMkGPaN3v1O3Q6GzVRdNjEn0j 23PMIqyxkjiU5TdLCMk0qdmev7PoFp0X9XxlRjT/hdk9N8zy4q2UdwUXnCJtJsODGELJZrsIset pjhCSPqwGV1pQq0/Pkvf5kpQLc2Va6oiYXwzJivVuy4UCVWL7hlrt9TW8L/9iGJRdH+8= X-Received: by 2002:a05:620a:7107:b0:8b2:1f04:f8b with SMTP id af79cd13be357-8b32747edf9mr366254185a.6.1763653848120; Thu, 20 Nov 2025 07:50:48 -0800 (PST) X-Google-Smtp-Source: AGHT+IE4MYAPZE3Av5PSX2AH04IPx8xcJqHIXsZFnzG0TUzdhgaJAWfh7xBLUjVQ4xGirjPSFLXPHw== X-Received: by 2002:a05:620a:7107:b0:8b2:1f04:f8b with SMTP id af79cd13be357-8b32747edf9mr366250785a.6.1763653847529; Thu, 20 Nov 2025 07:50:47 -0800 (PST) Received: from [192.168.119.202] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-645364437b2sm2304423a12.25.2025.11.20.07.50.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 20 Nov 2025 07:50:46 -0800 (PST) Message-ID: <88778660-18de-40a7-83af-41f60334c4cc@oss.qualcomm.com> Date: Thu, 20 Nov 2025 16:50:44 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] PCI: Add quirk to disable ASPM L1 for Sandisk SN740 NVMe SSDs To: Manivannan Sadhasivam , bhelgaas@google.com Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Manivannan Sadhasivam References: <20251120154601.116806-1-mani@kernel.org> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20251120154601.116806-1-mani@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=WeUBqkhX c=1 sm=1 tr=0 ts=691f38d8 cx=c_pps a=hnmNkyzTK/kJ09Xio7VxxA==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=6UeiqGixMTsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=VwQbUJbxAAAA:8 a=6wk0BdiTjokcx5KyKl0A:9 a=QEXdDO2ut3YA:10 a=PEH46H7Ffwr30OY-TuGO:22 X-Proofpoint-GUID: WNj6JjPJHjLJuIRlBGM-viWBHV62Os6y X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMTIwMDEwNSBTYWx0ZWRfX1s0MhWDqYnGL pQxTWiQB24nFjR8gUhvMi2KdA/nsS3QdO7AuAv2gBwaWdUmxuhJ8Ws8QgcbaleR0JIfKidNelaB 5iRcj5Od8awOVQ4yo48QP4hiNkLNhG/MTy1c0dTswzWpukvOQXzxQeaaqB+ZHpiOmtwELCp5nzw dfkdxQ/eHMEI5mlgT7dZCOzJmY6ImhwM50OWYgMHfsx19yap/LeFBHVIWBgmvacZLYC0HCPJ5i6 728exljCqCG2nvK9579J3mUXuC5X/JUnR92gzY1Rxh1D6EOuTK2Fc0ouMmij3+tq6wVC/jEkviR Bb3berRhvOlvZI/+y3PNIrcTev8teUdPegoS9QRKkNTbBCm4DjkaXF1f606idFZ2QsN7/UUSL0z MYGx0XlCbKPtfDZ0vyRL/9XAnSAVEw== X-Proofpoint-ORIG-GUID: WNj6JjPJHjLJuIRlBGM-viWBHV62Os6y X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-11-20_06,2025-11-20_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 bulkscore=0 clxscore=1015 suspectscore=0 spamscore=0 lowpriorityscore=0 adultscore=0 malwarescore=0 phishscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2511200105 On 11/20/25 4:46 PM, Manivannan Sadhasivam wrote: > The Sandisk SN740 NVMe SSDs cause below AER errors on the upstream Root > Port of PCIe controller in Lenovo Thinkpad T14s laptop when ASPM L1 is ^ Microsoft Surface Laptop 7 Konrad > enabled: > > pcieport 0006:00:00.0: AER: Correctable error message received from 0006:01:00.0 > nvme 0006:01:00.0: PCIe Bus Error: severity=Correctable, type=Physical Layer, (Receiver ID) > nvme 0006:01:00.0: device [15b7:5015] error status/mask=00000001/0000e000 > nvme 0006:01:00.0: [ 0] RxErr > > Hence, add a quirk to disable L1 state for this SSD. > > Reported-by: Konrad Dybcio > Signed-off-by: Manivannan Sadhasivam > --- > drivers/pci/quirks.c | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c > index 214ed060ca1b..a6f88c5ba2f4 100644 > --- a/drivers/pci/quirks.c > +++ b/drivers/pci/quirks.c > @@ -2525,6 +2525,18 @@ static void quirk_disable_aspm_l0s_l1(struct pci_dev *dev) > */ > DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_ASMEDIA, 0x1080, quirk_disable_aspm_l0s_l1); > > +static void quirk_disable_aspm_l1(struct pci_dev *dev) > +{ > + pci_info(dev, "Disabling ASPM L1\n"); > + pci_disable_link_state(dev, PCIE_LINK_STATE_L1); > +} > + > +/* > + * Sandisk SN740 NVMe SSDs cause AER timeout errors on the upstream PCIe Root > + * Port when ASPM L1 is enabled. > + */ > +DECLARE_PCI_FIXUP_FINAL(0x15b7, 0x5015, quirk_disable_aspm_l1); > + > /* > * Some Pericom PCIe-to-PCI bridges in reverse mode need the PCIe Retrain > * Link bit cleared after starting the link retrain process to allow this