From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752004AbeC2IZf (ORCPT ); Thu, 29 Mar 2018 04:25:35 -0400 Received: from mail-wm0-f67.google.com ([74.125.82.67]:36691 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750858AbeC2IZd (ORCPT ); Thu, 29 Mar 2018 04:25:33 -0400 X-Google-Smtp-Source: AIpwx4/QfTc5gAjcD9XJzwf7pZyYduAvwAuO8QjPQaC4SM3JM8phUvZW11oLE7ocfSa7IPoADObgsQ== Subject: Re: [PATCH v3 1/2] Documentation: Documentation for qcom, llcc To: Rishabh Bhatnagar , linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org Cc: linux-arm@lists.infradead.org, linux-kernel@vger.kernel.org, tsoni@codeaurora.org, kyan@codeaurora.org, ckadabi@codeaurora.org References: <1522176722-12691-1-git-send-email-rishabhb@codeaurora.org> <1522176722-12691-2-git-send-email-rishabhb@codeaurora.org> From: Stanimir Varbanov Message-ID: <887b47bf-3927-7d07-5000-9d74e83be5fe@linaro.org> Date: Thu, 29 Mar 2018 11:25:31 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <1522176722-12691-2-git-send-email-rishabhb@codeaurora.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 03/27/2018 09:52 PM, Rishabh Bhatnagar wrote: > Documentation for last level cache controller device tree bindings, > client bindings usage examples. > > Signed-off-by: Channagoud Kadabi > Signed-off-by: Rishabh Bhatnagar > --- > .../devicetree/bindings/arm/msm/qcom,llcc.txt | 70 ++++++++++++++++++++++ > 1 file changed, 70 insertions(+) > create mode 100644 Documentation/devicetree/bindings/arm/msm/qcom,llcc.txt > > diff --git a/Documentation/devicetree/bindings/arm/msm/qcom,llcc.txt b/Documentation/devicetree/bindings/arm/msm/qcom,llcc.txt > new file mode 100644 > index 0000000..ceb20a4 > --- /dev/null > +++ b/Documentation/devicetree/bindings/arm/msm/qcom,llcc.txt > @@ -0,0 +1,70 @@ > +== Introduction== > + > +LLCC (Last Level Cache Controller) driver is implemented as a platform device. > +The driver Programs the SCT (system configuration table). The SCT programming > +divides the system cache into slices. Each slice is assigned an ID A.K.A > +SCID(Sub-cache ID). > +HW modules that are designated to use the system cache are known as clients. > +Each client must also be represented as a node in the device tree just like > +any other hw module. > +One client can have multiple SCID's assigned meaning each client could get > +multiple slices in the cache. Client can use the slices for various pre-defined > +usecases. Each client defines a set of names for these usecases in its > +device tree binding. > +Client makes a request to LLCC device to get cache-slices properties for each > +of its usecase. Client gets the information like cache slice ID and size of the > +cache slice. All this describes the driver, please just describe what is LLCC and for what it used for. > + > +== llcc device == drop this. > + > +Properties: > +- compatible: > + Usage: required > + Value type: > + Definition: must be "qcom,sdm855-llcc" > + > +- reg: > + Usage: required > + Value Type: > + Definition: must be addresses and sizes of the LLCC registers > + > +- #cache-cells: > + Usage: required > + Value Type: > + Definition: Number of cache cells, must be 1 > + > +- max-slices: > + usage: required > + Value Type: > + Definition: Number of cache slices supported by hardware > + > +Example: > + > + llcc: qcom,sdm855-llcc@01100000 { this should be qcom,llcc@1100000 > + compatible = "qcom,sdm845-llcc"; > + reg = <0x01100000 0x250000>; > + #cache-cells = <1>; > + max-slices = <32>; > + }; > + > +== Client == > + > +Required properties: > +- cache-slice-names: in my opinion this shouldn't be required but optional. > + Usage: required > + Value type: > + Definition: A set of names that identify the usecase names of a client that > + uses cache slice. These strings are used to look up the cache slice > + entries by name. > + > +- cache-slices: > + Usage: required > + Value type: > + Definition: The tuple has phandle to llcc device as the first argument and > + the second argument is the usecase id of the client. > +For Example: > + > + venus { > + cache-slice-names = "vidsc0", "vidsc1"; > + cache-slices = <&llcc 2>, <&llcc 3>; please make 2,3 and so on #defines. -- regards, Stan