From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 11D25386572 for ; Tue, 21 Jul 2026 16:55:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784652906; cv=none; b=hS50wKNzIZziSjy2JMcYlUtGtxB6GwkJlrzLF/Mnw9+gtaA0t7CQGNswDEHP48Z/9p3VP3q7lgvdirbxeS7zwHU2ji86R2DQ+va1hAtkGjWFF39aDa5rED/NwwfLe4RMq7ynqAwqbHC1tjGrcTZdyQo+FS7qls7q7DHpnTn0v1Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784652906; c=relaxed/simple; bh=tUOGkrU38mJEYQ6zuey7GmqIR1DTnR211ZbxiXdMIpk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=UlInk+x7fGpUhzvesy93dotx1wRF2HyyzO/5B39C2r21ttvbo/LwOVCqfOIpRInkqF236Fy2UMBUnJ4KHms/n+dce5Gxv8SBhVCMPZ/WNoY+TDfiZQRoOnpuhV5kq0sN/WwyZkBdA7JqtgyuwVAaEfbXe+jeNTkJt42zwm9QopA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=UjCIE/t/; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=VC+4BBV6; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="UjCIE/t/"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="VC+4BBV6" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66LDgGeX1399812 for ; Tue, 21 Jul 2026 16:55:03 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= l1o8yex40q2dVFxxH/gSrgSpN6Ch4JjKqRjhqPQXctg=; b=UjCIE/t/65fmEIq0 kq92YjXNqmxGYGE81D2sfm+knDmJT/TNZRdGfegorbV6og/Io4zCHGkrO00UtGqQ t9wotnCGH+wXIzfdOzGVy6D2b9GDO1yT/USMFtBiwAjS0A79zcP60xeA1xs7SvXT 6OPFESLQ+Jbu9E1tgZEHuEO0+NhPLf9b5ZNtt12Y3C0hj19IOM1gjQy9xjs3Ujx4 9iArhVY5zAXHwEeyqnYgCY1iD8GYU274RAnrI79hI81eSmNiopFcCKpLVY45PRf5 Dn54CcHUJ+vl5M9qF6rCNXRFDaMDjB9uDj51enUvukdKRwFlTGQKLgnr9QUAYcB+ XBUPiQ== Received: from mail-pg1-f197.google.com (mail-pg1-f197.google.com [209.85.215.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fj1es3kd9-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 21 Jul 2026 16:55:03 +0000 (GMT) Received: by mail-pg1-f197.google.com with SMTP id 41be03b00d2f7-caf5fa127d4so12527081a12.0 for ; Tue, 21 Jul 2026 09:55:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1784652903; x=1785257703; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=l1o8yex40q2dVFxxH/gSrgSpN6Ch4JjKqRjhqPQXctg=; b=VC+4BBV6OIOEkBqNQ2IMg4IroImr1RlW7BBZ9r5bSjbKLXDgKrC2XueGloa4A71LUM rcIQM9Dz4ObLnMYZA1biTTHmpfSYHT0gvqYZ1xa1BMJGYoPIRMWa3Xzz+1OCAz+vOFUW 3xfz/NbVxRUfDXnEZJW3Njfy+4vVmaNqNIWJfIkqRJ4UHE1TPja13A7xVRuK9DI/om+T FymdHszm+1e7W4yoYaJgl0U1vdrJRWC0RDp/z/10b3DPsX2LhU7aFszcgmj480rWZoal 1HAexWBb4jQ4nOYMmimvcq90TrdJ8dnYUEjl4qzrpuViITMt7Y64ZjzabX0OheA1OYZq aipA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784652903; x=1785257703; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=l1o8yex40q2dVFxxH/gSrgSpN6Ch4JjKqRjhqPQXctg=; b=SfTk1qq21mWEYtZ0iHSIIyR3/ey42V2eOEvyUOh11qNgsxKyxF1gzJBYV3v5H6PG/x eP8rM3ovE3L09qKPYR06o0zOb8z9RGuD1RfgU+F1/QMlRvKtx3n2f22ytOYVUGVo663j cBsco9EXzvdxktZRMOYA6G3IIEfSTtSd/sI/hMsKlLFU9owCcl6xJAgJsGaUTv0zZ0+O Giu+8Z2mNSZ1KdFXk+D7otE5KLdumvuGuHMMaZi0hiY11YI0su6sEkmmahutU91BmO0n KxR+qTDnaIXD7JtNPk0eGoMPwjNSB7nl98MDVv7kown/GNG4LyNJa1WuxwCsr4d0K2Xr 7/dA== X-Forwarded-Encrypted: i=1; AHgh+Ro7QnB4tAXB7M1JuDYDNQ9wnGO7DZZZZsd574cLuOaPmEA1r34GJV1+WyAoloTHeYQZcyPvOh9lrFK+dnc=@vger.kernel.org X-Gm-Message-State: AOJu0YzilWSgfYk2A3eFJzPrkEzcXK7I3Q0XYAnijmd6/Cgb+mxNujbR WxceNzdhUibjbNBdOa2yUgCdRMeJ5VFMTYJZM2DLrdkbMJxt649xMC+/j7luXOdHjzAtkbdrAyp uodG4vwLJlkCCeeT4rsHz8euH+ey72eeWeNYDj8HlQm1P70GPEeqhWcDAjcqsNBDS9Ew= X-Gm-Gg: AfdE7ckDdQOnIHGdk2bCviC/jbrawAtzv/zxa9/1kLkLDAjpZ5+ohk8Ty8X0bjk7QSH +mJA2KcwnOi5mex3Kt1UUR+DpUpgc+J/xq/79+fpzBU+4MFN76pQVIPDIn+OUt4jlp7gn/rwaHf ftfZ3OtTUxfDLvJrP0W0GcSguqjF9DXqOqc2nwCWm/14S1c6ENEI5zKN+Pkomh46Hg6gXk/jCzv bzwBLtcebek55jWML1ARnrgyGZj3mwbr7ZlqfY1LT2dHWUn6lZA4HSMb9y0NBQo5d4LPrcVSwnu 0ovVtD+h0Rs/hLGYz2kyq5Fv40d8YxLoK7+URktnE/CBPi6wjkGsmnYxYjUJ4QRUg2Fb02Qo0SL Z/BM5pCj4rE09P9TfuKYPHR31kYyZHlFC+0655bK+gJSzF4T2HQJR+exshjPYeBrUG1wMndrn X-Received: by 2002:a05:6300:2704:10b0:3c4:1708:9cd8 with SMTP id adf61e73a8af0-3c417089d37mr2522197637.76.1784652902488; Tue, 21 Jul 2026 09:55:02 -0700 (PDT) X-Received: by 2002:a05:6300:2704:10b0:3c4:1708:9cd8 with SMTP id adf61e73a8af0-3c417089d37mr2522176637.76.1784652902041; Tue, 21 Jul 2026 09:55:02 -0700 (PDT) Received: from ?IPV6:2401:4900:1cb4:d969:b5b5:8f5b:ef15:61de? ([2401:4900:1cb4:d969:b5b5:8f5b:ef15:61de]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3147dc61637sm657080eec.8.2026.07.21.09.54.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 21 Jul 2026 09:55:01 -0700 (PDT) Message-ID: <8885f841-798e-4c8b-af10-88551f39f2a2@oss.qualcomm.com> Date: Tue, 21 Jul 2026 22:24:55 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] dmaengine: qcom: gpi: Fix SE ID and SE Protocol fields widths in SCRATCH_0 To: Chandana Kishori Chiluveru , konrad.dybcio@oss.qualcomm.com, Vinod Koul , Frank Li , bjorn.andersson@oss.qualcomm.com Cc: praveen.talari@oss.qualcomm.com, linux-arm-msm@vger.kernel.org, dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260721-fix_se_id_and_se_protocol_fields-v2-1-ee1d63d6c549@oss.qualcomm.com> Content-Language: en-US From: Mukesh Savaliya In-Reply-To: <20260721-fix_se_id_and_se_protocol_fields-v2-1-ee1d63d6c549@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=SPZykuvH c=1 sm=1 tr=0 ts=6a5fa467 cx=c_pps a=rz3CxIlbcmazkYymdCej/Q==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=bC-a23v3AAAA:8 a=EUspDBNiAAAA:8 a=k8JVevEbTmNoh4gevwMA:9 a=QEXdDO2ut3YA:10 a=bFCP_H2QrGi7Okbo017w:22 a=FO4_E8m0qiDe52t0p3_H:22 X-Proofpoint-GUID: 45qqLPNDQI160IMNdeOIFpQFgUB56d0e X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzIxMDE3OCBTYWx0ZWRfX9Nj52aYs61fD SwFA0ifu/JR4hLz0P9kJr/E/K8bwqNSoZwQyoQvIzXRvhvjvvF6W7tduv4ayjPwl3FcNFapokam BokKGqa/kH2x38+kMn7GqMXu+/HxOy/5PYA3fVZklDeKA9r5JUEiuwpTNJwwIYqv0Av7DiHQfch SGjU7zuWlmljG20CSDtcAAiC2PbbzoejEhFfVOQZtsgrDRRHEotiHNkKwL4b5XliXC1YKXiRC5U JTs/8JVQnsCSAZ0v+sY6S7ZhSlt25Y2dZ7COldz1huj/V9+Lu+pup80ea2PDieP63UM4KL+kHn4 ngBgnjqjZjEih+LKdQet7DYMpLZYZgAMfN+n1xWY62c5z3V+oSfAcmeU1uKdOUwC+aZAt8CVidu wyORrhS7ZO0Zt1lTgvyqhdBZTbg7ICiKL8Wqa4kDehSmhAtcYfH4cwlOi7riFu1Lm3QQ8Yslch8 lb/pguoPmd6kNXzLtEg== X-Proofpoint-ORIG-GUID: 45qqLPNDQI160IMNdeOIFpQFgUB56d0e X-Proofpoint-Spam-Info: AW1haW4tMjYwNzIxMDE3OCBTYWx0ZWRfX7qHaVtSS5zKt Jt2INfCeKYaSaVChuiSnXnporbFa+JeoFmuo1K8CRO9asVEEpJY3hGuCzELjhflfLpIC/SUoE3s tNeSZ29A9FVr92y+g+2iLfqwAkhFHo8= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-21_03,2026-07-20_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 priorityscore=1501 bulkscore=0 phishscore=0 lowpriorityscore=0 spamscore=0 clxscore=1015 suspectscore=0 malwarescore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607210178 On 7/21/2026 4:45 PM, Chandana Kishori Chiluveru wrote: > GPII_n_CH_k_SCRATCH_0_SEID is currently defined as GENMASK(2, 0), only > 3 bits wide. Serial engine indices >= 8 get silently truncated by > FIELD_PREP()/u32_encode_bits() when written into the scratch register, > causing the GPI channel to bind to the wrong serial engine. The > channel allocate command still succeeds (it doesn't require the > target SE to respond), but the subsequent channel start command times > out waiting for hardware to complete the handoff to the (incorrectly > bound) SE, and gpi_send_cmd() returns -EIO leading to GSI usecase failures > for SE8 and SE9 serial engines. > > Older documentation, such as the SDM845 hardware programming guide, > describes the SE ID field as bits [2:0]. More recent QUP hardware > documentation defines the field as bits [3:0]. Use the wider definition > to match current hardware documentation while remaining compatible with > existing platforms and enabling serial engine IDs greater than 7. > > Also update the SE Protocol field definition to match the documented > register layout and keep both fields correctly packed. > > Fixes: 5d0c3533a19f ("dmaengine: qcom: Add GPI dma driver") > Signed-off-by: Chandana Kishori Chiluveru > --- > Changes in v2: > - Updated the protocol field value properly > - Link to v1: https://patch.msgid.link/20260720-fix_se_id_and_se_protocol_fields-v1-1-e41dbb107d97@oss.qualcomm.com > --- > drivers/dma/qcom/gpi.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Mukesh Kumar Savaliya