From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E08D8E92FF8 for ; Fri, 6 Oct 2023 08:14:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230471AbjJFIOZ (ORCPT ); Fri, 6 Oct 2023 04:14:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42582 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230344AbjJFIOX (ORCPT ); Fri, 6 Oct 2023 04:14:23 -0400 Received: from gimli.kloenk.dev (gimli.kloenk.dev [49.12.72.200]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7EA5DCA; Fri, 6 Oct 2023 01:14:22 -0700 (PDT) From: Finn Behrens DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kloenk.dev; s=mail; t=1696580059; bh=babyumwyBW20VjVqFpkm/3kmDeKlpEdTsi76E18IrY0=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=WSZjBfy9mq6e/OnF60LDWW0QUgYpamzvi2OMn/HzEbGAAxAVJfZoyzfso8aw4BUsj F2DTP91IECgzMNtpezKf0dYka/NEmtB5us3BRB80Hi3QrmJ9vF6rZ/gx5fBi8XfEHu 6aGnYQQL7N63gYi1P5IHK60drkqt8Y45u6Xk4ghY= To: Miguel Ojeda Cc: Wedson Almeida Filho , Alex Gaynor , Boqun Feng , Gary Guo , =?utf-8?q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Andreas Hindborg , Alice Ryhl , rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org, patches@lists.linux.dev Subject: Re: [PATCH 2/3] rust: print: use explicit link in documentation Date: Fri, 06 Oct 2023 10:14:15 +0200 Message-ID: <8887D7CE-BE4F-4EF4-92B4-33BAF229E590@kloenk.dev> In-Reply-To: <20231005210556.466856-3-ojeda@kernel.org> References: <20231005210556.466856-1-ojeda@kernel.org> <20231005210556.466856-3-ojeda@kernel.org> MIME-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5 Oct 2023, at 23:05, Miguel Ojeda wrote: > The future `rustdoc` in the Rust 1.73.0 upgrade requires an explicit > link for `pr_info!`: > > error: unresolved link to `pr_info` > --> rust/kernel/print.rs:395:63 > | > 395 | /// Use only when continuing a previous `pr_*!` macro (e.g. [= `pr_info!`]). > | = ^^^^^^^^ no item named `pr_info` in scope > | > =3D note: `macro_rules` named `pr_info` exists in this crate, b= ut it is not in scope at this link's location > =3D note: `-D rustdoc::broken-intra-doc-links` implied by `-D w= arnings` > > Thus do so to avoid a broken link while upgrading. > > Signed-off-by: Miguel Ojeda > --- Reviewed-by: Finn Behrens