From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4557FC433EF for ; Thu, 23 Jun 2022 02:24:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1377893AbiFWCXx (ORCPT ); Wed, 22 Jun 2022 22:23:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35418 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1376632AbiFWCXh (ORCPT ); Wed, 22 Jun 2022 22:23:37 -0400 Received: from mail-pj1-x1032.google.com (mail-pj1-x1032.google.com [IPv6:2607:f8b0:4864:20::1032]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B94A6403F0 for ; Wed, 22 Jun 2022 19:23:33 -0700 (PDT) Received: by mail-pj1-x1032.google.com with SMTP id g16-20020a17090a7d1000b001ea9f820449so1122935pjl.5 for ; Wed, 22 Jun 2022 19:23:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20210112.gappssmtp.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=csCXiXt7nFq4+h4WD6heVCXixZoWRVAJL1Lssrp4las=; b=WA6u/LptxC6hvIktNHSr3CpHwaPyPUZckJ++HrZ8zmkycEVEbijkXaMLEyDey8F+Lt +g9qR64kyl7wYpz43zDjaGpxgpfUYBvM2MdhkLXKLiNBAox4WxuLcd38TMk7diCM5eOL tC9IYkjtiUnlLb0jH4nTwNbo1PbJKCHFNfMv2BUZLagEOhrTkFeGlPLJXXFHXNifaD81 rS/gmlxZpPouMX1g7QzQbznGjyvAn1lNo0P9Oa/y0XRQ/pvZstMIW9Mc0r+zv5BrjsGH h8iGUiTl3PWQxbL7LmjM13/+bsHsPrxA+jWjulwftKo/3WMMHrO0Le7Wf11NO9X04NEA L3rw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=csCXiXt7nFq4+h4WD6heVCXixZoWRVAJL1Lssrp4las=; b=3LrK/1xVRDA7VfkaQ0fGIKHohxfEtRxLDe2kDmfp8KflyMIQWdqpKqdI/kza0cmJgh j13erZqy1nKZmzlj782WlX9TPGksZgnunlqq9ts/vSZA54ow18Vrqwcc2n0LbTzR2EJk zEW4k9N0im/8FrrQB80Ex/Jer7KALIY9I3HpZftL+5WE97AWH3Yx1LQSebrL0uvYeH22 zwh/Ad8u7rIlIWonzZoqrK/Dn/xxJupRSmUFITsH842AFdurvlQ72EBK43hfTxjae0K1 5y+upiILTifC7DO15qviBYBBWbXCH4b7HB2h7QmSBYIGLE9rVoC3mNa2nxlL+jVKvETP 6Xtg== X-Gm-Message-State: AJIora8CfH61hHJClt4Ldz5vKjBd3ba401RzIvEakhrJV19lbuWie92G 4d9Zn3mlJ0jIYBMK129tE41QMw== X-Google-Smtp-Source: AGRyM1uqKjCtHrQUq09eFtxE8toLu3fagTEkTNfoVLp49TLIhUukD4B98EO0re9osjwaTkK0xXam5A== X-Received: by 2002:a17:90b:344f:b0:1ed:9f:a2de with SMTP id lj15-20020a17090b344f00b001ed009fa2demr1532594pjb.174.1655951013124; Wed, 22 Jun 2022 19:23:33 -0700 (PDT) Received: from [10.70.253.98] ([139.177.225.230]) by smtp.gmail.com with ESMTPSA id h4-20020a62de04000000b0051bb61c0eacsm5989417pfg.20.2022.06.22.19.23.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 22 Jun 2022 19:23:32 -0700 (PDT) Message-ID: <888b6885-5380-e21f-260f-eb1bb89679c3@bytedance.com> Date: Thu, 23 Jun 2022 10:23:26 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [External] Re: [PATCH v2] sched: RT bandwidth interface for cgroup unified hierarchy Content-Language: en-US To: =?UTF-8?Q?Michal_Koutn=c3=bd?= Cc: rdunlap@infradead.org, mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, tj@kernel.org, lizefan.x@bytedance.com, hannes@cmpxchg.org, corbet@lwn.net, cgroups@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org References: <20220622015557.7497-1-zhouchengming@bytedance.com> <20220622173929.GA669@blackbody.suse.cz> From: Chengming Zhou In-Reply-To: <20220622173929.GA669@blackbody.suse.cz> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Michal, On 2022/6/23 01:39, Michal Koutný wrote: > Hello Chengming. > > On Wed, Jun 22, 2022 at 09:55:57AM +0800, Chengming Zhou wrote: >> We need to run RT threads in cgroup unified hierarchy, but we can't >> since the default rt_bandwidth.rt_runtime of non-root task_group is 0 >> and we haven't interface to update it. > > Do you really want to make use of group RT schedulling > (CONFIG_RT_GROUP_SCHED) or just be able to run RT threads in the unified > hieararchy with cpu controller enabled? > The latter could meet our current needs I think, but it would be better that we can put a max limit on the task_group in case multiple groups need to run RT processes. > Those are two different use cases, the former is more complex and it's a > reason why v2 doesn't expose the RT attributes (yet). > The latter is typically achieved by unsetting CONFIG_RT_GROUP_SCHED (and > relying on the global rt_runtime limit). > I don't know why v2 differ from v1 in the RT bandwidth control.. Is there some links of explanation? (CFS bandwidth control can work on v2 now.) If the problem can't be solved, we have to unset CONFIG_RT_GROUP_SCHED. Thanks. > Thanks, > Michal