From: SF Markus Elfring <elfring@users.sourceforge.net>
To: Fabian Frederick <fabf@skynet.be>,
Kai Bankett <chaosman@ontika.net>,
kernel-janitors@vger.kernel.org
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: [PATCH 1/2] fs-qnx6: Delete an error message for a failed memory allocation in qnx6_mmi_fill_super()
Date: Wed, 16 Aug 2017 18:14:52 +0200 [thread overview]
Message-ID: <888c8fc4-11bb-008b-7396-be4fd2a695a7@users.sourceforge.net> (raw)
In-Reply-To: <55b824fd-3f8a-4ca6-583f-27f584cd237a@users.sourceforge.net>
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Wed, 16 Aug 2017 17:07:26 +0200
Omit an extra message for a memory allocation failure in this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
fs/qnx6/super_mmi.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/fs/qnx6/super_mmi.c b/fs/qnx6/super_mmi.c
index 62aaf3e3126a..fdcfc99e2db6 100644
--- a/fs/qnx6/super_mmi.c
+++ b/fs/qnx6/super_mmi.c
@@ -100,10 +100,8 @@ struct qnx6_super_block *qnx6_mmi_fill_super(struct super_block *s, int silent)
}
qsb = kmalloc(sizeof(*qsb), GFP_KERNEL);
- if (!qsb) {
- pr_err("unable to allocate memory.\n");
+ if (!qsb)
goto out;
- }
if (fs64_to_cpu(sbi, sb1->sb_serial) >
fs64_to_cpu(sbi, sb2->sb_serial)) {
--
2.14.0
next prev parent reply other threads:[~2017-08-16 16:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-16 16:13 [PATCH 0/2] fs-qnx6: Adjustments for qnx6_mmi_fill_super() SF Markus Elfring
2017-08-16 16:14 ` SF Markus Elfring [this message]
2017-08-16 16:15 ` [PATCH 2/2] fs-qnx6: Less checks in qnx6_mmi_fill_super() after error detection SF Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=888c8fc4-11bb-008b-7396-be4fd2a695a7@users.sourceforge.net \
--to=elfring@users.sourceforge.net \
--cc=chaosman@ontika.net \
--cc=fabf@skynet.be \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome