From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759087AbdAFLtZ (ORCPT ); Fri, 6 Jan 2017 06:49:25 -0500 Received: from mx1.redhat.com ([209.132.183.28]:46678 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754124AbdAFLsB (ORCPT ); Fri, 6 Jan 2017 06:48:01 -0500 Subject: Re: [PATCH v6 07/18] iommu: Implement reserved_regions iommu-group sysfs file To: Joerg Roedel References: <1483643086-2883-1-git-send-email-eric.auger@redhat.com> <1483643086-2883-8-git-send-email-eric.auger@redhat.com> <20170106110039.GL17255@8bytes.org> Cc: eric.auger.pro@gmail.com, christoffer.dall@linaro.org, marc.zyngier@arm.com, robin.murphy@arm.com, alex.williamson@redhat.com, will.deacon@arm.com, tglx@linutronix.de, jason@lakedaemon.net, linux-arm-kernel@lists.infradead.org, kvm@vger.kernel.org, drjones@redhat.com, linux-kernel@vger.kernel.org, pranav.sawargaonkar@gmail.com, iommu@lists.linux-foundation.org, punit.agrawal@arm.com, diana.craciun@nxp.com, gpkulkarni@gmail.com, shankerd@codeaurora.org, bharat.bhushan@nxp.com, geethasowjanya.akula@gmail.com From: Auger Eric Message-ID: <888d3750-817c-77d1-8154-e77cf8c3ad4b@redhat.com> Date: Fri, 6 Jan 2017 12:46:05 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <20170106110039.GL17255@8bytes.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Fri, 06 Jan 2017 11:46:12 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Joerg, On 06/01/2017 12:00, Joerg Roedel wrote: > On Thu, Jan 05, 2017 at 07:04:35PM +0000, Eric Auger wrote: >> + list_for_each_entry_safe(region, next, &group_resv_regions, list) { >> + str += sprintf(str, "0x%016llx 0x%016llx\n", >> + (long long int)region->start, >> + (long long int)(region->start + >> + region->length - 1)); >> + kfree(region); >> + } > > I think it also makes sense to report the type of the reserved region. What is the best practice in that case? Shall we put the type enum values as strings such as: - direct - nomap - msi and document that in Documentation/ABI/testing/sysfs-kernel-iommu_groups Thanks Eric > > > > Joerg > > -- > To unsubscribe from this list: send the line "unsubscribe kvm" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >