From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751941AbdARKc6 (ORCPT ); Wed, 18 Jan 2017 05:32:58 -0500 Received: from smtprelay4.synopsys.com ([198.182.47.9]:49295 "EHLO smtprelay.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751204AbdARKc4 (ORCPT ); Wed, 18 Jan 2017 05:32:56 -0500 Subject: Re: [RFC/RFT PATCH 3/4] drm/bridge: dw-hdmi: Enable CSC even for DVI To: Neil Armstrong , , References: <1484656294-6140-1-git-send-email-narmstrong@baylibre.com> <1484656294-6140-4-git-send-email-narmstrong@baylibre.com> CC: , , , From: Jose Abreu Message-ID: <888e2dfb-db21-04b5-90d3-9f917052f70a@synopsys.com> Date: Wed, 18 Jan 2017 10:22:24 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <1484656294-6140-4-git-send-email-narmstrong@baylibre.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.107.19.90] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Neil, On 17-01-2017 12:31, Neil Armstrong wrote: > If the input pixel format is not RGB, the CSC must be enabled in order to > provide valid pixel to DVI sinks. > This patch removes the hdmi only dependency on the CSC enabling. > > Signed-off-by: Neil Armstrong I was going to say that you should make sure the output colorspace is RGB or else DVI will fail to work, but I just noticed the output colorspace is fixed in the code to RGB. Though, that may change in the future. Reviewed-by: Jose Abreu Best regards, Jose Miguel Abreu > --- > drivers/gpu/drm/bridge/dw-hdmi.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/bridge/dw-hdmi.c b/drivers/gpu/drm/bridge/dw-hdmi.c > index 923e250..8a6a183 100644 > --- a/drivers/gpu/drm/bridge/dw-hdmi.c > +++ b/drivers/gpu/drm/bridge/dw-hdmi.c > @@ -1331,8 +1331,8 @@ static void dw_hdmi_enable_video_path(struct dw_hdmi *hdmi) > hdmi_writeb(hdmi, clkdis, HDMI_MC_CLKDIS); > } > > - /* Enable color space conversion if needed (for HDMI sinks only). */ > - if (hdmi->sink_is_hdmi && is_color_space_conversion(hdmi)) > + /* Enable color space conversion if needed */ > + if (is_color_space_conversion(hdmi)) > hdmi_writeb(hdmi, HDMI_MC_FLOWCTRL_FEED_THROUGH_OFF_CSC_IN_PATH, > HDMI_MC_FLOWCTRL); > else