From: Joe Perches <joe@perches.com>
To: "Srivatsa S. Bhat" <srivatsa@csail.mit.edu>,
linux-kernel@vger.kernel.org,
Steven Rostedt <rostedt@goodmis.org>
Cc: amakhalov@vmware.com, akaher@vmware.com, anishs@vmware.com,
bordoloih@vmware.com, srivatsab@vmware.com
Subject: Re: [PATCH 3/3] tracing/hwlat: Fix a few trivial nits
Date: Thu, 10 Oct 2019 14:34:55 -0700 [thread overview]
Message-ID: <889073497c3f8bed25acb0015049837141a3b688.camel@perches.com> (raw)
In-Reply-To: <157073346821.17189.8946944856026592247.stgit@srivatsa-ubuntu>
On Thu, 2019-10-10 at 11:51 -0700, Srivatsa S. Bhat wrote:
> Update the source file name in the comments, and fix a grammatical
> error.
[]
> diff --git a/kernel/trace/trace_hwlat.c b/kernel/trace/trace_hwlat.c
[]
> @@ -1,6 +1,6 @@
> // SPDX-License-Identifier: GPL-2.0
> /*
> - * trace_hwlatdetect.c - A simple Hardware Latency detector.
> + * trace_hwlat.c - A simple Hardware Latency detector.
trivia:
Generally it's not useful to have the filename in a comment
so I think maybe delete the "trace_hwlatdetect.c - ".
btw:
$ git ls-files -- '*.[ch]' | \
while read file ; do git grep $file -- $file; done | wc -l
About 5% (2500 of the 50000 or so) *.[ch] files in the kernel
source tree contain their filename in a comment, so it's
certainly not that unusual.
next prev parent reply other threads:[~2019-10-10 21:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-10 18:50 [PATCH 1/3] tracing/hwlat: Report total time spent in all NMIs during the sample Srivatsa S. Bhat
2019-10-10 18:51 ` [PATCH 2/3] tracing/hwlat: Don't ignore outer-loop duration when calculating max_latency Srivatsa S. Bhat
2019-10-10 18:51 ` [PATCH 3/3] tracing/hwlat: Fix a few trivial nits Srivatsa S. Bhat
2019-10-10 21:34 ` Joe Perches [this message]
2019-10-10 21:44 ` Steven Rostedt
2019-10-14 19:24 ` Steven Rostedt
2019-10-14 19:26 ` Srivatsa S. Bhat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=889073497c3f8bed25acb0015049837141a3b688.camel@perches.com \
--to=joe@perches.com \
--cc=akaher@vmware.com \
--cc=amakhalov@vmware.com \
--cc=anishs@vmware.com \
--cc=bordoloih@vmware.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=srivatsa@csail.mit.edu \
--cc=srivatsab@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®