From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2BC22318ED1 for ; Fri, 30 Jan 2026 14:49:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769784560; cv=none; b=rPcSj0gcwuR1IzFmhT/cCaf6SGQuPiUvp1pHyeo3D5xY/ML+J+Q8pp+FJnOVVIvP0dYfpMfydUt2Yxf+oeYmWbGvyQxshZm/Cbd19TsHUwm+zNgU6KlCF55giAwVH21BxMmobiNUo0Md9OOdZBgEoGarl1FwMgXCYRGKqRuHzBA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769784560; c=relaxed/simple; bh=tfZk+5KNNEIOJgNbg0qag/Nul+kpF2IKQPhVCoBQD6U=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=jo+6unAgjvDCDbSe+Nz1E876nRrdy4Tjq5nWaywHTDeSydc3qzJU/9/Xk9Q2ktEMQdPn9iPvr/S18Lot4PVGI0s7YIJolpd1K+aZ6FoabGuPghCq0ufON0T44bF55bZCHg1K2Uha63ysdgh472HLD+fGs14Lz72vKTZ21lYBLqc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=XJJPHXgk; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=ERScmCGW; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="XJJPHXgk"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="ERScmCGW" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60UAZqxj1022153 for ; Fri, 30 Jan 2026 14:49:18 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= JwTwhgSyzqJLo63i9kwRYod4/mBwRdp48FEKlR9vabc=; b=XJJPHXgkE7AFnUgQ LaMRZ5LJWwuQRZgrNpI8ZgUZKxAJKJ9PEv48TWDwUgQIzwuqt7xGhwa8sOUT4KYt onnR+Quc/RrNXFABDQ6LbetxDbNv9fi1/xtgIdjAONecwl70UyYRGBFB3VBuUxd4 TkrMhAPr1uokJMvJje2QBVBAERIdg35+4W7tN5K1PMYf3EWRKxU9gxCP3Zkpw+AY L17F1LePoBl5lg7GZ9utfAzpW+DnHTBxgVfrBDMV7t+cWCzDsgUgJcm6tLsx+oAb 5F875S/xlKU3eJ1NeA9toZBqa7uMHbbAiAkppKDR+wGtf9jYHDMvCF43htXth9wV ve5oMg== Received: from mail-dl1-f72.google.com (mail-dl1-f72.google.com [74.125.82.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4c0e3kay1k-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 30 Jan 2026 14:49:18 +0000 (GMT) Received: by mail-dl1-f72.google.com with SMTP id a92af1059eb24-12338d13f2cso1612462c88.1 for ; Fri, 30 Jan 2026 06:49:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1769784557; x=1770389357; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=JwTwhgSyzqJLo63i9kwRYod4/mBwRdp48FEKlR9vabc=; b=ERScmCGWTi6z71E9mN/E+TekdZioVidS/0MqrpYEhrJPfmkH9sNJW1ENl7D04SKSKX NPBFRn6FXQVqI3YGWolOeT+cE/+kFltAtXymcDMifTZygI2p5I8wLzsATbkGtulXJtKZ SKiRkcMMDXQjVRPFnOYU9YBCGOOqQoHM6eRoAnCh/FbykI34BKjnEMlG9Rp7qoam7JWA 82eYTJhIp0eQfZClT94z8Kx6kbB4VwN0s39SIdVZ+sS41DhUqXEDYIyW03gk2ikAm2+n WFyvUSlcM5aSvM7IVrXlPgkgtjIVR0VXrGVpSrxJPGbW/bH1Dq96QBcNsq4NE5/nBGNy mNtg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769784557; x=1770389357; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=JwTwhgSyzqJLo63i9kwRYod4/mBwRdp48FEKlR9vabc=; b=Eh/CMHyExw8IexDrELCop2qlTsJLwlPr5QAde1nan7S4H0wWqaSqmvedpwM8iAcG4e yUnzuI5B7S+OueP8msJ/DOT8rUdCIYhCJKGL6TXSaXlecmQEDweSCVkoM0tdCNvbOUmk RadjJchkISeqa7nWInUGQ6QJfBdVnbZib/tWjNLkcA7O2wb/GLRNgIIGCzgnrZ8J04Kk /SLz1bas9lyULT/EfvsnNSHs+vbOA/OZrY9Y4keuW/vBVrohsW0sYHxAX9SrelwLmQtl R6CPTN1YSN1LUzt7jx1x8Se5Moa/GH/FR/QMumyJ5c8nZ/+5xHExi8ahNQriCK1m9T+f MJKA== X-Forwarded-Encrypted: i=1; AJvYcCVLEEPefPcfCTq6UO0hJpxmC5IaTTEe3lOfpG68fB8cnEHANZFoCMxB9yIivOldN8Uqa7IuIgnnv1hW54A=@vger.kernel.org X-Gm-Message-State: AOJu0YznJ2VhktZpoAgXoEZ6rckSaaTdfKk5Gin9M5k/1gXhDvxs4Dbw x0aQowqD4vqNSLx1Ea9S0PYyRKnK0KsNhK1SdBXamINv0hpc67vFhttvCiEJlYATShh8YOn8LZc ZQiwtKxUl+Ckm/zMPZXQdTJZBKlYFzz+X5gujySStYMJZ41O/s0ghwocdIUkGtYiCKuI= X-Gm-Gg: AZuq6aJqgD4Ge42cpNt6i+a2V/NY+ylIE6wnlNH4/g9me2iYVr/edZd7VdBroEeHjhy KX9vfm/L/1OsRQiHAKBs66puq8VSJXk0w3X6I8cDbD8dgY5smNHDM9777cwr1wKiZS1t76LRLzX WEVKUq6KRxP1464PY8dZkhHkYYZbbdnsn4646haC3W2nblCx0Ys0XQQcwqy/l8Nrwrh0NKiMIBk OiBfc5Ft9x5VqndK4DFdbq9Hv6SrS33c0iNlzWI7nq9277/Hf7Dgdi4jIdtor3hprf0oAt4SskE Amj5Zj50+iypGLpB3N2VZAJ9qWVgwZEhS4RF+bhBXQXFvpW5HsMQqKdG+OmEOTX1pRipMGBPqlm zmRpVlsLpQ19Y25TxQeBDGR9PXjhp05jJkvdnguJDdC7FsQ== X-Received: by 2002:a05:7022:e25:b0:124:a93c:44f0 with SMTP id a92af1059eb24-125c1021329mr1305166c88.47.1769784556871; Fri, 30 Jan 2026 06:49:16 -0800 (PST) X-Received: by 2002:a05:7022:e25:b0:124:a93c:44f0 with SMTP id a92af1059eb24-125c1021329mr1305147c88.47.1769784556232; Fri, 30 Jan 2026 06:49:16 -0800 (PST) Received: from [192.168.1.3] ([122.177.244.129]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-124a9d6b740sm13384721c88.2.2026.01.30.06.49.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 30 Jan 2026 06:49:15 -0800 (PST) Message-ID: <8892020f-b674-49fd-8715-aaa364ee9e54@oss.qualcomm.com> Date: Fri, 30 Jan 2026 20:19:09 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/2] arm64: dts: qcom: talos: Flatten usb controller nodes To: Konrad Dybcio Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Dmitry Baryshkov References: <20260128062720.437712-1-krishna.kurapati@oss.qualcomm.com> <20260128062720.437712-2-krishna.kurapati@oss.qualcomm.com> <2324aa41-6b2a-41ca-9f97-7a5b5e0f575f@oss.qualcomm.com> Content-Language: en-US From: Krishna Kurapati In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Authority-Analysis: v=2.4 cv=VI3QXtPX c=1 sm=1 tr=0 ts=697cc4ee cx=c_pps a=bS7HVuBVfinNPG3f6cIo3Q==:117 a=cyLKOHUn2kgKoBmswTDEEg==:17 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=RdQPRE3GmD7CddwFaIoA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=vBUdepa8ALXHeOFLBtFW:22 X-Proofpoint-GUID: s8k_0XBrYmMKK_LYwDQ2vBwMEqkgJzHZ X-Proofpoint-ORIG-GUID: s8k_0XBrYmMKK_LYwDQ2vBwMEqkgJzHZ X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTMwMDEyMSBTYWx0ZWRfXxhk6D6rY1Jd8 AZd1Mu69a6gZ6IW0NW9zkgP1LOMUgeYsVbqm23cdijqL2p0PKct2xood6L+AXmrXdZ+TwYOuQVW E9vt25+0pQ3UvebiPpBeJpaa+VhbOMHzYTQb1GeU1qPpZXIQ+BwLMVLV6NnL5OfI8slcWqG05xy 9Ai+sIcHDysE+7Yy11MF+OBA2h70JmY9l9jHy7wnuNoVZR0Q7JIkYd8pTARqiOC05BR3CDdyjQR JXkq1ALl5pOq9lEGAIKlxsVq+Be4gJHtCzFbTKblp/J8GBTv/j9BJ9C7H/t1D4p+febB2MwiCVM q3FwIxxz/f3m4E/7lh6u7yiy8P0eXnLb4NirfnOQQZ3YsFYp/zMCd303V8WBulbDHqJJdcAA6zJ My3DWd8FxfvKCWAftjaIGxA2P/cBnVVK3h+nqdNvOyYe4z1bhZqaOpUxEh5xEeEJl/voTLLHbrc 90E4ibSkDFhGnhjQOpw== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-01-30_02,2026-01-29_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 impostorscore=0 phishscore=0 bulkscore=0 priorityscore=1501 adultscore=0 clxscore=1015 lowpriorityscore=0 suspectscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2601300121 On 1/29/2026 4:58 PM, Konrad Dybcio wrote: > On 1/28/26 5:09 PM, Krishna Kurapati wrote: >> >> >> On 1/28/2026 4:01 PM, Konrad Dybcio wrote: >>> On 1/28/26 7:27 AM, Krishna Kurapati wrote: >>>> Flatten usb controller nodes and update to using latest bindings >>>> and flattened driver approach. >>>> >>>> Reviewed-by: Dmitry Baryshkov >>>> Signed-off-by: Krishna Kurapati >>>> --- >>> >>> Have you checked whether this brings about the same crash-on-suspend >>> issue as it does on Hamoa? >>> >>> https://lore.kernel.org/linux-arm-msm/71c15a78-7a50-4913-b677-e5308fcabfad@packett.cool/ >>> >> >> Hi Konrad, >> >>  Yes, I did check system suspend use case after flattening and there is no crash seen. >> >>  The only issue I observed (both before and after flattening) is that waking up from bus suspend, there is an enumeration failure on second port in host mode, and an xHCI CMD_RUN timeout occurs. The issue is gone if we keep controller GDSC flags as RET_ON (not the right solution though). But this issue has nothing to do with flattening. I will sync up with clocks team and try to fix that host mode issue. > > diff --git a/arch/arm64/boot/dts/qcom/talos.dtsi b/arch/arm64/boot/dts/qcom/talos.dtsi > index 75716b4a58d6..7e7f4eae8a98 100644 > --- a/arch/arm64/boot/dts/qcom/talos.dtsi > +++ b/arch/arm64/boot/dts/qcom/talos.dtsi > @@ -4559,7 +4559,7 @@ usb_2: usb@a8f8800 { > <&gcc GCC_AGGRE_USB2_SEC_AXI_CLK>, > <&gcc GCC_USB20_SEC_SLEEP_CLK>, > <&gcc GCC_USB20_SEC_MOCK_UTMI_CLK>, > - <&gcc GCC_USB2_PRIM_CLKREF_CLK>; > + <&gcc GCC_USB3_SEC_CLKREF_CLK>; > > I tried this out but it didn't work. Regards, Krishna,