From: Dinh Nguyen <dinguyen@kernel.org>
To: Rob Herring <robh@kernel.org>
Cc: Russell King <linux@armlinux.org.uk>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ARM: socfpga: Explicitly include correct DT includes
Date: Tue, 22 Aug 2023 21:11:37 -0500 [thread overview]
Message-ID: <88964b2e-105a-b74b-ec3a-859de83b90a9@kernel.org> (raw)
In-Reply-To: <CAL_JsqKF_ncQ3KNOHXugGJQO-GCE4coUeOmhQXd3AkneTQv_7A@mail.gmail.com>
On 8/22/23 17:29, Rob Herring wrote:
> On Thu, Jul 20, 2023 at 4:29 PM Dinh Nguyen <dinguyen@kernel.org> wrote:
>>
>>
>>
>> On 7/17/23 17:54, Rob Herring wrote:
>>> The DT of_device.h and of_platform.h date back to the separate
>>> of_platform_bus_type before it was merged into the regular platform bus.
>>> As part of that merge prepping Arm DT support 13 years ago, they
>>> "temporarily" include each other. They also include platform_device.h
>>> and of.h. As a result, there's a pretty much random mix of those include
>>> files used throughout the tree. In order to detangle these headers and
>>> replace the implicit includes with struct declarations, users need to
>>> explicitly include the correct includes.
>>>
>>
>> Applied!
>
> Did you really? Doesn't look like this is in linux-next.
I did, but haven't sent a PR to armsoc. Will do it now, thanks for the
reminder!
Dinh
prev parent reply other threads:[~2023-08-23 2:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-17 22:54 Rob Herring
2023-07-20 21:29 ` Dinh Nguyen
2023-08-22 22:29 ` Rob Herring
2023-08-23 2:11 ` Dinh Nguyen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=88964b2e-105a-b74b-ec3a-859de83b90a9@kernel.org \
--to=dinguyen@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®