From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91AE3C433FE for ; Fri, 18 Nov 2022 15:34:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242300AbiKRPeC (ORCPT ); Fri, 18 Nov 2022 10:34:02 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49902 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242302AbiKRPd5 (ORCPT ); Fri, 18 Nov 2022 10:33:57 -0500 Received: from aposti.net (aposti.net [89.234.176.197]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F1C7527153; Fri, 18 Nov 2022 07:33:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=crapouillou.net; s=mail; t=1668785634; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=H99gifSUAX63SHB4wCOwUdzC9A4Qilfu6shSvTJT/Do=; b=GCiLfoGCsrJV1b8eakZkdc7V+eN/S88H24/XYoaqACaFIbKl+QvmUfkTvecq+5zc1vYnHp 1UQJ2nBjiJRoc5sWCyiys+8cMAWuYq/IZIRPZIR8W+jGDjOfgDALYZa7TV/YO/H/EV8ve8 28qttYGe/6cZzWvE+o2a5FEuKSiunHc= Date: Fri, 18 Nov 2022 15:33:44 +0000 From: Paul Cercueil Subject: Re: [PATCH 1/3] net: davicom: dm9000: switch to using gpiod API To: Dmitry Torokhov Cc: "David S. Miller" , Andrew Lunn , Heiner Kallweit , Linus Walleij , Bartosz Golaszewski , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Message-Id: <88VJLR.GYSEKGBPLGZC1@crapouillou.net> In-Reply-To: <20220906204922.3789922-1-dmitry.torokhov@gmail.com> References: <20220906204922.3789922-1-dmitry.torokhov@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1; format=flowed Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Dmitry, Le mar. 6 sept. 2022 =E0 13:49:20 -0700, Dmitry Torokhov=20 a =E9crit : > This patch switches the driver away from legacy gpio/of_gpio API to > gpiod API, and removes use of of_get_named_gpio_flags() which I want=20 > to > make private to gpiolib. >=20 > Signed-off-by: Dmitry Torokhov > --- > drivers/net/ethernet/davicom/dm9000.c | 26 ++++++++++++++------------ > 1 file changed, 14 insertions(+), 12 deletions(-) >=20 > diff --git a/drivers/net/ethernet/davicom/dm9000.c=20 > b/drivers/net/ethernet/davicom/dm9000.c > index 77229e53b04e..c85a6ebd79fc 100644 > --- a/drivers/net/ethernet/davicom/dm9000.c > +++ b/drivers/net/ethernet/davicom/dm9000.c > @@ -28,8 +28,7 @@ > #include > #include > #include > -#include > -#include > +#include >=20 > #include > #include > @@ -1421,8 +1420,7 @@ dm9000_probe(struct platform_device *pdev) > int iosize; > int i; > u32 id_val; > - int reset_gpios; > - enum of_gpio_flags flags; > + struct gpio_desc *reset_gpio; > struct regulator *power; > bool inv_mac_addr =3D false; > u8 addr[ETH_ALEN]; > @@ -1442,20 +1440,24 @@ dm9000_probe(struct platform_device *pdev) > dev_dbg(dev, "regulator enabled\n"); > } >=20 > - reset_gpios =3D of_get_named_gpio_flags(dev->of_node, "reset-gpios",=20 > 0, > - &flags); > - if (gpio_is_valid(reset_gpios)) { > - ret =3D devm_gpio_request_one(dev, reset_gpios, flags, > - "dm9000_reset"); > + reset_gpio =3D devm_gpiod_get_optional(dev, "reset", GPIOD_OUT_HIGH); > + ret =3D PTR_ERR_OR_ZERO(reset_gpio); > + if (ret) { > + dev_err(dev, "failed to request reset gpio: %d\n", ret); > + goto out_regulator_disable; > + } > + > + if (reset_gpio) { > + ret =3D gpiod_set_consumer_name(reset_gpio, "dm9000_reset"); > if (ret) { > - dev_err(dev, "failed to request reset gpio %d: %d\n", > - reset_gpios, ret); > + dev_err(dev, "failed to set reset gpio name: %d\n", > + ret); > goto out_regulator_disable; > } >=20 > /* According to manual PWRST# Low Period Min 1ms */ > msleep(2); > - gpio_set_value(reset_gpios, 1); > + gpiod_set_value_cansleep(reset_gpio, 0); Why is that 1 magically turned into a 0? On my CI20 board I can't get the DM9000 chip to probe correctly with=20 this patch (it fails to read the ID). If I revert this patch then everything works fine. Cheers, -Paul > /* Needs 3ms to read eeprom when PWRST is deasserted */ > msleep(4); > } > -- > 2.37.2.789.g6183377224-goog >=20