mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Woody Suwalski <terraluna977@gmail.com>
To: Igor Mammedov <imammedo@redhat.com>, linux-kernel@vger.kernel.org
Cc: bhelgaas@google.com, linux-pci@vger.kernel.org, mst@redhat.com
Subject: Re: [RFC 0/3] acpipcihp: fix kernel crash on 2nd resume
Date: Tue, 25 Jul 2023 09:51:53 -0400	[thread overview]
Message-ID: <88a06e12-600a-a4bd-f216-44753965ce48@gmail.com> (raw)
In-Reply-To: <20230725113938.2277420-1-imammedo@redhat.com>

[-- Attachment #1: Type: text/plain, Size: 1703 bytes --]

Igor Mammedov wrote:
> Changelog:
>    * split out debug patch into a separate one with extra printk added
>    * fixed inverte bus->self check (probably a reason why it didn't work before)
>
>
> 1/3 debug patch
> 2/3 offending patch
> 3/3 potential fix
>    
> I added more files to trace, add following to kernel CLI
>     dyndbg="file drivers/pci/access.c +p; file drivers/pci/hotplug/acpiphp_glue.c +p; file drivers/pci/bus.c +p; file drivers/pci/pci.c +p; file drivers/pci/setup-bus.c +p; file drivers/acpi/bus.c +p" ignore_loglevel
>
> should be applied on top of
>     e8afd0d9fccc PCI: pciehp: Cancel bringup sequence if card is not present
>
> apply a patch one by one and run testcase + capture dmesg after each patch
> one shpould endup with 3 dmesg to ananlyse
>   1st - old behaviour - no crash
>   2nd - crash
>   3rd - no crash hopefully
>
> Igor Mammedov (3):
>    acpiphp: extra debug hack
>    PCI: acpiphp: Reassign resources on bridge if necessary
>    acpipcihp: use __pci_bus_assign_resources() if bus doesn't have bridge
>
>   drivers/pci/hotplug/acpiphp_glue.c | 23 ++++++++++++++++++-----
>   1 file changed, 18 insertions(+), 5 deletions(-)
>
Actually applying patch1 is already creating the crash (why???), hence I 
have added also dmesg-6.5-0.txt which shows a working condition based on 
git e8afd0d9fccc level (acpiphp_glue in kernel 6.4)

Patch3 did not fix the issue, it seems that the culprit is somewhere 
else triggered by  "benign" patch1 :-(

Also note about the trigger description in patch3: the dmesg trace on 
Inspiron laptop is collected after the first wake from suspend to ram. 
The consecutive  attempt to sleep results in a frozen system.

Thanks, Woody


[-- Attachment #2: rfc.tar.xz --]
[-- Type: application/x-xz, Size: 35540 bytes --]

  parent reply	other threads:[~2023-07-25 13:52 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-25 11:39 Igor Mammedov
2023-07-25 11:39 ` [RFC 1/3] acpiphp: extra debug hack Igor Mammedov
2023-07-25 15:12   ` [RFC v2 " Igor Mammedov
2023-07-25 11:39 ` [RFC 2/3] PCI: acpiphp: Reassign resources on bridge if necessary Igor Mammedov
2023-07-25 11:39 ` [RFC 3/3] acpipcihp: use __pci_bus_assign_resources() if bus doesn't have bridge Igor Mammedov
2023-07-25 13:51 ` Woody Suwalski [this message]
2023-07-25 15:19   ` [RFC 0/3] acpipcihp: fix kernel crash on 2nd resume Igor Mammedov
2023-07-25 15:59     ` Woody Suwalski
2023-07-26  8:07       ` Igor Mammedov
2023-07-25 15:41   ` Woody Suwalski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=88a06e12-600a-a4bd-f216-44753965ce48@gmail.com \
    --to=terraluna977@gmail.com \
    --cc=bhelgaas@google.com \
    --cc=imammedo@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=mst@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®