From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755466AbcHYJTl (ORCPT ); Thu, 25 Aug 2016 05:19:41 -0400 Received: from mout.web.de ([212.227.15.3]:62840 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752142AbcHYJTj (ORCPT ); Thu, 25 Aug 2016 05:19:39 -0400 To: linux-edac@vger.kernel.org, x86@kernel.org, Borislav Petkov , "H. Peter Anvin" , Ingo Molnar , Thomas Gleixner , Tony Luck Cc: LKML , kernel-janitors@vger.kernel.org, Julia Lawall , Paolo Bonzini From: SF Markus Elfring Subject: [PATCH] x86/mce: Use kmalloc_array() in mce_chrdev_read() Message-ID: <88a63817-f601-28ce-ed2f-ffeb28512528@users.sourceforge.net> Date: Thu, 25 Aug 2016 11:17:06 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:eCdlxMCVYsH3tLqrEwvyroAFFtVNmaFB7nkWb0UoEBvxlCo8QY8 07TC0u7i6p35dJMF4qqA15iPFjEFbLqAuT/M+YozbHcnCRDP7sbYdD5FD7l5fSiFGd8DJj2 G3h7r4WJgLBfLmp/+Lblt00ZeZo1+o0cCrlEXftQEsdXh6sXCCHaIyxmeqdeWGpB6U2d5si iMuCKl/CIxzv03VLCVanA== X-UI-Out-Filterresults: notjunk:1;V01:K0:H8NwJmvAatw=:8VFX3x4tEdta7q7PKX9kKa B9RJLQNOzFykTQ3Y8g7nGOwTVoYmX1N9vCBdNYhU4F/7DhqLvOzBUCQz5zQ1O2+0vMTuli3nm QqLjf+wnlIn7OiuOccrHXzwCCre+ZDDcLxyX9UL1uuu+PH3Gj/CUsKNDR5tnOflErczHhv2ae pTkFWldK1nAkQP8psdImF4uny3sUM3UOeeulq87FoRxIDMtI8+yg1fJ/XcStZZbBh8C34ThBG QgBl2VI4ugJan3otkNWjt9irF6SCIn9p/wqzk3AprQAiwvcTLXBuz3SbXhC5icEqIt/AT0BNx q2wdB305UksmT41L1T5cbRmHp2chOjpe/j1iJT+FJJBA0XOeA8xB5dvVVGyzlM9BQ9ApIFTJS 42SmykS7urV5+9tI3iiFKmDkYIhQsFCOuqv4SCIKXng0EBvSo62O2rClrodTvrgYbUL7URUpS StaFASDalyQIhQW9Y8X4QqmF0sFMbUW358xtGS5xapKAgWeTRfF/KN2ViakGgzdKIz7tNnYvz xPcbT/hgOwzE+TRgX5FE9jWQ4eD4EVTHF78aZRMIJ6//ZzjgAD85tr/g+Cuh0TniYuGe10jn/ ArsrkNhHYUTqAAquLAhGjxhI7UjzTZ8WbJemrcy7hDCiFe5J4fdcCSOCT960QFY+hSUqyd8ou fSxYO3gTC5+FPbkI1dr49Qh6srq517LD9ncyOvDpqrMRJM2bVHwORwP7tzzbLN0V8dfMZsd0i bf7m/lKFA3BuDHBoZU97KQO/ceC+nMTQTTsIKmmwoMWoC7rNKZfjoxNDIlwdOSuQ32kQdl0K0 TQ0DjvVGgoN8z/RgXqqTKt4PO3vFQ== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Thu, 25 Aug 2016 11:00:05 +0200 * A multiplication for the size determination of a memory allocation indicated that an array data structure should be processed. Thus reuse the corresponding function "kmalloc_array". This issue was detected by using the Coccinelle software. * Replace the specification of a data type by a pointer dereference to make the corresponding size determination a bit safer according to the Linux coding style convention. Signed-off-by: Markus Elfring --- arch/x86/kernel/cpu/mcheck/mce.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/kernel/cpu/mcheck/mce.c b/arch/x86/kernel/cpu/mcheck/mce.c index 79d8ec8..0bc831d 100644 --- a/arch/x86/kernel/cpu/mcheck/mce.c +++ b/arch/x86/kernel/cpu/mcheck/mce.c @@ -1901,7 +1901,7 @@ static ssize_t mce_chrdev_read(struct file *filp, char __user *ubuf, unsigned prev, next; int i, err; - cpu_tsc = kmalloc(nr_cpu_ids * sizeof(long), GFP_KERNEL); + cpu_tsc = kmalloc_array(nr_cpu_ids, sizeof(*cpu_tsc), GFP_KERNEL); if (!cpu_tsc) return -ENOMEM; -- 2.9.3