From: Shile Zhang <shile.zhang@linux.alibaba.com>
To: Joerg Roedel <jroedel@suse.de>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/vmalloc: Fix regression caused by needless vmalloc_sync_all()
Date: Fri, 15 Nov 2019 09:06:46 +0800 [thread overview]
Message-ID: <88a7e8d5-84bc-46b1-573e-9da18218ef57@linux.alibaba.com> (raw)
In-Reply-To: <20191114171231.GA21753@suse.de>
On 2019/11/15 01:12, Joerg Roedel wrote:
> On Wed, Nov 13, 2019 at 05:55:30PM +0800, Shile Zhang wrote:
>> +#if defined(CONFIG_X86_32) && defined(CONFIG_X86_PAE)
>> /*
>> * First make sure the mappings are removed from all page-tables
>> * before they are freed.
>> + *
>> + * This is only needed on x86-32 with !SHARED_KERNEL_PMD, which is
>> + * the case on a PAE kernel with PTI enabled.
>> */
>> - vmalloc_sync_all();
>> + if (!SHARED_KERNEL_PMD && boot_cpu_has(X86_FEATURE_PTI))
>> + vmalloc_sync_all();
>> +#endif
> I already submitted another fix for this quite some time ago:
>
> https://lore.kernel.org/lkml/20191009124418.8286-1-joro@8bytes.org/
>
> Regards,
>
> Joerg
Oh, sorry for I missed that, good job and thanks for your work!
prev parent reply other threads:[~2019-11-15 1:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20191113095530.228959-1-shile.zhang@linux.alibaba.com>
[not found] ` <20191113131237.1757241fb0c458484c2b19aa@linux-foundation.org>
2019-11-14 0:54 ` Shile Zhang
[not found] ` <20191114135641.GA1356@dhcp22.suse.cz>
2019-11-14 14:40 ` Shile Zhang
2019-11-14 17:14 ` Joerg Roedel
[not found] ` <20191114171231.GA21753@suse.de>
2019-11-15 1:06 ` Shile Zhang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=88a7e8d5-84bc-46b1-573e-9da18218ef57@linux.alibaba.com \
--to=shile.zhang@linux.alibaba.com \
--cc=akpm@linux-foundation.org \
--cc=jroedel@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®