From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C16F6C433C1 for ; Tue, 30 Mar 2021 09:58:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 88926619B9 for ; Tue, 30 Mar 2021 09:58:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231426AbhC3J5w (ORCPT ); Tue, 30 Mar 2021 05:57:52 -0400 Received: from fllv0015.ext.ti.com ([198.47.19.141]:59270 "EHLO fllv0015.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231580AbhC3J5i (ORCPT ); Tue, 30 Mar 2021 05:57:38 -0400 Received: from lelv0265.itg.ti.com ([10.180.67.224]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id 12U9vRbw035815; Tue, 30 Mar 2021 04:57:27 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1617098247; bh=s1IRPKekap/KeHWrvnoB6bo3nQJKU83+bPlbVaGgETo=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=vplOSmPsHUH+BAx7CzWQ2qV1X87ui5NvGbxRMCip2+8p1LWmTVMVqHjf98YUvCDBw CH3+JDBmn2mGXihxy+fWLq7xHc8njzNLCHSGTuKCN/mvhWrnMPDC6DnhwWTNZEpMLg KZ1Vo96fQgxBRfbpQZVWHU4oayoqifY1IqQaz+GA= Received: from DFLE102.ent.ti.com (dfle102.ent.ti.com [10.64.6.23]) by lelv0265.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 12U9vQlL036489 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 30 Mar 2021 04:57:26 -0500 Received: from DFLE109.ent.ti.com (10.64.6.30) by DFLE102.ent.ti.com (10.64.6.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2; Tue, 30 Mar 2021 04:57:26 -0500 Received: from fllv0040.itg.ti.com (10.64.41.20) by DFLE109.ent.ti.com (10.64.6.30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2 via Frontend Transport; Tue, 30 Mar 2021 04:57:25 -0500 Received: from [10.250.234.46] (ileax41-snat.itg.ti.com [10.172.224.153]) by fllv0040.itg.ti.com (8.15.2/8.15.2) with ESMTP id 12U9vM2H018630; Tue, 30 Mar 2021 04:57:23 -0500 Subject: Re: [PATCH 3/4] phy: cadence-torrent: Do not configure SERDES if it's already configured To: Swapnil Kashinath Jakhade , Vinod Koul , Rob Herring , Philipp Zabel CC: "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" , Lokesh Vutla , "linux-phy@lists.infradead.org" References: <20210310155445.534-1-kishon@ti.com> <20210310155445.534-4-kishon@ti.com> From: Kishon Vijay Abraham I Message-ID: <88abbe18-8bc9-8f64-ceb5-df178a0f21d9@ti.com> Date: Tue, 30 Mar 2021 15:27:22 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Swapnil, On 18/03/21 3:25 pm, Swapnil Kashinath Jakhade wrote: > > >> -----Original Message----- >> From: Kishon Vijay Abraham I >> Sent: Wednesday, March 10, 2021 9:25 PM >> To: Kishon Vijay Abraham I ; Vinod Koul >> ; Rob Herring ; Philipp Zabel >> ; Swapnil Kashinath Jakhade >> >> Cc: linux-kernel@vger.kernel.org; devicetree@vger.kernel.org; Lokesh Vutla >> ; linux-phy@lists.infradead.org >> Subject: [PATCH 3/4] phy: cadence-torrent: Do not configure SERDES if it's >> already configured >> >> EXTERNAL MAIL >> >> >> Do not configure torrent SERDES if it's already configured. >> >> Signed-off-by: Kishon Vijay Abraham I >> --- >> drivers/phy/cadence/phy-cadence-torrent.c | 32 ++++++++++++++++------- >> 1 file changed, 22 insertions(+), 10 deletions(-) >> >> diff --git a/drivers/phy/cadence/phy-cadence-torrent.c >> b/drivers/phy/cadence/phy-cadence-torrent.c >> index ab51c4bf7b30..5ee1657f5a1c 100644 >> --- a/drivers/phy/cadence/phy-cadence-torrent.c >> +++ b/drivers/phy/cadence/phy-cadence-torrent.c >> @@ -371,6 +371,10 @@ static const struct phy_ops cdns_torrent_phy_ops = >> { >> .owner = THIS_MODULE, >> }; >> >> +static const struct phy_ops noop_ops = { >> + .owner = THIS_MODULE, >> +}; >> + >> struct cdns_reg_pairs { >> u32 val; >> u32 off; >> @@ -2306,6 +2310,7 @@ static int cdns_torrent_phy_probe(struct >> platform_device *pdev) >> struct device_node *child; >> int ret, subnodes, node = 0, i; >> u32 total_num_lanes = 0; >> + int already_configured; >> u8 init_dp_regmap = 0; >> u32 phy_type; >> >> @@ -2344,16 +2349,20 @@ static int cdns_torrent_phy_probe(struct >> platform_device *pdev) >> if (ret) >> return ret; >> >> - ret = cdns_torrent_reset(cdns_phy); >> - if (ret) >> - goto clk_cleanup; >> + regmap_field_read(cdns_phy->phy_pma_cmn_ctrl_1, >> &already_configured); >> >> - ret = cdns_torrent_clk(cdns_phy); >> - if (ret) >> - goto clk_cleanup; >> + if (!already_configured) { >> + ret = cdns_torrent_reset(cdns_phy); >> + if (ret) >> + goto clk_cleanup; >> + >> + ret = cdns_torrent_clk(cdns_phy); >> + if (ret) >> + goto clk_cleanup; >> > Should if (!already_configured) be checked while calling clk_disable_unprepare()? Both clk_unprepare() and clk_disable() checks for passed clk for ERR or NULL. So don't think it's necessary to have !already_configured check. > Otherwise, > Reviewed-by: Swapnil Jakhade Thanks Kishon > > Thanks & regards, > Swapnil > >> - /* Enable APB */ >> - reset_control_deassert(cdns_phy->apb_rst); >> + /* Enable APB */ >> + reset_control_deassert(cdns_phy->apb_rst); >> + } >> >> for_each_available_child_of_node(dev->of_node, child) { >> struct phy *gphy; >> @@ -2423,7 +2432,10 @@ static int cdns_torrent_phy_probe(struct >> platform_device *pdev) >> of_property_read_u32(child, "cdns,ssc-mode", >> &cdns_phy->phys[node].ssc_mode); >> >> - gphy = devm_phy_create(dev, child, >> &cdns_torrent_phy_ops); >> + if (!already_configured) >> + gphy = devm_phy_create(dev, child, >> &cdns_torrent_phy_ops); >> + else >> + gphy = devm_phy_create(dev, child, &noop_ops); >> if (IS_ERR(gphy)) { >> ret = PTR_ERR(gphy); >> goto put_child; >> @@ -2507,7 +2519,7 @@ static int cdns_torrent_phy_probe(struct >> platform_device *pdev) >> goto put_lnk_rst; >> } >> >> - if (cdns_phy->nsubnodes > 1) { >> + if (cdns_phy->nsubnodes > 1 && !already_configured) { >> ret = cdns_torrent_phy_configure_multilink(cdns_phy); >> if (ret) >> goto put_lnk_rst; >> -- >> 2.17.1 >