From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 750A3C433DB for ; Wed, 27 Jan 2021 11:14:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2F1382075B for ; Wed, 27 Jan 2021 11:14:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236541AbhA0LOr (ORCPT ); Wed, 27 Jan 2021 06:14:47 -0500 Received: from foss.arm.com ([217.140.110.172]:39830 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236567AbhA0LMF (ORCPT ); Wed, 27 Jan 2021 06:12:05 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 22B0C31B; Wed, 27 Jan 2021 03:11:19 -0800 (PST) Received: from [10.57.4.29] (unknown [10.57.4.29]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 1819D3F66B; Wed, 27 Jan 2021 03:11:16 -0800 (PST) Subject: Re: [PATCH] drm/lima: add governor data with pre-defined thresholds From: Lukasz Luba To: Christian Hewitt Cc: Qiang Yu , David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org, lima@lists.freedesktop.org, linux-kernel@vger.kernel.org, Steven Price References: <20210125081804.13016-1-christianshewitt@gmail.com> <9e30a8e1-ef69-5929-17f1-cdb603686495@arm.com> Message-ID: <88ae6467-07fc-2c4e-9db9-a02a00d01347@arm.com> Date: Wed, 27 Jan 2021 11:11:14 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <9e30a8e1-ef69-5929-17f1-cdb603686495@arm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 1/27/21 10:24 AM, Lukasz Luba wrote: > Hi Christian, > > On 1/25/21 8:18 AM, Christian Hewitt wrote: >> This patch adapts the panfrost pre-defined thresholds change [0] to the >> lima driver to improve real-world performance. The upthreshold value has >> been set to ramp GPU frequency to max freq faster (compared to panfrost) >> to compensate for the lower overall performance of utgard devices. >> >> [0] >> https://patchwork.kernel.org/project/dri-devel/patch/20210121170445.19761-1-lukasz.luba@arm.com/ >> >> >> Signed-off-by: Christian Hewitt >> --- >> I have been using Kodi as my test application. If you scroll in library >> views with hundreds of list items and the panfrost values the slow GPU >> ramp up is quite noticeable and the GUI feels sluggish. As everything >> lima runs on is inherently slower than panfrost using devices I believe >> it's better to ramp up to max freq quicker. > > It's quite low value for the upthreshold, but I believe you have > experimented and observed that a bit higher (30, 40?) don't work well. > I don't know the Kodi system, though. > > You can check if the other frequencies are also used in statistics for > devfreq device: > cat /sys/class/devfreq//trans_stats > > If they are also used, then it OK (better than stuck at min freq). I've just realized that your board might suffer a another issue. Please apply this patch [1] and run your experiments with upthresholds. [1] https://lore.kernel.org/lkml/20210127105121.20345-1-lukasz.luba@arm.com/