From: Sekhar Nori <nsekhar@ti.com>
To: David Lechner <david@lechnology.com>,
Linus Walleij <linus.walleij@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Kevin Hilman <khilman@kernel.org>
Cc: linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
"Axel Haslam" <ahaslam@baylibre.com>,
"Alexandre Bailon" <abailon@baylibre.com>,
"Bartosz Gołaszewski" <bgolaszewski@baylibre.com>
Subject: Re: [PATCH 2/3] pinctrl: New driver for TI DA8XX/OMAP-L138/AM18XX pinconf
Date: Wed, 23 Nov 2016 16:34:23 +0530 [thread overview]
Message-ID: <88b3d16b-6e5b-ea75-d770-35d9adc6c677@ti.com> (raw)
In-Reply-To: <1479871767-20160-3-git-send-email-david@lechnology.com>
On Wednesday 23 November 2016 08:59 AM, David Lechner wrote:
> This adds a new driver for pinconf on TI DA8XX/OMAP-L138/AM18XX. These
s/DA8XX/DA850/
> SoCs have a separate controller for controlling pullup/pulldown groups.
>
> Signed-off-by: David Lechner <david@lechnology.com>
> +static const char *da850_pupd_get_get_group_name(struct pinctrl_dev *pctldev,
> + unsigned int selector)
> +{
> + return da850_pupd_group_names[selector];
> +}
> +
> +static int da850_pupd_get_get_group_pins(struct pinctrl_dev *pctldev,
> + unsigned int selector,
> + const unsigned int **pins,
> + unsigned int *num_pins)
> +{
> + *num_pins = 0;
> +
> + return 0;
> +}
usage of get_get_ in the function names above is odd.
Thanks,
Sekhar
next prev parent reply other threads:[~2016-11-23 11:05 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-23 3:29 [PATCH 0/3] TI DA850/OMAP-L138/AM18x pinconf David Lechner
2016-11-23 3:29 ` [PATCH 1/3] devicetree: bindings: pinctrl: Add binding for ti,da850-pupd David Lechner
2016-11-23 11:01 ` Sekhar Nori
2016-11-24 14:04 ` Linus Walleij
2016-11-28 21:54 ` Rob Herring
2016-11-23 3:29 ` [PATCH 2/3] pinctrl: New driver for TI DA8XX/OMAP-L138/AM18XX pinconf David Lechner
2016-11-23 11:04 ` Sekhar Nori [this message]
2016-11-23 16:21 ` David Lechner
2016-11-24 14:05 ` Linus Walleij
2016-11-23 3:29 ` [PATCH 3/3] ARM: dts: da850: Add node for pullup/pulldown pinconf David Lechner
2016-11-23 11:12 ` Sekhar Nori
2016-11-23 16:24 ` David Lechner
2016-11-23 22:33 ` Kevin Hilman
2016-11-24 5:54 ` Sekhar Nori
2016-11-23 11:17 ` [PATCH 0/3] TI DA850/OMAP-L138/AM18x pinconf Sekhar Nori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=88b3d16b-6e5b-ea75-d770-35d9adc6c677@ti.com \
--to=nsekhar@ti.com \
--cc=abailon@baylibre.com \
--cc=ahaslam@baylibre.com \
--cc=bgolaszewski@baylibre.com \
--cc=david@lechnology.com \
--cc=devicetree@vger.kernel.org \
--cc=khilman@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®