From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2FDFD2556E for ; Mon, 1 Dec 2025 12:18:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764591503; cv=none; b=eRs4D9McLSF4JHncMAfOFDhCkT/u83FuV8/kXljdgmEWe7UYdswZX/7F4fil4pXxO/AXDE57Fvt7KGv+PqxJxhso0AO80bCLjMcsjZ+u/n+3UwMZ27W7ak5GqhgWRVml+ceKywtvYwMQ7EqodxfX0KwPPozAorUY6c4jG6v1SoM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764591503; c=relaxed/simple; bh=AAYaNa4GQ8Ez3/aLfbHSgfhXobH7Rm4Rp7YXEtlVYUY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=d9lW45cx+CSzmo7IO+FAWcjVO1fTiZ8vozBAF3E0VR1+RxNnzoJZp3UuidF3UjdI7Dhm+SLNxIoyKc2PxeycfkzmFJfy6cIeqITNnhnLqT7OonTt6RNI2MndziGymzDnfkDi1EHgFM0JfpvbB9opYohuLFn4QFoPkPKMzOTX1aU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=HfgBPhBC; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=eYL0WXfo; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="HfgBPhBC"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="eYL0WXfo" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5B18gY063433214 for ; Mon, 1 Dec 2025 12:18:21 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= S7x/5lDJpG9MLNGER0uMlUs9xddlh9rKN8rkCt8nLcU=; b=HfgBPhBCXNALgN5S LYVVrg3Q0krv4BCSbaviNJodIg6xNfQHXUCrSbT1t9dIzem5uK9UDw2399Oche+g 2tWUrI7cIZkP7D2x9bpY/6ar8wGTXiSkN0bDdDn/VYu4pFOoCj04ftoJsq0/HK8w CsUDy6Qpe1NE09nTxhjSn/SEW+noIAaJshmecVwipW3gAWj92awSGb+701hS8Y/s mNwF4G1H/tZ0sbPnb14Qf1CyrOxJ582ZHSsAegv7lDCFhOj2nD9iKCrMUzOHy1Ar CIsFBL9w8KfhOkol39ytotuF0Zbr+kCltbk3+OgEleQdd4w9p3NQle65+PgqbBL3 ywnCmw== Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4as7re0kp0-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 01 Dec 2025 12:18:21 +0000 (GMT) Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-8b2e2342803so804206685a.3 for ; Mon, 01 Dec 2025 04:18:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1764591500; x=1765196300; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=S7x/5lDJpG9MLNGER0uMlUs9xddlh9rKN8rkCt8nLcU=; b=eYL0WXfowwb8P9ZVsQkFC++ujluiIhPP+qf72GmT3Uqmn5JLKKzXE30s12ZIVnWnrt vO+3aK8wenalFoBLymMNNJhY/XfzksgXJ33oYtwEUBN3oSRTpg2OYseRNQ47P7+jc5+W ZNCCyEU6eew/5McENHKxjJ4WWWt2T2xZlHaf7m9KS9EhlJGk+J/GlBfnYVmgST+IAsMj BGbX2vl7Di/ImlhCoPySaeVS6lxP0NFr8XhX0VCESob9yIPvekNBk/QAHt/5TaLpXNjj ocRbl0QUSGUkY4mnh4jy7zH2zU+r3MmxGpWzfUbkfZdx5zHMcyAfLSmJHEU5LL5ngbXq xhag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764591500; x=1765196300; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=S7x/5lDJpG9MLNGER0uMlUs9xddlh9rKN8rkCt8nLcU=; b=Y62h0Y8G3egRuG1QJP2fAK4RNpIWw+6qUOL+OMFXGubdFP4NfZ8kYEGbz5qQWnBhXS 6NtS9fdJs4DI4uSEpbfvu0h65w8SNes3DMbIwOxouknz47Kg+L3Rcuaw1opqvlOHsBD3 QpMrTw5fHExXCa00KQQwEjkA+uYFX4wFUGNx/3KbeLDolztwIlUy4pF1YEVjK9TJXZWb 0AM5l+z2I5NO8f6v+ojhK6yBSN1Psh354I9Khr+wg+MSthe0t3ztRUvdWRljLyb9XxJw 5XN7W6jfUn9X8lfxwPJ2j3f2Ht0S/NkQZwJr5vfiV7AvvcYKdWrGpGpsDLDiPQoarJIa 2SEg== X-Forwarded-Encrypted: i=1; AJvYcCUMy/VFlclto38zxD8cSwweYJVRY9eQdomEavJhJBMINvoCR75MRDOElldodrQacCp9oKH/WmGPCyyTlyg=@vger.kernel.org X-Gm-Message-State: AOJu0YxK6uw2CL6xyayz3RidMlSx91nIar1yDZMTquzzQ/j03NhehRni YLcQi6TOW39+5N7bpvNGhBksNyiQlGiFUtVUa2Lib8Izin61WMDl/eTW7aQ9ABea97wo1arj1a4 RUxn+dkDCpczwDYMbERV79m8ncadFsdAm23X3I6uyzPIL2J527rawu6ghDbP7nzAU+uF5fU6irR k= X-Gm-Gg: ASbGncvsWcshlGnyfIjTJOYyT7MarLqGfndcbsgWNoEebA/r6D9DnFNYgbrB4FkFUi6 NSCgXhq+bYNLVIM7lxFbOvYqZvhM0Sh/fS8zquNotWsnBLuZButtrfOnoZNkJh3d4CSRZgD/Fyd SiuyJVwn75a5SuuJjibTDclhq8xg3+90tmdmMEdW/2GEaXQOPx0dSgNKgzWJpxxZyCOi4rxYce/ VaXeK9z3h3/jUJ5NoAN/toKSf3X6vDNzfv+BnhlNs4HzSk0bow7r9b+7jJTiKaHCtRrC0GI/X/I SojbsetaH8MlBuWA9IQgRNQAZcVVOTtlb+K3vFQdWC+971hPeRCwxZEdhcBEuBcWGz5qawy5fwg H7f8bz8NlIv2w30fwohDr/w4MdPjwjd7rbfP/ X-Received: by 2002:a05:620a:4629:b0:8b2:e533:66f7 with SMTP id af79cd13be357-8b4ebd567ccmr3486883285a.10.1764591500190; Mon, 01 Dec 2025 04:18:20 -0800 (PST) X-Google-Smtp-Source: AGHT+IHR4G7h21uepjoqGj+HTnF9EXrnBkONdATlsyVgmaOwHgYnZY5PX5j8yfp1NqPWxk8IfOgLMQ== X-Received: by 2002:a05:620a:4629:b0:8b2:e533:66f7 with SMTP id af79cd13be357-8b4ebd567ccmr3486877185a.10.1764591499741; Mon, 01 Dec 2025 04:18:19 -0800 (PST) Received: from [192.168.68.121] ([5.133.47.210]) by smtp.googlemail.com with ESMTPSA id ffacd0b85a97d-42e1c5d6133sm27682614f8f.16.2025.12.01.04.18.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 01 Dec 2025 04:18:19 -0800 (PST) Message-ID: <88b63ab9-85bc-4af1-a802-e2e2f332254f@oss.qualcomm.com> Date: Mon, 1 Dec 2025 12:18:18 +0000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/3] ASoC: codecs: wcd93xx: fix OF node leaks on probe failure To: Johan Hovold , Srinivas Kandagatla , Mark Brown Cc: Liam Girdwood , Jaroslav Kysela , Takashi Iwai , linux-sound@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20251201093419.24474-1-johan@kernel.org> Content-Language: en-US From: Srinivas Kandagatla In-Reply-To: <20251201093419.24474-1-johan@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: B-vuHKS0clrRLlR4CrXsvOjTlin5vj51 X-Proofpoint-ORIG-GUID: B-vuHKS0clrRLlR4CrXsvOjTlin5vj51 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjAxMDEwMCBTYWx0ZWRfX128+h5/tnO4H KJD0pG86PAhWtk4qQgL1Rc9Ea5NBYHrQx/NwurQmWsASQyPHX6SUuK7Gh9YbKo7buOFeYHVT7F1 caz3H4XccbIVQZsZhtv6DtU/FF1vOw556qg7Hedh7t6IRLpkqdmdI86mdtpgdw8achv/VhqrsEO 92e8lTCER8CzscbPiL1qOCutjbqYty574fz0Cj5WTo48Cmv70deSMmTQ44wW8Iks0tTptZ6c/AH D11wBO4hTW/Yl0Og2M453oQ2MMl8uXBEwO8O3iq5cjU2sHrILA6S3jyg23jdIjgk3rZgtmWw8r1 jgp5LlUDaZsntuvodg3syzQx/DVISed0aS3WcvOOlXwivOPT0v5so/4yg3OGcCQ4zrK7NIdCDTc 2tWBono4Ccz/ygG3Lb8JY4ACOrp9dQ== X-Authority-Analysis: v=2.4 cv=BOa+bVQG c=1 sm=1 tr=0 ts=692d878d cx=c_pps a=50t2pK5VMbmlHzFWWp8p/g==:117 a=ZsC4DHZuhs/kKio7QBcDoQ==:17 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=MVHWC56zHThdgQPXUUYA:9 a=QEXdDO2ut3YA:10 a=IoWCM6iH3mJn3m4BftBB:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-11-28_08,2025-11-27_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 suspectscore=0 bulkscore=0 lowpriorityscore=0 spamscore=0 impostorscore=0 malwarescore=0 phishscore=0 clxscore=1015 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2512010100 On 12/1/25 9:34 AM, Johan Hovold wrote: > The original wcd938x driver has a couple of OF node reference leaks > which have been reproduced in the two later added drivers. > > Johan > Thanks for the patches, Yes, of_parse_phandle() already gets a node refcount, another refcount is redundant and will leak. LGTM Reviewed-by: Srinivas Kandagatla --srini> > Johan Hovold (3): > ASoC: codecs: wcd937x: fix OF node leaks on probe failure > ASoC: codecs: wcd938x: fix OF node leaks on probe failure > ASoC: codecs: wcd939x: fix OF node leaks on probe failure > > sound/soc/codecs/wcd937x.c | 4 ++-- > sound/soc/codecs/wcd938x.c | 3 +-- > sound/soc/codecs/wcd939x.c | 3 +-- > 3 files changed, 4 insertions(+), 6 deletions(-) >