From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BC4CC29B200 for ; Thu, 15 Jan 2026 17:22:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768497757; cv=none; b=nTPz7HtcglvbJOsU73LbQfIQA7ColYoRDStbCdla3Ezq1mUtWVjYXo5gOhPf26tZyGVMrSVwBWyyhekRJJSh8wc+jUQfWDn14rm2r34COsSKekXuaTWtraXl1z/qRrOCupdPsx1mHhKpJGrb5xjl+6WtlXzEkU/oONxg+Dmb/ZY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768497757; c=relaxed/simple; bh=XpPHNVifQQK2FTEkm6tfNXe+gQQqw9wqju3HsojCgyI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=b3Fj8ZIZgd18P0nGyKswNxkl5NTGJq+7DNowjZcaox+y0Ooy4LFeqkbeSgQXui+jCIotxmwieGK4zshP8R76luknom8lLE7dKjyR5b4qT3fxPtLYEOZrCVWR+j0jbp+zXCJgWEU6o66sZc7cCsizvUt1+LW6t05Nn6DdSXFiF7Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz; spf=pass smtp.mailfrom=suse.cz; dkim=pass (1024-bit key) header.d=suse.cz header.i=@suse.cz header.b=EAtr4zbT; dkim=permerror (0-bit key) header.d=suse.cz header.i=@suse.cz header.b=htmAa3Xt; dkim=pass (1024-bit key) header.d=suse.cz header.i=@suse.cz header.b=EAtr4zbT; dkim=permerror (0-bit key) header.d=suse.cz header.i=@suse.cz header.b=htmAa3Xt; arc=none smtp.client-ip=195.135.223.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.cz Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.cz header.i=@suse.cz header.b="EAtr4zbT"; dkim=permerror (0-bit key) header.d=suse.cz header.i=@suse.cz header.b="htmAa3Xt"; dkim=pass (1024-bit key) header.d=suse.cz header.i=@suse.cz header.b="EAtr4zbT"; dkim=permerror (0-bit key) header.d=suse.cz header.i=@suse.cz header.b="htmAa3Xt" Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 7B9455BD4C; Thu, 15 Jan 2026 17:22:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1768497752; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=kQkTbSOqov3gFGYP77dR9tb9xxqrfKQr/r07REBkWp0=; b=EAtr4zbTquzNS66eexwnv3w2SnYkOdAxhtja89ESCPzhXUQo723mRsQOzOsHrT6PdMM3L9 8onP3ajBm3DIdgIQVzHNxOBcD3cKtSSgV03AXkouRAmTDcPob/6Qm45lXTPNqynpdrXlOh Lu7JuxYwXqZSNpfkq4dS1rxo2k+l80Q= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1768497752; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=kQkTbSOqov3gFGYP77dR9tb9xxqrfKQr/r07REBkWp0=; b=htmAa3XtModxVehRTDKrHQhV7nQdZ4VrbI7EcM4oi/HSYfQjSexYqvCfPZ/AE+YGIEo0pC Whm8gKRAcNKAraAQ== Authentication-Results: smtp-out2.suse.de; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=EAtr4zbT; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=htmAa3Xt DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1768497752; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=kQkTbSOqov3gFGYP77dR9tb9xxqrfKQr/r07REBkWp0=; b=EAtr4zbTquzNS66eexwnv3w2SnYkOdAxhtja89ESCPzhXUQo723mRsQOzOsHrT6PdMM3L9 8onP3ajBm3DIdgIQVzHNxOBcD3cKtSSgV03AXkouRAmTDcPob/6Qm45lXTPNqynpdrXlOh Lu7JuxYwXqZSNpfkq4dS1rxo2k+l80Q= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1768497752; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=kQkTbSOqov3gFGYP77dR9tb9xxqrfKQr/r07REBkWp0=; b=htmAa3XtModxVehRTDKrHQhV7nQdZ4VrbI7EcM4oi/HSYfQjSexYqvCfPZ/AE+YGIEo0pC Whm8gKRAcNKAraAQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 563BE3EA63; Thu, 15 Jan 2026 17:22:32 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id LMW8FFgiaWmFDQAAD6G6ig (envelope-from ); Thu, 15 Jan 2026 17:22:32 +0000 Message-ID: <88beb165-cb8a-4c13-af96-2a7e39653f17@suse.cz> Date: Thu, 15 Jan 2026 18:22:31 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/3] mm: use nodes_and() return value to simplify client code Content-Language: en-US To: Yury Norov , Andrew Morton , Alistair Popple , Byungchul Park , David Hildenbrand , Gregory Price , Johannes Weiner , Joshua Hahn , "Liam R. Howlett" , Lorenzo Stoakes , Matthew Brost , Michal Hocko , =?UTF-8?Q?Michal_Koutn=C3=BD?= , Mike Rapoport , Rakie Kim , Suren Baghdasaryan , Tejun Heo , Waiman Long , Ying Huang , Zi Yan , cgroups@vger.kernel.org Cc: Yury Norov , Rasmus Villemoes , linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20260114172217.861204-1-ynorov@nvidia.com> <20260114172217.861204-3-ynorov@nvidia.com> From: Vlastimil Babka Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJnyBr8BQka0IFQAAoJECJPp+fMgqZkqmMQ AIbGN95ptUMUvo6aAdhxaOCHXp1DfIBuIOK/zpx8ylY4pOwu3GRe4dQ8u4XS9gaZ96Gj4bC+ jwWcSmn+TjtKW3rH1dRKopvC07tSJIGGVyw7ieV/5cbFffA8NL0ILowzVg8w1ipnz1VTkWDr 2zcfslxJsJ6vhXw5/npcY0ldeC1E8f6UUoa4eyoskd70vO0wOAoGd02ZkJoox3F5ODM0kjHu Y97VLOa3GG66lh+ZEelVZEujHfKceCw9G3PMvEzyLFbXvSOigZQMdKzQ8D/OChwqig8wFBmV QCPS4yDdmZP3oeDHRjJ9jvMUKoYODiNKsl2F+xXwyRM2qoKRqFlhCn4usVd1+wmv9iLV8nPs 2Db1ZIa49fJet3Sk3PN4bV1rAPuWvtbuTBN39Q/6MgkLTYHb84HyFKw14Rqe5YorrBLbF3rl M51Dpf6Egu1yTJDHCTEwePWug4XI11FT8lK0LNnHNpbhTCYRjX73iWOnFraJNcURld1jL1nV r/LRD+/e2gNtSTPK0Qkon6HcOBZnxRoqtazTU6YQRmGlT0v+rukj/cn5sToYibWLn+RoV1CE Qj6tApOiHBkpEsCzHGu+iDQ1WT0Idtdynst738f/uCeCMkdRu4WMZjteQaqvARFwCy3P/jpK uvzMtves5HvZw33ZwOtMCgbpce00DaET4y/UzsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZ8gcVAUJFhTonwAKCRAiT6fnzIKmZLY8D/9uo3Ut9yi2YCuASWxr7QQZ lJCViArjymbxYB5NdOeC50/0gnhK4pgdHlE2MdwF6o34x7TPFGpjNFvycZqccSQPJ/gibwNA zx3q9vJT4Vw+YbiyS53iSBLXMweeVV1Jd9IjAoL+EqB0cbxoFXvnjkvP1foiiF5r73jCd4PR rD+GoX5BZ7AZmFYmuJYBm28STM2NA6LhT0X+2su16f/HtummENKcMwom0hNu3MBNPUOrujtW khQrWcJNAAsy4yMoJ2Lw51T/5X5Hc7jQ9da9fyqu+phqlVtn70qpPvgWy4HRhr25fCAEXZDp xG4RNmTm+pqorHOqhBkI7wA7P/nyPo7ZEc3L+ZkQ37u0nlOyrjbNUniPGxPxv1imVq8IyycG AN5FaFxtiELK22gvudghLJaDiRBhn8/AhXc642/Z/yIpizE2xG4KU4AXzb6C+o7LX/WmmsWP Ly6jamSg6tvrdo4/e87lUedEqCtrp2o1xpn5zongf6cQkaLZKQcBQnPmgHO5OG8+50u88D9I rywqgzTUhHFKKF6/9L/lYtrNcHU8Z6Y4Ju/MLUiNYkmtrGIMnkjKCiRqlRrZE/v5YFHbayRD dJKXobXTtCBYpLJM4ZYRpGZXne/FAtWNe4KbNJJqxMvrTOrnIatPj8NhBVI0RSJRsbilh6TE m6M14QORSWTLRg== In-Reply-To: <20260114172217.861204-3-ynorov@nvidia.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spamd-Result: default: False [-3.01 / 50.00]; BAYES_HAM(-3.00)[99.99%]; SUSPICIOUS_RECIPS(1.50)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.20)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.cz:s=susede2_rsa,suse.cz:s=susede2_ed25519]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DKIM_SIGNED(0.00)[suse.cz:s=susede2_rsa,suse.cz:s=susede2_ed25519]; FREEMAIL_TO(0.00)[nvidia.com,linux-foundation.org,sk.com,kernel.org,gourry.net,cmpxchg.org,gmail.com,oracle.com,intel.com,suse.com,google.com,redhat.com,linux.alibaba.com,vger.kernel.org]; ARC_NA(0.00)[]; FUZZY_RATELIMITED(0.00)[rspamd.com]; RCPT_COUNT_TWELVE(0.00)[25]; MIME_TRACE(0.00)[0:+]; FREEMAIL_ENVRCPT(0.00)[gmail.com]; RCVD_TLS_ALL(0.00)[]; TO_DN_SOME(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; DNSWL_BLOCKED(0.00)[2a07:de40:b281:104:10:150:64:97:from,2a07:de40:b281:106:10:150:64:167:received]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; FREEMAIL_CC(0.00)[gmail.com,rasmusvillemoes.dk,kvack.org,vger.kernel.org]; MID_RHS_MATCH_FROM(0.00)[]; TAGGED_RCPT(0.00)[]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received]; DKIM_TRACE(0.00)[suse.cz:+]; RCVD_VIA_SMTP_AUTH(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo,imap1.dmz-prg2.suse.org:rdns,suse.cz:mid,suse.cz:dkim,suse.cz:email] X-Spam-Flag: NO X-Spam-Score: -3.01 X-Rspamd-Queue-Id: 7B9455BD4C X-Rspamd-Action: no action X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Spam-Level: On 1/14/26 18:22, Yury Norov wrote: > establish_demotion_targets() and kernel_migrate_pages() call > node_empty() immediately after calling nodes_and(). Now that > nodes_and() return false if nodemask is empty, drop the latter. > > Signed-off-by: Yury Norov Acked-by: Vlastimil Babka > --- > mm/memory-tiers.c | 3 +-- > mm/mempolicy.c | 3 +-- > 2 files changed, 2 insertions(+), 4 deletions(-) > > diff --git a/mm/memory-tiers.c b/mm/memory-tiers.c > index 864811fff409..2cbef49a587d 100644 > --- a/mm/memory-tiers.c > +++ b/mm/memory-tiers.c > @@ -475,8 +475,7 @@ static void establish_demotion_targets(void) > */ > list_for_each_entry_reverse(memtier, &memory_tiers, list) { > tier_nodes = get_memtier_nodemask(memtier); > - nodes_and(tier_nodes, node_states[N_CPU], tier_nodes); > - if (!nodes_empty(tier_nodes)) { > + if (nodes_and(tier_nodes, node_states[N_CPU], tier_nodes)) { > /* > * abstract distance below the max value of this memtier > * is considered toptier. > diff --git a/mm/mempolicy.c b/mm/mempolicy.c > index 68a98ba57882..92a0bf7619a2 100644 > --- a/mm/mempolicy.c > +++ b/mm/mempolicy.c > @@ -1909,8 +1909,7 @@ static int kernel_migrate_pages(pid_t pid, unsigned long maxnode, > } > > task_nodes = cpuset_mems_allowed(current); > - nodes_and(*new, *new, task_nodes); > - if (nodes_empty(*new)) > + if (!nodes_and(*new, *new, task_nodes)) > goto out_put; > > err = security_task_movememory(task);