From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1763371AbdJQRJV (ORCPT ); Tue, 17 Oct 2017 13:09:21 -0400 Received: from mail-wm0-f42.google.com ([74.125.82.42]:45861 "EHLO mail-wm0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759327AbdJQRJT (ORCPT ); Tue, 17 Oct 2017 13:09:19 -0400 X-Google-Smtp-Source: ABhQp+S/ALqjCpjNd3pcKynB0j+fhg74YuBLvCHvfxIsla+3eHEdmQYQrKoLejvTStkUjWWCO8CzeA== Subject: Re: [PATCH v4 1/4] clocksource: stm32: convert driver to timer_of To: Benjamin Gaignard , robh+dt@kernel.org, mark.rutland@arm.com, linux@armlinux.org.uk, mcoquelin.stm32@gmail.com, alexandre.torgue@st.com, tglx@linutronix.de, ludovic.barre@st.com Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <1506959513-16851-1-git-send-email-benjamin.gaignard@linaro.org> <1506959513-16851-2-git-send-email-benjamin.gaignard@linaro.org> From: Daniel Lezcano Message-ID: <88c8f124-4cb1-a982-d4a2-c029ab0dcd2a@linaro.org> Date: Tue, 17 Oct 2017 19:09:14 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <1506959513-16851-2-git-send-email-benjamin.gaignard@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/10/2017 17:51, Benjamin Gaignard wrote: > Convert driver to use timer_of helpers. This allow to remove > custom proprietary structure. > > Signed-off-by: Benjamin Gaignard > --- [ ... ] > - clockevents_config_and_register(&data->evtdev, > - DIV_ROUND_CLOSEST(rate, prescaler), > - 0x1, max_delta); > - > - ret = request_irq(irq, stm32_clock_event_handler, IRQF_TIMER, > - "stm32 clockevent", data); > - if (ret) { > - pr_err("%pOF: failed to request irq.\n", np); > - goto err_get_irq; > - } > + clockevents_config_and_register(&to->clkevt, > + timer_of_period(to), 0x60, max_delta); Why 0x1 -> 0x60 ? -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog