From: Nicolai Buchwitz <nb@tipi-net.de>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Sunil Goutham <sgoutham@marvell.com>,
Geetha sowjanya <gakula@marvell.com>,
Ratheesh Kannoth <rkannoth@marvell.com>,
Subbaraya Sundeep <sbhatta@marvell.com>,
Bharat Bhushan <bbhushan2@marvell.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@kernel.org>,
Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] octeontx2-pf: fix skb use-after-free with ipsec crypto offload
Date: Thu, 22 Oct 2026 10:57:48 +0200 [thread overview]
Message-ID: <88ca4db1ebc01483bdcc7702f2a542f2@tipi-net.de> (raw)
In-Reply-To: <20261021170856.15bb09ff@kernel.org>
On 22.10.2026 02:08, Jakub Kicinski wrote:
> On Mon, 19 Oct 2026 17:04:33 +0200 Nicolai Buchwitz wrote:
>> + /* Crypto hardware need write permission for ipsec crypto offload */
>> + if (unlikely(xfrm_offload(skb)) && skb_cloned(skb) &&
>> + skb_ensure_writable(skb, skb->len)) {
>> + dev_kfree_skb_any(skb);
>> + return true;
>> + }
>
> Why just for cloned packets? Frags themselves may be read only
> if they are spliced filesystem pages.
Right, spliced or zerocopy pages would be encrypted in place too. I'll
send a v2.
Thanks,
Nicolai
--
pw-bot: cr
prev parent reply other threads:[~2026-10-22 8:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-19 15:04 Nicolai Buchwitz
2026-10-21 3:16 ` Ratheesh Kannoth
2026-10-21 6:59 ` Nicolai Buchwitz
2026-10-21 8:19 ` Ratheesh Kannoth
2026-10-22 0:08 ` Jakub Kicinski
2026-10-22 8:57 ` Nicolai Buchwitz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=88ca4db1ebc01483bdcc7702f2a542f2@tipi-net.de \
--to=nb@tipi-net.de \
--cc=andrew+netdev@lunn.ch \
--cc=bbhushan2@marvell.com \
--cc=davem@davemloft.net \
--cc=edumazet@kernel.org \
--cc=gakula@marvell.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rkannoth@marvell.com \
--cc=sbhatta@marvell.com \
--cc=sgoutham@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®