mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Andrew Halaney <ahalaney@redhat.com>, linux-kernel@vger.kernel.org
Cc: agross@kernel.org, andersson@kernel.org, robh+dt@kernel.org,
	krzysztof.kozlowski+dt@linaro.org, linux-arm-msm@vger.kernel.org,
	devicetree@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: qcom: sa8155p-adp: Make compatible the first property
Date: Tue, 11 Apr 2023 22:44:36 +0200	[thread overview]
Message-ID: <88d41729-86be-95cb-2fda-1b809f07ed6b@linaro.org> (raw)
In-Reply-To: <20230411203144.471192-1-ahalaney@redhat.com>



On 11.04.2023 22:31, Andrew Halaney wrote:
> As stated at the below link in another review, compatible is always the
> first property.
> 
> Follow suit here to avoid copying incorrectly in the future.
> 
> Link: https://lore.kernel.org/netdev/20230331215804.783439-1-ahalaney@redhat.com/T/#ma76b4116bbb9e49ee4bcf699e40935d80965b3f3
> Signed-off-by: Andrew Halaney <ahalaney@redhat.com>
> ---
Thanks for this patch!
>  arch/arm64/boot/dts/qcom/sa8155p-adp.dts | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sa8155p-adp.dts b/arch/arm64/boot/dts/qcom/sa8155p-adp.dts
> index 459384ec8f23..8c773b856eb1 100644
> --- a/arch/arm64/boot/dts/qcom/sa8155p-adp.dts
> +++ b/arch/arm64/boot/dts/qcom/sa8155p-adp.dts
> @@ -351,19 +351,18 @@ &ethernet {
>  	max-speed = <1000>;
>  
>  	mdio {
> +		compatible = "snps,dwmac-mdio";
>  		#address-cells = <0x1>;
>  		#size-cells = <0x0>;
Since you're already touching this file, can you make the
-cells values decimal..
>  
> -		compatible = "snps,dwmac-mdio";
> -
>  		/* Micrel KSZ9031RNZ PHY */
>  		rgmii_phy: phy@7 {
> +			compatible = "ethernet-phy-ieee802.3-c22";
>  			reg = <0x7>;
>  
>  			interrupt-parent = <&tlmm>;
..remove the useless interrupt-parent..

>  			interrupts-extended = <&tlmm 124 IRQ_TYPE_EDGE_FALLING>; /* phy intr */
...and the similarly not very useful comment here?

Konrad

>  			device_type = "ethernet-phy";
> -			compatible = "ethernet-phy-ieee802.3-c22";
>  		};
>  	};
>  };

  reply	other threads:[~2023-04-11 20:45 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-11 20:31 Andrew Halaney
2023-04-11 20:44 ` Konrad Dybcio [this message]
2023-04-11 21:32   ` Andrew Halaney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=88d41729-86be-95cb-2fda-1b809f07ed6b@linaro.org \
    --to=konrad.dybcio@linaro.org \
    --cc=agross@kernel.org \
    --cc=ahalaney@redhat.com \
    --cc=andersson@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®