From: "Michel Dänzer" <michel.daenzer@mailbox.org>
To: Lee Jones <lee@kernel.org>, Jani Nikula <jani.nikula@linux.intel.com>
Cc: "Karol Herbst" <kherbst@redhat.com>,
nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
"Mikko Perttunen" <mperttunen@nvidia.com>,
"Maíra Canal" <mairacanal@riseup.net>,
"Thierry Reding" <thierry.reding@gmail.com>,
"Laurent Pinchart" <laurent.pinchart@ideasonboard.com>,
"Sumit Semwal" <sumit.semwal@linaro.org>,
"Shashank Sharma" <shashank.sharma@amd.com>,
"Michal Simek" <michal.simek@xilinx.com>,
amd-gfx@lists.freedesktop.org,
"Jonathan Hunter" <jonathanh@nvidia.com>,
"Luben Tuikov" <luben.tuikov@amd.com>,
"Danilo Krummrich" <dakr@redhat.com>,
"Ben Skeggs" <bskeggs@redhat.com>,
"Stanley Yang" <Stanley.Yang@amd.com>,
linux-media@vger.kernel.org,
"Thomas Zimmermann" <tzimmermann@suse.de>,
"Sascha Hauer" <s.hauer@pengutronix.de>,
"Maxime Ripard" <mripard@kernel.org>,
linaro-mm-sig@lists.linaro.org, linux-tegra@vger.kernel.org,
"NXP Linux Team" <linux-imx@nxp.com>,
linux-arm-kernel@lists.infradead.org,
"Hyun Kwon" <hyun.kwon@xilinx.com>,
"Pan, Xinhui" <Xinhui.Pan@amd.com>,
linux-kernel@vger.kernel.org,
"Hawking Zhang" <Hawking.Zhang@amd.com>,
"Jerome Glisse" <glisse@freedesktop.org>,
"Pengutronix Kernel Team" <kernel@pengutronix.de>,
"Alex Deucher" <alexander.deucher@amd.com>,
"Gourav Samaiya" <gsamaiya@nvidia.com>,
"Shawn Guo" <shawnguo@kernel.org>,
"Christian König" <christian.koenig@amd.com>,
"Mario Limonciello" <mario.limonciello@amd.com>
Subject: Re: [PATCH (set 1) 00/20] Rid W=1 warnings from GPU
Date: Mon, 28 Aug 2023 18:11:05 +0200 [thread overview]
Message-ID: <88d4d764-6b71-3eff-3e2c-31f2b2f3ea6f@mailbox.org> (raw)
In-Reply-To: <20230824120735.GS1380343@google.com>
On 8/24/23 14:07, Lee Jones wrote:
> On Thu, 24 Aug 2023, Jani Nikula wrote:
>> On Thu, 24 Aug 2023, Lee Jones <lee@kernel.org> wrote:
>>> This set is part of a larger effort attempting to clean-up W=1
>>> kernel builds, which are currently overwhelmingly riddled with
>>> niggly little warnings.
>>
>> The next question is, how do we keep it W=1 clean going forward?
>
> My plan was to fix them all, then move each warning to W=0.
>
> Arnd recently submitted a set doing just that for a bunch of them.
>
> https://lore.kernel.org/all/20230811140327.3754597-1-arnd@kernel.org/
>
> I like to think a bunch of this is built on top of my previous efforts.
>
> GPU is a particularly tricky though - the warnings seem to come in faster
> than I can squash them. Maybe the maintainers can find a way to test
> new patches on merge?
One approach for this which has proved effective in Mesa and other projects is to make warnings fatal in CI which must pass for any changes to be merged. There is ongoing work toward introducing this for the DRM subsystem, using gitlab.freedesktop.org CI.
--
Earthling Michel Dänzer | https://redhat.com
Libre software enthusiast | Mesa and Xwayland developer
prev parent reply other threads:[~2023-08-28 16:12 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-24 7:36 Lee Jones
2023-08-24 7:36 ` [PATCH 01/20] drm/xlnx/zynqmp_disp: Use correct kerneldoc formatting in zynqmp_disp Lee Jones
2023-08-28 16:39 ` Laurent Pinchart
2023-08-28 19:33 ` Randy Dunlap
2023-08-24 7:36 ` [PATCH 02/20] drm/nouveau/nvkm/subdev/acr/lsfw: Remove unused variable 'loc' Lee Jones
2023-08-24 7:36 ` [PATCH 03/20] drm/nouveau/nvkm/subdev/bios/init: Demote a bunch of kernel-doc abuses Lee Jones
2023-08-24 8:41 ` Karol Herbst
2023-08-24 7:36 ` [PATCH 04/20] drm/nouveau/nvkm/subdev/volt/gk20a: Demote kerneldoc abuses Lee Jones
2023-08-24 8:41 ` Karol Herbst
2023-08-24 7:36 ` [PATCH 05/20] drm/nouveau/nvkm/engine/gr/gf100: Demote kerneldoc abuse Lee Jones
2023-08-24 8:41 ` Karol Herbst
2023-08-24 7:36 ` [PATCH 06/20] drm/nouveau/dispnv04/crtc: Demote kerneldoc abuses Lee Jones
2023-08-24 8:42 ` Karol Herbst
2023-08-24 7:36 ` [PATCH 07/20] drm/radeon/radeon_ttm: Remove unused variable 'rbo' from radeon_bo_move() Lee Jones
2023-08-24 14:53 ` Alex Deucher
2023-08-24 7:36 ` [PATCH 08/20] drm/amd/amdgpu/sdma_v6_0: Demote a bunch of half-completed function headers Lee Jones
2023-08-24 7:36 ` [PATCH 09/20] drm/tests/drm_kunit_helpers: Place correct function name in the comment header Lee Jones
2023-08-24 7:36 ` [PATCH 10/20] drm/scheduler/sched_main: Provide short description of missing param 'result' Lee Jones
2023-08-24 9:42 ` [Linaro-mm-sig] " Christian König
2023-08-24 7:36 ` [PATCH 11/20] drm/amd/amdgpu/amdgpu_doorbell_mgr: Correct misdocumented param 'doorbell_index' Lee Jones
2023-08-24 8:25 ` Sharma, Shashank
2023-08-24 14:59 ` Alex Deucher
2023-08-24 7:36 ` [PATCH 12/20] drm/amd/amdgpu/amdgpu_device: Provide suitable description for param 'xcc_id' Lee Jones
2023-08-24 14:54 ` Alex Deucher
2023-08-24 7:36 ` [PATCH 13/20] drm/tests/drm_kunit_helpers: Correct possible double-entry typo in 'ddrm_kunit_helper_acquire_ctx_alloc' Lee Jones
2023-08-24 8:53 ` Maxime Ripard
2023-08-24 12:11 ` Lee Jones
2023-08-24 7:36 ` [PATCH 14/20] drm/imx/ipuv3/imx-ldb: Increase buffer size to ensure all possible values can be stored Lee Jones
2023-08-24 7:37 ` [PATCH 15/20] drm/tegra/hub: " Lee Jones
2023-08-24 9:25 ` Thierry Reding
2023-08-24 9:33 ` Jani Nikula
2023-08-24 12:01 ` Lee Jones
2023-08-24 13:45 ` Thierry Reding
2023-08-24 7:37 ` [PATCH 16/20] drm/drm_connector: Provide short description of param 'supported_colorspaces' Lee Jones
2023-08-24 9:00 ` (subset) " Maxime Ripard
2023-08-24 7:37 ` [PATCH 17/20] drm/amd/amdgpu/amdgpu_ras: Increase buffer size to account for all possible values Lee Jones
2023-08-24 14:55 ` Alex Deucher
2023-08-24 7:37 ` [PATCH 18/20] drm/drm_gpuva_mgr: Remove set but unused variable 'prev' Lee Jones
2023-08-24 12:53 ` Danilo Krummrich
2023-08-24 7:37 ` [PATCH 19/20] drm/amd/amdgpu/amdgpu_sdma: Increase buffer size to account for all possible values Lee Jones
2023-08-24 14:56 ` Alex Deucher
2023-08-24 7:37 ` [PATCH 20/20] drm/amd/amdgpu/imu_v11_0: Increase buffer size to ensure all possible values can be stored Lee Jones
2023-08-24 14:57 ` Alex Deucher
2023-08-24 8:59 ` [PATCH (set 1) 00/20] Rid W=1 warnings from GPU Maxime Ripard
2023-08-24 9:03 ` Maxime Ripard
2023-08-24 12:10 ` Lee Jones
2023-08-24 9:03 ` Jani Nikula
2023-08-24 9:16 ` Maxime Ripard
2023-08-24 12:07 ` Lee Jones
2023-08-24 12:08 ` Lee Jones
2023-08-24 12:14 ` Hamza Mahfooz
2023-08-24 12:24 ` Lee Jones
2023-08-28 16:11 ` Michel Dänzer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=88d4d764-6b71-3eff-3e2c-31f2b2f3ea6f@mailbox.org \
--to=michel.daenzer@mailbox.org \
--cc=Hawking.Zhang@amd.com \
--cc=Stanley.Yang@amd.com \
--cc=Xinhui.Pan@amd.com \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=bskeggs@redhat.com \
--cc=christian.koenig@amd.com \
--cc=dakr@redhat.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=glisse@freedesktop.org \
--cc=gsamaiya@nvidia.com \
--cc=hyun.kwon@xilinx.com \
--cc=jani.nikula@linux.intel.com \
--cc=jonathanh@nvidia.com \
--cc=kernel@pengutronix.de \
--cc=kherbst@redhat.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=lee@kernel.org \
--cc=linaro-mm-sig@lists.linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=luben.tuikov@amd.com \
--cc=mairacanal@riseup.net \
--cc=mario.limonciello@amd.com \
--cc=michal.simek@xilinx.com \
--cc=mperttunen@nvidia.com \
--cc=mripard@kernel.org \
--cc=nouveau@lists.freedesktop.org \
--cc=s.hauer@pengutronix.de \
--cc=shashank.sharma@amd.com \
--cc=shawnguo@kernel.org \
--cc=sumit.semwal@linaro.org \
--cc=thierry.reding@gmail.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®