From: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
agross@kernel.org, andersson@kernel.org,
konrad.dybcio@linaro.org, djakov@kernel.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org
Cc: linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
benl@squareup.com, shawn.guo@linaro.org,
fabien.parent@linaro.org, leo.yan@linaro.org,
dmitry.baryshkov@linaro.org, Jun Nie <jun.nie@linaro.org>,
James Willcox <jwillcox@squareup.com>,
Joseph Gates <jgates@squareup.com>, Max Chen <mchen@squareup.com>,
Zac Crosby <zac@squareup.com>,
Vincent Knecht <vincent.knecht@mailoo.org>,
Stephan Gerhold <stephan@gerhold.net>
Subject: Re: [PATCH v2 4/7] arm64: dts: qcom: Add msm8939 SoC
Date: Tue, 10 Jan 2023 13:14:22 +0000 [thread overview]
Message-ID: <88d66834-ca80-888b-e56e-7694e84b6eae@linaro.org> (raw)
In-Reply-To: <6e594438-843a-d03e-5276-d6316a9dc2c0@linaro.org>
On 03/01/2023 09:14, Krzysztof Kozlowski wrote:
> ../arch/arm64/boot/dts/qcom/msm8939.dtsi:1825.23-1842.5: Warning
> (simple_bus_reg): /soc@0/mmc@7824000: simple-bus unit address format
> error, expected "7824900
For the record the driver consuming this dt entry requires the host regs
to come first followed by the core
sdhc_1: mmc@7824000 {
compatible = "qcom,msm8916-sdhci", "qcom,sdhci-msm-v4";
reg = <0x07824900 0x11c>, <0x07824000 0x800>;
reg-names = "hc", "core";
}
If I change this and the msm8916 to
sdhc_1: mmc@7824000 {
compatible = "qcom,msm8916-sdhci", "qcom,sdhci-msm-v4";
reg = <0x07824000 0x800>, <0x07824900 0x11c>;
reg-names = "core", "hc";
}
the warning goes away but then this code won't work as intended anymore.
drivers/mmc/host/sdhci-msm.c: msm_host->core_mem =
devm_platform_ioremap_resource(pdev, 1);
Weirdly when I change the ordering of the registers in the dts the SD
seems to work just fine, which is at variance to my reading of the code.
Converting the sdhci driver to use the register name, instead of a
static ordering of the regs feels like something to be done in a
separate series.
---
bod
next prev parent reply other threads:[~2023-01-10 13:14 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-03 1:08 [PATCH v2 0/7] Add MSM8939 SoC support with two devices Bryan O'Donoghue
2023-01-03 1:08 ` [PATCH v2 1/7] dt-bindings: interconnect: Move interconnect child node definition Bryan O'Donoghue
2023-01-03 9:02 ` Krzysztof Kozlowski
2023-01-03 1:08 ` [PATCH v2 2/7] dt-bindings: arm: qcom: Document MSM8939 SoC binding Bryan O'Donoghue
2023-01-03 9:04 ` Krzysztof Kozlowski
2023-01-03 1:09 ` [PATCH v2 3/7] dt-bindings: soc: qcom: smd-rpm: Exclude MSM8936 from glink-channels Bryan O'Donoghue
2023-01-03 9:04 ` Krzysztof Kozlowski
2023-01-03 9:19 ` Krzysztof Kozlowski
2023-01-03 1:09 ` [PATCH v2 4/7] arm64: dts: qcom: Add msm8939 SoC Bryan O'Donoghue
2023-01-03 2:16 ` Konrad Dybcio
2023-01-03 2:32 ` Konrad Dybcio
2023-01-03 9:14 ` Krzysztof Kozlowski
2023-01-10 13:14 ` Bryan O'Donoghue [this message]
2023-01-10 13:24 ` Krzysztof Kozlowski
2023-01-10 13:42 ` Bryan O'Donoghue
2023-01-10 14:47 ` Konrad Dybcio
2023-01-11 9:12 ` Krzysztof Kozlowski
2023-01-03 9:16 ` Krzysztof Kozlowski
2023-01-03 1:09 ` [PATCH v2 5/7] arm64: dts: qcom: Add msm8939-pm8916.dtsi include Bryan O'Donoghue
2023-01-03 1:09 ` [PATCH v2 6/7] arm64: dts: qcom: Add Square apq8039-t2 board Bryan O'Donoghue
2023-01-03 2:22 ` Konrad Dybcio
2023-01-03 9:17 ` Krzysztof Kozlowski
2023-01-03 1:09 ` [PATCH v2 7/7] arm64: dts: qcom: Add msm8939 Sony Xperia M4 Aqua Bryan O'Donoghue
2023-01-03 2:29 ` Konrad Dybcio
2023-01-03 11:19 ` Bryan O'Donoghue
2023-01-03 9:19 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=88d66834-ca80-888b-e56e-7694e84b6eae@linaro.org \
--to=bryan.odonoghue@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=benl@squareup.com \
--cc=devicetree@vger.kernel.org \
--cc=djakov@kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=fabien.parent@linaro.org \
--cc=jgates@squareup.com \
--cc=jun.nie@linaro.org \
--cc=jwillcox@squareup.com \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=leo.yan@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mchen@squareup.com \
--cc=robh+dt@kernel.org \
--cc=shawn.guo@linaro.org \
--cc=stephan@gerhold.net \
--cc=vincent.knecht@mailoo.org \
--cc=zac@squareup.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®