From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4846A3ACA5F for ; Mon, 13 Jul 2026 08:24:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783931079; cv=none; b=Ws04vqVDGvPuEGPVOAkhHkx589UpcZ29k1mZuKGKHpz4KPlTVFP8vQ+NtdWtdOpNH9Py2iZBdXqGlW5JnSB2QI6CMOKNU5OjJzyprCS3da6N5xaTB4gUJpKPP+XIdyI+sMpGWDvfOETZBl6jEQPg8/DD1zC1yHEe5Z93iiE4Oj4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783931079; c=relaxed/simple; bh=sAcLEJrrx4v8nuf0z28rIvu0BNNVc+kU+REaphTJnnQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=QhQhM4gBdReEtlVnM7BIiaQMGDjYc4jEi/skNV+IhnsR8L5vwedjFQJEU50m4bld7Qo7PyhjD+Tk3gg4kqGc23v7W0PW+As5C1/f6ynoERdeUEyuPdA4WlALqPGC2AQiUEq+0hGVGuuwsao7xaLmpE0L0QEQFXf1G8udO86Yi0U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=V5QtdjtX; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=EmbBDW04; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="V5QtdjtX"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="EmbBDW04" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66D6O3BQ732794 for ; Mon, 13 Jul 2026 08:24:37 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= AtYfxbeH2oeMrlG9JnAbkDQDcuirWg4SXSYHEeZMRKQ=; b=V5QtdjtXRBo/SA1F grlAc3p+1+FbseoCfYzj57+/CDn1tiHY2i1p7/whzNAx8L+4r+Tbd8YZE+EfU5yP FPbFGajWf7RxkhUFxiRG3X60s/zI9VDYVCwoUO3aza0M2HpY36CKLvjcdNyoOVxG Hua8S9qBBrNJSvSwIG7vJy9npLv4DtMC/iWYEu/EnPg8J4eOTH3ECf1ZwHej7wa+ 1b9pazgZLDURmDFtGzysEcjj6dfZfY7e1N8xLxvvtMAK7eijkd2AD3RB0NGkU3Cb z9a8waaPKEMezCNlp3wCLHV9nKwQZnCs5vg/ao1tcMvGqU4Jevyl91DlTNNtIq1U 0SAA1g== Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fcjn39kr4-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 13 Jul 2026 08:24:37 +0000 (GMT) Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-51a8c689b5fso42038151cf.0 for ; Mon, 13 Jul 2026 01:24:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783931076; x=1784535876; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=AtYfxbeH2oeMrlG9JnAbkDQDcuirWg4SXSYHEeZMRKQ=; b=EmbBDW04YevW9sFTTUjRlLM1YNdUcRQQmma5kffdbPKLi848i+4WyGQ/X7e9fvdl/g vTPWh2XZeoi+GvqZOmRlWMEKjeTJ8AtkCQJb/6ZP/fkYncIZngITh11TOHzyOFkuyeQe 7dZ3flKNIrocP0rkz1/R0cQcBUBCVOQZ9YqNI0w6dfJT0PeT7vPE5l+9z6FUK0T+tswG ClZGNXdnbeMNXQSMxE3ELHLSyEpw6jQhbinfwydLYdAFkvxQgqXiMBqEtnltIwStvvq3 jomurNeoONPAckk/f8MFOG/7g792eEbXIIWnI+yQBJiz+YPU+qD3dsWuMS1i3MoE0LkN M4kw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783931076; x=1784535876; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=AtYfxbeH2oeMrlG9JnAbkDQDcuirWg4SXSYHEeZMRKQ=; b=fwiT+UkxosqACXMoNbTqyPGVrSlJ/+9KwmNFzDadaREA1wKIZXbiJ7WvmPpTpDANZK uZXSZZozRVq/5HKwXe0zDtx5GJ+9bPN1e+CYboMbGNjutrImM1l48wYH5kBHpkqUC7RU +B7mntKqiVOhZLWPSi8OvkDqqaCJjUbIgIg1tLcVzEm1vbuUgmQn0w96TtFB+a5CtUrg Y3MXHUG/IwRQla/wL/dEyuWiP0h5IYyfzHHXZZWa4OMD37/EyRYGg7yggRUHP3Ud4O+4 HQ667ejscHacjOEgwOmtgBtLlIup9tDF47H+znfLSPQeZn06rqb3RpAO6s9CvwA1kzZ1 13lA== X-Forwarded-Encrypted: i=1; AHgh+RrVvdXof05ZfegPLUV0ZoZVSA/zGYh8xjvMKPzIVg+wcXBiOylRXI3937qOFFKnLhjCQyHgPo8To5Vm86U=@vger.kernel.org X-Gm-Message-State: AOJu0YyL9QKNRl1v49sKKzGmMwk8S3rOzhbGDzIwcTBHgYBcwalYvN9k 2TOdMI7A5seQE4o8MJy1xiJoXFNaLp/bS+baOK4wJ3jPlkrLavIvwrLBIXXN5Nzf2LMMV1GW0x+ wyNW9E5hBP4Ffng3omEEA0g8Jv3Keq7IU+hhcW+vui9V+G5EXN1phbA4HURAseaDFL4MnX7p5xH w= X-Gm-Gg: AfdE7ckO/sdEJCLRqDbbrLZmPSSP4HNpiD1wUElQJjC2sKZ9CIkQQdhgeoPLDLcHX8X MBx4cxX89rJRZ2Jnqlpg+iM8g8Ql8nfK/a05d6xMbSs4weNrklIxEYuTdJCFa7tAwZmJRjrAw3E S4cgEuQKA5BlgMppKHZK9mB3oLP4GnWT669899lqXVOuZrw2M7ScjyT/pa6TeSgvL5w+2wfUe+y T+bS46SgA8XFyDnqhk02QzqlgJONZu4BpphFHUeuDg6yPyu/0OeuoW+3Ew7HsaMGHWwZ8f5GhA7 bRWnwowUSYH3MZpCiIfOmY+wiXq6LgXTHn120tQVHxtGARVQC5rVilVcXIuSmpAfi0mDVTbRxsl S9jciS5p2/VQ5K7HqdMZKvQqig5fqxv7RLS0msHNp90A= X-Received: by 2002:a05:622a:2487:b0:51c:7b11:41b7 with SMTP id d75a77b69052e-51cbf2eeb1cmr84915061cf.83.1783931076606; Mon, 13 Jul 2026 01:24:36 -0700 (PDT) X-Received: by 2002:a05:622a:2487:b0:51c:7b11:41b7 with SMTP id d75a77b69052e-51cbf2eeb1cmr84914871cf.83.1783931076170; Mon, 13 Jul 2026 01:24:36 -0700 (PDT) Received: from [192.168.1.73] ([92.247.57.178]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c15df03dccfsm633450966b.62.2026.07.13.01.24.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 13 Jul 2026 01:24:35 -0700 (PDT) Message-ID: <88de7531-e93e-4972-8e24-b83cc9011167@oss.qualcomm.com> Date: Mon, 13 Jul 2026 11:24:34 +0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 2/5] dt-bindings: media: qcom,sm8250-camss: allow JPEG encoder child node To: Krzysztof Kozlowski , linux-media@vger.kernel.org Cc: bryan.odonoghue@linaro.org, vladimir.zapolskiy@linaro.org, loic.poulain@oss.qualcomm.com, mchehab@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, andersson@kernel.org, konradybcio@kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org References: <20260706071113.383215-1-atanas.filipov@oss.qualcomm.com> <20260706071113.383215-3-atanas.filipov@oss.qualcomm.com> Content-Language: en-US From: Atanas Filipov In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzEzMDA4NyBTYWx0ZWRfX1n1AhDxzBByd 2T0QgcOYFNBHRZfg7JemosfTh2NCoS7yzwOdGzkp09StEwd0p70IoqRIWNX4EOhZ5iLR+31/zaQ 40olf+ktrJcNmL6TWT07z61oqzSN7ar48K6pI/CtM4YBE669ColVlcCsmxfslxTNPnMMyWgmKap ExqmIuV/hrsOiA7/4INzvypADWcb/KkbQZO5h22jzYUwjucGVoSv1WafCURFSCjdWfCPPOiiMzD ZFJlXVPCayKHBLGROTSY+u8w4GEHnlHtzVacwHLJwRV/wiCJ+wobROUPSdN1gy1RvjWC471t044 MA3llFDOnQEPYNsnigjjQTjTDiamFrfNt/JrKPqqUY/SZXc9/7lNotV7PnSnitbqKoBLbK77yMd 5ddkqKUxcxPZwLZjqAY9UlVQUwJtrQZDEHGWdqR/iGKvyDWhFf+czULqP5cUkdmB+fYSF275NhP X6V+Hd05I5ZlghRVmWA== X-Proofpoint-ORIG-GUID: aqyJU3nZUT0um3njs2LsCox6-2e9eQqa X-Proofpoint-Spam-Info: AW1haW4tMjYwNzEzMDA4NyBTYWx0ZWRfX2InAg4Jpjab/ MfSnW/M3NT1FCqNMwvrAAhUI23Hq6/itiTTO3XEF8I7txvE57QcTUg45bKim3ZayUD4aeO6K774 fZvyzUh7OsmZMRWIJtX4UH60smg6d8E= X-Proofpoint-GUID: aqyJU3nZUT0um3njs2LsCox6-2e9eQqa X-Authority-Analysis: v=2.4 cv=aaJRWxot c=1 sm=1 tr=0 ts=6a54a0c5 cx=c_pps a=EVbN6Ke/fEF3bsl7X48z0g==:117 a=ybD9qRDIDfZaXNPQ7Ca20A==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=EUspDBNiAAAA:8 a=F2T7rKbpvuPzS9wY3l8A:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=a_PwQJl-kcHnX1M80qC6:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-13_02,2026-07-10_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 phishscore=0 bulkscore=0 clxscore=1015 lowpriorityscore=0 adultscore=0 malwarescore=0 spamscore=0 suspectscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607130087 On 7/6/2026 3:11 PM, Krzysztof Kozlowski wrote: > On 06/07/2026 09:11, Atanas Filipov wrote: >> The CAMSS node uses #address-cells = <2>, #size-cells = <2> and ranges >> to act as a bus for child IP blocks such as the JPEG encoder. Add these >> properties to the binding so that dtbs_check does not reject them. > > There are no children, so above are not valid. > >> >> Use unevaluatedProperties: false instead of additionalProperties: false >> so that child nodes are validated against their own schema (matched by > > This is not the purpose of unevaluatedProperties and it is not even true. > > >> compatible) without requiring the parent binding to enumerate each child >> type explicitly. This is the correct approach for a bus-like container >> node and avoids updating the camss binding for every new child device >> added in the future. >> >> No functional change. > > I see significant functional changes - you switched to unevaluatedProperties > >> >> Signed-off-by: Atanas Filipov >> --- >> .../devicetree/bindings/media/qcom,sm8250-camss.yaml | 10 +++++++++- >> 1 file changed, 9 insertions(+), 1 deletion(-) >> >> diff --git a/Documentation/devicetree/bindings/media/qcom,sm8250-camss.yaml b/Documentation/devicetree/bindings/media/qcom,sm8250-camss.yaml >> index a509d4bbcb4a..6008938ee369 100644 >> --- a/Documentation/devicetree/bindings/media/qcom,sm8250-camss.yaml >> +++ b/Documentation/devicetree/bindings/media/qcom,sm8250-camss.yaml >> @@ -102,6 +102,14 @@ properties: >> - description: IFE1 GDSC - Image Front End, Global Distributed Switch Controller. >> - description: Titan GDSC - Titan ISP Block, Global Distributed Switch Controller. >> >> + "#address-cells": >> + const: 2 >> + >> + "#size-cells": >> + const: 2 >> + >> + ranges: true >> + >> ports: >> $ref: /schemas/graph.yaml#/properties/ports >> >> @@ -317,7 +325,7 @@ required: >> - vdda-phy-supply >> - vdda-pll-supply >> >> -additionalProperties: false >> +unevaluatedProperties: false > > No, NAK. I do not see how this patch makes any sense. > >> >> examples: >> - | > > > Best regards, > Krzysztof Acknowledged. This patch is dropped in v5. JPEG is modelled as a standalone peer node — no changes to the camss binding are needed. Best regards, Atanas