From: Shuah Khan <shuah@kernel.org>
To: Masami Hiramatsu <mhiramat@kernel.org>,
linux-kselftest@vger.kernel.org,
Steven Rostedt <rostedt@goodmis.org>
Cc: Ingo Molnar <mingo@redhat.com>,
linux-kernel@vger.kernel.org, Shuah Khan <shuah@kernel.org>
Subject: Re: [PATCH] selftests: ftrace: Use md5sum to take less time of checking logs
Date: Wed, 28 Jun 2017 08:00:35 -0600 [thread overview]
Message-ID: <88e2f665-dda9-c29d-fe4b-a13a0339cfd1@kernel.org> (raw)
In-Reply-To: <149855930170.10335.7114289594738299220.stgit@devbox>
On 06/27/2017 04:28 AM, Masami Hiramatsu wrote:
> Use md5sum so that it takes less time of checking
> trace logs update. Since busybox tail/cat takes too
> long time to read the trace log, this uses md5sum
> to check whether trace log is updated or not.
>
> Signed-off-by: Masami Hiramatsu <mhiramat@kernel.org>
Applied to linux-kselftest next for 4.13-rc1
thanks,
-- Shuah
> ---
> .../test.d/ftrace/func_traceonoff_triggers.tc | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/tools/testing/selftests/ftrace/test.d/ftrace/func_traceonoff_triggers.tc b/tools/testing/selftests/ftrace/test.d/ftrace/func_traceonoff_triggers.tc
> index 9cf3852..7a9ab4f 100644
> --- a/tools/testing/selftests/ftrace/test.d/ftrace/func_traceonoff_triggers.tc
> +++ b/tools/testing/selftests/ftrace/test.d/ftrace/func_traceonoff_triggers.tc
> @@ -103,11 +103,11 @@ if [ $on != "0" ]; then
> fail "Tracing is not off"
> fi
>
> -line1=`cat trace | tail -1`
> +csum1=`md5sum trace`
> sleep $SLEEP_TIME
> -line2=`cat trace | tail -1`
> +csum2=`md5sum trace`
>
> -if [ "$line1" != "$line2" ]; then
> +if [ "$csum1" != "$csum2" ]; then
> fail "Tracing file is still changing"
> fi
>
>
>
>
next prev parent reply other threads:[~2017-06-28 14:00 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-27 10:28 Masami Hiramatsu
2017-06-28 14:00 ` Shuah Khan [this message]
2017-06-28 14:17 ` Steven Rostedt
2017-06-28 14:30 ` Shuah Khan
2017-06-28 14:59 ` Steven Rostedt
2017-06-28 15:30 ` Shuah Khan
2017-06-29 20:21 ` Shuah Khan
2017-06-30 14:49 ` Steven Rostedt
2017-06-30 16:53 ` Shuah Khan
2017-07-03 4:19 ` Masami Hiramatsu
2017-06-30 18:50 ` Denys Vlasenko
2017-06-30 19:03 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=88e2f665-dda9-c29d-fe4b-a13a0339cfd1@kernel.org \
--to=shuah@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome