From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 492683BADA9 for ; Tue, 2 Jun 2026 08:03:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780387408; cv=none; b=coPJUmufX4gmdNyO9c6uOZ/81gaCqqGRHQor4aeCoS5lhtdwuafDEUcG6UgxPVDeMYvyiXAHbEjjyZIQhNVwWMjcky4MAvo2LuXGeygl6Eg1VlhuLPdL1YuDhGrtU75VVaeUdUhDuTTp4sgAIiq7sPR92ncrdlJVuIbDH6Oiwaw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780387408; c=relaxed/simple; bh=UxpA3yT/ePLu44AO/KpEc72wgGrVctYX7JSOD2YtQuE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=JaBBxmMWsp32b0xBY6cbXAGts2kmqh2y0/qz3ps5Cn/7RGcxCbKB5Km03Bbw9QGaNYJk2YIc8rZgrJ+aJqaF9GPWwMM3fMo/7bEV+RnhPIFo/qEflh+TW2B8QrQzK/A9vlfLULG4ZJgRcN1eZs2t7jMMunqzBJf3Z0YJbWq7Ebo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Eh9NF2Wk; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=KvkpMA09; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Eh9NF2Wk"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="KvkpMA09" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6525iqxr1316634 for ; Tue, 2 Jun 2026 08:03:26 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= z2SH3tRYNqCdFVw1uC5sP1qyrvHciyAIFwzdinJEUYA=; b=Eh9NF2WknlSyINld eVIF021KSp0UjyVLCnlEdPWv6fGALXxwaR3hjkgdkRbeJvD3MPtPqP+Y3fE3mwIs MBHu/4ZHill9BS9qkj1QqcwB2xLSlRQRssp4tmZWfvoB14C+YCdBMpPyvE0RihrS cWC40osBtX3MstedUg8HWCDlm8UsPb76xp8oefRkVwqZYHcewbrUim7toUWR964c jaIc5xjh/6qsnD7KTTNAyanb9tR5sdjReNKQBbfIJvzc4LOeCMNkveIn+gfHKs1u dewKoojD3cLYODlZobHzNYebn2J7DjS3OMECavv/b/oNAN+fwL9LG5IbIzTlk4Lm vWI9LQ== Received: from mail-pj1-f70.google.com (mail-pj1-f70.google.com [209.85.216.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ehs9vrhn4-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 02 Jun 2026 08:03:26 +0000 (GMT) Received: by mail-pj1-f70.google.com with SMTP id 98e67ed59e1d1-36bc380fbf9so3979218a91.3 for ; Tue, 02 Jun 2026 01:03:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1780387406; x=1780992206; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=z2SH3tRYNqCdFVw1uC5sP1qyrvHciyAIFwzdinJEUYA=; b=KvkpMA099bX+Wc9kUy1X0MKCjCGV/oFvxFh4+3tx5Kz522AucirYiv+UiulQAc+bmm mL8m1lNYzDk4XwXF+xvu3onGVYJ6jDKu7afpVafQ1DyFm5cx3KOHaPGgAoLmEfNUmXDq g4Qu7Vt4cmKxwMVqhRzmWk0EEDHjfKL+MgdzFVHO86+BQQvw0TChT7veyXspHjpXFN4P DJt8AqfnZUaSRSmQaIad3U+r8yMokq4bFM4E4BWrwGBma1d0Hyo+T7QV0ewHnvJIccDa eiF+44RWVjYrSM4RtNn+KaLgJjKZMJ1G/qMCEqaMYuEpt2VFanFUhi33AnXD57CyJ792 qmcg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780387406; x=1780992206; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=z2SH3tRYNqCdFVw1uC5sP1qyrvHciyAIFwzdinJEUYA=; b=CDQeuvxPXh8qh5idMLJk1Txj0AoiyVsqSfPjQxQzUNoQmpG/YJWCa/ew0sM8XAwkkg 946w/KicZjCivY15IRX8rJ4uGmewcfgcb8PlicMrrgIfNLuH2XoCGspMwrrbz8lQQg0I OoXADhFiZMTQkL1kcXQs2xQrpUdnCs51GHWQ7PkgAvv+PWzFiZScvLpV5Rl3a5KZ1gXI 4tAixAH4RufHG15f/i6lBKXhezhjLOXQIabxe94qtYFVr0uQylSyMC4Hbrc3CIlFCBFe dbfPazKzMs0tclqMaZgCEH9C+twrlVNy4RJ+u8ngBtaEaABBnCx8ysOdiVOer+yp8ZTC fB0A== X-Forwarded-Encrypted: i=1; AFNElJ92obRsRTybsHD/WRDsmHNjYvIEo8WvOuLhxmyM0p/NXySH1v/OzcDKR+ppaX8Qacb7YIormC0SFkL2s4w=@vger.kernel.org X-Gm-Message-State: AOJu0YxNabOhD4al2HNxdvU3rzuCsenzxsR1TbrAFSSCaCWd6FTrWK95 5DeooWuVAaYiyL2WpY8RezaZ5xcuU1D/ZyJQK6PK+5a6pRyOoftBUU/4eYYlVq3YddJWXni8HcO pKXjinvSYUsxUQBWg7ylJ6CUPK0COI+e97cbyDsw7uLj26K/yHXmXXmhAvrB65FXWdqkBFV6kk4 Q= X-Gm-Gg: Acq92OGbidl4lEmkLkRut8LBvzNN3EIUkhJvFhrZJQ+D9y2aTY/LCE0R+eKuiY3Ax/I OJnYhs3kgvj6Q+GgLKlyoZ1j3QziK3irXOitmdKnRPOm/Oiq4O8ujNRuKF4ao3Lu4Va/eHFs9tU f73wwq1Oe/2O4+BfM1Qm8G9Hb9w4w4qMW+N2+6gnlucsP6CmJv0528yj50IoEGpGRt4MEXCxHVo jDPF4t36WVYTKyTMpmThkxV0wUYxTVV272JPwD1EFr3uasy0GKrWLs6mVZ2UxPs/JoNAzGbqfNE FiaCGsaiKD5SPJqfZDCnWDun8kEmGUnzOFZ+we2bC2v9MyIAn14Ui6CzpO/f/LNkfMGN/g0eoMb OZUX5Xpfv+kDKaQJaKQPMik/LxazGkz5pFqHGjFw+dkxReRb0JXaUYZrFcwnte8XsY8JD83RECm tW+47UD1dCwqxPBmGnl2ihUsO3Eao= X-Received: by 2002:a17:90b:2f90:b0:368:cefe:ddd0 with SMTP id 98e67ed59e1d1-36c501dff2amr14144978a91.15.1780387405770; Tue, 02 Jun 2026 01:03:25 -0700 (PDT) X-Received: by 2002:a17:90b:2f90:b0:368:cefe:ddd0 with SMTP id 98e67ed59e1d1-36c501dff2amr14144931a91.15.1780387405184; Tue, 02 Jun 2026 01:03:25 -0700 (PDT) Received: from [10.133.33.92] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-36dd9183368sm1918918a91.3.2026.06.02.01.03.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 02 Jun 2026 01:03:24 -0700 (PDT) Message-ID: <88eb2a17-99f2-4553-b3f6-e4b5b1c19d18@oss.qualcomm.com> Date: Tue, 2 Jun 2026 16:03:18 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 04/15] drm/msm/dp: split msm_dp_ctrl_config_ctrl() into link parts and stream parts To: Dmitry Baryshkov Cc: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20260528-dp_mstclean-v5-0-a9221c1f1f3b@oss.qualcomm.com> <20260528-dp_mstclean-v5-4-a9221c1f1f3b@oss.qualcomm.com> Content-Language: en-US From: Yongxing Mou In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: jhUO-ezzqghngwpFbzrJ5k_9AwHYpGsx X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjAyMDA3NCBTYWx0ZWRfXzTwUpLuRey42 XX9K2WF0QrSqq+t3iI0hF9wWBab/rdzGYRi/+RzHmzWbcSz85JRxCueXVV8NGuRgj3A9UXlMhrL lhbOA+/7Q2YgbWSSvzNUXve1duyXM1KXyP7CbgTSOMdej9YqvpQAxbiUnyzEsrxzn+GExRbGu3a 20birMpUF7HDjEHUnVGECGtXNSpzVJ+vYg8cIorvM95OoYWqmVm0pIFiewRTDin9tBUwkFiobQG eHiNKmDMh/F6Cl7iScv4hv0AlYrtFnfZIRqp+SmDlffLzx8XVIDN25ksTR2v2Gl64eXqgirl/vr HvZKjc5b60ffMY+RvWILWK+NNmLnGv3devW408PzgKfioo2ofOMaei3OYKBCOEfpGUqCEa3n3lv 2RqSW1QnXuqB3L/6qAIhJ8gOsOEpUJc+zvfGstpj+0xKYos5FJt2V6cFEuUtEogWxMaHFXd7ivi kMoMU3QhkaA2j26hqvQ== X-Authority-Analysis: v=2.4 cv=NYfWEWD4 c=1 sm=1 tr=0 ts=6a1e8e4e cx=c_pps a=0uOsjrqzRL749jD1oC5vDA==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=EUspDBNiAAAA:8 a=C3L6VYGqFeyMi-qQiaUA:9 a=QEXdDO2ut3YA:10 a=mQ_c8vxmzFEMiUWkPHU9:22 X-Proofpoint-ORIG-GUID: jhUO-ezzqghngwpFbzrJ5k_9AwHYpGsx X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-01_07,2026-05-28_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 adultscore=0 clxscore=1015 suspectscore=0 priorityscore=1501 phishscore=0 impostorscore=0 bulkscore=0 lowpriorityscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605210000 definitions=main-2606020074 On 5/28/2026 11:22 PM, Dmitry Baryshkov wrote: > On Thu, May 28, 2026 at 06:40:25PM +0800, Yongxing Mou wrote: >> The DP_CONFIGURATION_CTRL register contains both link-level and >> stream-specific fields. Currently, msm_dp_ctrl_config_ctrl() configures >> all of them together. Separate the configuration into link parts and >> stream parts to support MST. >> >> Signed-off-by: Yongxing Mou >> --- >> drivers/gpu/drm/msm/dp/dp_ctrl.c | 47 +++++++++++++++++++++++++++------------- >> 1 file changed, 32 insertions(+), 15 deletions(-) >> >> diff --git a/drivers/gpu/drm/msm/dp/dp_ctrl.c b/drivers/gpu/drm/msm/dp/dp_ctrl.c >> index 86ef8c89ad44..cc00e8d2d6c7 100644 >> --- a/drivers/gpu/drm/msm/dp/dp_ctrl.c >> +++ b/drivers/gpu/drm/msm/dp/dp_ctrl.c >> @@ -388,26 +388,45 @@ void msm_dp_ctrl_push_idle(struct msm_dp_ctrl *msm_dp_ctrl) >> drm_dbg_dp(ctrl->drm_dev, "mainlink off\n"); >> } >> >> -static void msm_dp_ctrl_config_ctrl(struct msm_dp_ctrl_private *ctrl) >> +static void msm_dp_ctrl_config_ctrl_streams(struct msm_dp_ctrl_private *ctrl, >> + struct msm_dp_panel *msm_dp_panel) >> { >> u32 config = 0, tbd; >> + >> + /* >> + * RMW: in SST, config_ctrl_link and config_ctrl_streams are called >> + * sequentially on the same thread. In MST, caller holds mst_lock. > > There is neither MST nor mst_lock. Also being called on the same thread > means nothing, there can be another thread, executing the same code > concurretly. Please point out that they are called only from the > atomic_enable() callback, which is guarantted to be executed once at a > time. > Got it.. Will fix it next patch. >> + */ >> + config = msm_dp_read_link(ctrl, REG_DP_CONFIGURATION_CTRL); >