From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B08ABC43381 for ; Mon, 18 Feb 2019 13:21:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 822012176F for ; Mon, 18 Feb 2019 13:21:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730977AbfBRNVU (ORCPT ); Mon, 18 Feb 2019 08:21:20 -0500 Received: from szxga04-in.huawei.com ([45.249.212.190]:3666 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1729064AbfBRNVT (ORCPT ); Mon, 18 Feb 2019 08:21:19 -0500 Received: from DGGEMS408-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id E44F4920536E909093C9; Mon, 18 Feb 2019 21:21:15 +0800 (CST) Received: from [127.0.0.1] (10.177.31.96) by DGGEMS408-HUB.china.huawei.com (10.3.19.208) with Microsoft SMTP Server id 14.3.408.0; Mon, 18 Feb 2019 21:21:12 +0800 Subject: Re: [PATCH -next] powerpc/pseries: Fix platform_no_drv_owner.cocci warnings To: Julia Lawall References: <20190218125930.87548-1-yuehaibing@huawei.com> CC: Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , Oliver O'Halloran , Dan Williams , , , From: YueHaibing Message-ID: <88ec8c6a-68ac-a96c-0a82-b2537fc699f2@huawei.com> Date: Mon, 18 Feb 2019 21:21:11 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.177.31.96] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2019/2/18 20:53, Julia Lawall wrote: > > > On Mon, 18 Feb 2019, YueHaibing wrote: > >> Remove .owner field if calls are used which set it automatically >> Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci >> >> Signed-off-by: YueHaibing >> --- >> arch/powerpc/platforms/pseries/papr_scm.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/arch/powerpc/platforms/pseries/papr_scm.c b/arch/powerpc/platforms/pseries/papr_scm.c >> index bba281b1fe1b..e3f5c1a01950 100644 >> --- a/arch/powerpc/platforms/pseries/papr_scm.c >> +++ b/arch/powerpc/platforms/pseries/papr_scm.c >> @@ -21,6 +21,7 @@ >> (1ul << ND_CMD_GET_CONFIG_DATA) | \ >> (1ul << ND_CMD_SET_CONFIG_DATA)) >> >> + > > No need to add a blank line. Yes, will fix it. > > julia > >> struct papr_scm_priv { >> struct platform_device *pdev; >> struct device_node *dn; >> @@ -358,7 +359,6 @@ static struct platform_driver papr_scm_driver = { >> .remove = papr_scm_remove, >> .driver = { >> .name = "papr_scm", >> - .owner = THIS_MODULE, >> .of_match_table = papr_scm_match, >> }, >> }; >> >> >> >> > > . >