mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Carlos Bilbao <carlos.bilbao@amd.com>
To: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
Cc: corbet@lwn.net, ojeda@kernel.org, jani.nikula@linux.intel.com,
	rdunlap@infradead.org, linux-doc@vger.kernel.org,
	linux-kernel@vger.kernel.org, konstantin@linuxfoundation.org,
	Akira Yokosawa <akiyks@gmail.com>,
	rust-for-linux <rust-for-linux@vger.kernel.org>
Subject: Re: [PATCH v7 2/2] docs: Integrate rustdoc generation into htmldocs
Date: Tue, 18 Jul 2023 08:54:47 -0500	[thread overview]
Message-ID: <88eefdcf-5398-97bc-161c-78f056c682a0@amd.com> (raw)
In-Reply-To: <CANiq72=jiEqYfEvcRAxXsm1BCODnpxmWZOmbGB_YwM=pUGYEeA@mail.gmail.com>

On 7/17/23 11:39, Miguel Ojeda wrote:
> On Mon, Jul 17, 2023 at 5:17 PM Carlos Bilbao <carlos.bilbao@amd.com> wrote:
>>
>> +       # Let Sphinx know we will include rustdoc
>> +       ALLSPHINXOPTS   +=  -t rustdoc
> 
> This is needed in the previous patch, no? I don't know if it fails or
> just does not work, but either way, perhaps you can split that from
> the first commit to put it last.

The previous patch works without this, the generated HTML will show in the
Rust index:

  This documentation does not include rustdoc generated information.

> 
>> +else
>> +       @echo "   Skipping Rust documentation since CONFIG_RUST is not y."
>> +endif
> 
> Is this printed for everybody? If so, then I think it is a good idea
> for the future, but perhaps a bit annoying right for most users right
> now.

Fair point, will remove as part of v8.

> 
> Cheers,
> Miguel

(CC'ed rust-for-linux list)


Thanks,
Carlos

  reply	other threads:[~2023-07-18 13:55 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-17 15:16 [PATCH v7 0/2] docs: Integrate rustdoc into Rust documentation Carlos Bilbao
2023-07-17 15:16 ` [PATCH v7 1/2] docs: Move rustdoc output, cross-reference it Carlos Bilbao
2023-07-17 16:37   ` Miguel Ojeda
2023-07-18 13:49     ` Carlos Bilbao
2023-07-18 15:24       ` Miguel Ojeda
2023-07-17 15:16 ` [PATCH v7 2/2] docs: Integrate rustdoc generation into htmldocs Carlos Bilbao
2023-07-17 16:39   ` Miguel Ojeda
2023-07-18 13:54     ` Carlos Bilbao [this message]
2023-07-18 15:32       ` Miguel Ojeda
2023-07-17 16:29 ` [PATCH v7 0/2] docs: Integrate rustdoc into Rust documentation Carlos Bilbao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=88eefdcf-5398-97bc-161c-78f056c682a0@amd.com \
    --to=carlos.bilbao@amd.com \
    --cc=akiyks@gmail.com \
    --cc=corbet@lwn.net \
    --cc=jani.nikula@linux.intel.com \
    --cc=konstantin@linuxfoundation.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=miguel.ojeda.sandonis@gmail.com \
    --cc=ojeda@kernel.org \
    --cc=rdunlap@infradead.org \
    --cc=rust-for-linux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®